From: Jarkko Sakkinen <jarkko@kernel.org>
To: Alessandro G <ale.grpp@gmail.com>
Cc: keyringsy@vger.kernel.org, stable@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Denis Kenzior <denkenz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KEYS: fix overflow in keyctl_pkey_params_get_2()
Date: Sun, 31 May 2026 20:04:50 +0300 [thread overview]
Message-ID: <ahxqMocnAcWY7Hn9@kernel.org> (raw)
In-Reply-To: <CAJXJp6jMLQvYi6rpt31hO0O5WwLipSihT9PxFJu1bvtfUS2CBw@mail.gmail.com>
On Sun, May 31, 2026 at 09:23:11AM +0200, Alessandro G wrote:
> Hi Jarkko,
>
> The surname is “Groppo” instead of “Grupp”, don’t worry and thanks for asking!
>
> Thanks also for the fix!
>
> BR,
> Alessandro
Thank you! This was a super good bug report.
Since I cannot do it without permission, can I add your tested-by to the
patch?
BR, Jarkko
>
> Il giorno dom 31 mag 2026 alle 05:25 Jarkko Sakkinen <jarkko@kernel.org> ha
> scritto:
>
> On Sun, May 31, 2026 at 05:49:13AM +0300, Jarkko Sakkinen wrote:
> > The length for the internal output buffer is calculated incorrectly,
> which
> > can result overflow when a too small buffer is provided.
> >
> > Fix the bug by allocating internal output with the size of the maximum
> > length of the cryptographic primitive instead of caller provided size.
> >
> > Cc: stable@vger.kernel.org # v4.20+
> > Fixes: 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops
> for asymmetric keys [ver #2]")
> > Reported-by: Alessandro Grupp <ale.grpp@gmail.com>
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> Should be available in -next within a day or along the lines so please
> be quick with tags/feedback. I'll forward a PR as soon as all is good.
>
> BR, Jarkko
>
prev parent reply other threads:[~2026-05-31 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 2:49 [PATCH] KEYS: fix overflow in keyctl_pkey_params_get_2() Jarkko Sakkinen
2026-05-31 3:25 ` Jarkko Sakkinen
[not found] ` <CAJXJp6jMLQvYi6rpt31hO0O5WwLipSihT9PxFJu1bvtfUS2CBw@mail.gmail.com>
2026-05-31 17:04 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahxqMocnAcWY7Hn9@kernel.org \
--to=jarkko@kernel.org \
--cc=ale.grpp@gmail.com \
--cc=denkenz@gmail.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=keyringsy@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.