From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F1E1175A80; Mon, 1 Jun 2026 01:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780278748; cv=none; b=fel44mgj6Cjx/Zu1rvTOQAyEHiTkVauBHwYN4qSEMHKrKf9WgiwR5RChQRE1o7mVT/Ui7G8SyBm3vQVZZObSSoGuowSQdsJQrnqbXmKVmXqcPpdwIE7dF7aRbYMj56KcHHRmfL6fS1yKW2YQN95ze4T3pp2cjtqPoF5moFKf+BQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780278748; c=relaxed/simple; bh=6FDHJIS2M8GTEoiYYDurmOWlUc/Ls7kEkJeXBl+EGEc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NYVADZ+x0aZJGHnCOK+4vQtAbx13JLhM9jjmWd1cvj8goI+8iMzF9glpXhY6nzsi+Jem5ppMBRj3vTGLm1RyUM07+54Ukl1aT7ZipvEg2mDBe6b+skpgoSP9iusht0MkGIOeL6PH49zGH2jTBLPev/fAbRCOYcSvI9q/q0pOWs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KYRH/paM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KYRH/paM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F8DC1F00893; Mon, 1 Jun 2026 01:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780278746; bh=vZcu83wQUzh29/MUzPMLQS8Iv0nVsOwsxAWqxDDGj50=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KYRH/paMfV8BeCgbYfsHMCWqDOtr++JkRKX25dlTAVmIboEGh885kBK9CuL9tV7tr 8pqNVZlKj2Z5eqkBjCOdCp0sLKsojv97UUmTic4Gw9ws96ZOStR0P5qLHeNR5VBGoj 3LqQJbi8ZclVXzUncbIJ1wqdlIzloAzt9PJuFY5D6+UiIWk8GmIvoBVVeICbzTfjsC Pd4h54Ftu3TrtIx88YUPUiS7ncpHA0KUeMphtpkxg9lh+Ru7ktMSIfDkYD33de5fyM gU8LQy89ioRQGwY5FsyGgbwGBRpqJv7qJ25cTr4qdLpzf66OxtRMqTcc+ABTwEWkQp AbzOUsuArFnkA== Date: Mon, 1 Jun 2026 01:52:24 +0000 From: Jaegeuk Kim To: Barry Song Cc: Theodore Tso , Bart Van Assche , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Akilesh Kailash , Christian Brauner Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number Message-ID: References: <20260522224108.GA18663@macsyma-wired.lan> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 05/31, Barry Song via Linux-f2fs-devel wrote: > On Sun, May 31, 2026 at 8:12 AM Jaegeuk Kim wrote: > > > > On 05/28, Christoph Hellwig wrote: > > > On Wed, May 27, 2026 at 03:59:35PM +0000, Jaegeuk Kim wrote: > > > > F2FS merges bios before submit_bio, regardless of small or large folios, > > > > since the block addresses are consecutive. So, I think IO subsystem was > > > > working in full speed. > > > > > > As does every other remotely modern file system. But that merging is > > > surprisingly expensive, which is why using folios gets really major > > > performance improvements. > > > > > > For one doing these checks to merge touch quite a few cache lines. > > > Second, devices are often a lot more efficient if they see fewer SGL > > > entries. I.e. having a 1MB bio a single SGL tends to work better than > > > having 256 of them. > > > The same is true in the kernel code itself, both in the submission path > > > (dma mapping and co), and even more so in the page cache handling > > > both before submitting and in the completion path. > > > > > > See Bart's patch about how long the walk of the bio_vecs in the f2fs > > > completion path can take. We had similar issues in XFS even in the > > > workqueue completion path due to lack of rescheduling, and these simply > > > go away when you do the folio manipulation in larger chunks (LAZY_PREEMPT > > > would avoid the need to explicit rescheduling these days, but that just > > > papers over the symptoms in this case). > > > > > > > I see. That's also super helpful. Let me kick off the large folio support asap. > > Thanks. > > Hi Jaegeuk, Hi Barry, > > Nanzhe has put significant effort into this work at Xiaomi over > the past several months. Large folios can now be supported on > non-immutable files. > > He has conducted extensive testing on the Pixel 6 and fixed a > number of hangs discovered during development. He is still > benchmarking performance, but the implementation appears to be > reasonably stable at this point. We can run Android Monkey for > many hours without observing any hangs. > > If you would like to see an RFC, I can ask Nanzhe to send one > as soon as possible after some cleanup and polishing. Yeah, I was about to reach out to you. Let's do some discussion offline. Thanks, > > Best regards, > Barry > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 161FCCD5BD1 for ; Mon, 1 Jun 2026 01:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iNt7ha/WRdaTygAV5drSud0KXkP6unv8PCxh1MGlqd8=; b=TWpgAALAHH0EQDgezakd+REOq6 x3Pkqe98r0Q27EEyryLe2RRl+A8KVvDW8gxjcsWKyf3Nd7X11t8aWRn87uhASj2fa5qGcizi19bvX RerzK+0xuhpQoCXwCu385x+PRyb4jZGoHw9c7Yuxj3UCPOgmqdTBLhLkdPYRrYIST1Dc=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wTrpY-0006h7-7p; Mon, 01 Jun 2026 01:52:40 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wTrpW-0006h0-Bf for linux-f2fs-devel@lists.sourceforge.net; Mon, 01 Jun 2026 01:52:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vZcu83wQUzh29/MUzPMLQS8Iv0nVsOwsxAWqxDDGj50=; b=N45FgXN95HZWFxRptvgF1WF0fW ROaQkusRZlgBtnRtsyskM38RLAyIW3nza7KWr9xRBtjnu5P89gjqzLSIGsdGltq16vmyvalaNn/h8 supYHgOgabqlKKk0EQz/GDU+hGJBgUxOC57/QW4+E6dn6/l3QMRVJqgTCq2IpTVSpZ6Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vZcu83wQUzh29/MUzPMLQS8Iv0nVsOwsxAWqxDDGj50=; b=RkdkMEAtrHNXr78YoV7/okLHaH NkGx2BJZFnWHhIEbubP6mVx39ZfDlF6TBQFSkRIFrAJ0Ui78aTlfQkInlR05K8aviQhxIACuZZie8 KqIMpYmkvIkcvv4PummZvvUmJykAs7+iSub4qd7Hfio2bXg180z6bS1bkLvYkfx4Iu2E=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wTrpV-0006Jc-47 for linux-f2fs-devel@lists.sourceforge.net; Mon, 01 Jun 2026 01:52:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 074F7402EA; Mon, 1 Jun 2026 01:52:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F8DC1F00893; Mon, 1 Jun 2026 01:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780278746; bh=vZcu83wQUzh29/MUzPMLQS8Iv0nVsOwsxAWqxDDGj50=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KYRH/paMfV8BeCgbYfsHMCWqDOtr++JkRKX25dlTAVmIboEGh885kBK9CuL9tV7tr 8pqNVZlKj2Z5eqkBjCOdCp0sLKsojv97UUmTic4Gw9ws96ZOStR0P5qLHeNR5VBGoj 3LqQJbi8ZclVXzUncbIJ1wqdlIzloAzt9PJuFY5D6+UiIWk8GmIvoBVVeICbzTfjsC Pd4h54Ftu3TrtIx88YUPUiS7ncpHA0KUeMphtpkxg9lh+Ru7ktMSIfDkYD33de5fyM gU8LQy89ioRQGwY5FsyGgbwGBRpqJv7qJ25cTr4qdLpzf66OxtRMqTcc+ABTwEWkQp AbzOUsuArFnkA== Date: Mon, 1 Jun 2026 01:52:24 +0000 To: Barry Song Message-ID: References: <20260522224108.GA18663@macsyma-wired.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1wTrpV-0006Jc-47 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: Theodore Tso , Bart Van Assche , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Akilesh Kailash , Christian Brauner Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDUvMzEsIEJhcnJ5IFNvbmcgdmlhIExpbnV4LWYyZnMtZGV2ZWwgd3JvdGU6Cj4gT24gU3Vu LCBNYXkgMzEsIDIwMjYgYXQgODoxMuKAr0FNIEphZWdldWsgS2ltIDxqYWVnZXVrQGtlcm5lbC5v cmc+IHdyb3RlOgo+ID4KPiA+IE9uIDA1LzI4LCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToKPiA+ ID4gT24gV2VkLCBNYXkgMjcsIDIwMjYgYXQgMDM6NTk6MzVQTSArMDAwMCwgSmFlZ2V1ayBLaW0g d3JvdGU6Cj4gPiA+ID4gRjJGUyBtZXJnZXMgYmlvcyBiZWZvcmUgc3VibWl0X2JpbywgcmVnYXJk bGVzcyBvZiBzbWFsbCBvciBsYXJnZSBmb2xpb3MsCj4gPiA+ID4gc2luY2UgdGhlIGJsb2NrIGFk ZHJlc3NlcyBhcmUgY29uc2VjdXRpdmUuIFNvLCBJIHRoaW5rIElPIHN1YnN5c3RlbSB3YXMKPiA+ ID4gPiB3b3JraW5nIGluIGZ1bGwgc3BlZWQuCj4gPiA+Cj4gPiA+IEFzIGRvZXMgZXZlcnkgb3Ro ZXIgcmVtb3RlbHkgbW9kZXJuIGZpbGUgc3lzdGVtLiAgQnV0IHRoYXQgbWVyZ2luZyBpcwo+ID4g PiBzdXJwcmlzaW5nbHkgZXhwZW5zaXZlLCB3aGljaCBpcyB3aHkgdXNpbmcgZm9saW9zIGdldHMg cmVhbGx5IG1ham9yCj4gPiA+IHBlcmZvcm1hbmNlIGltcHJvdmVtZW50cy4KPiA+ID4KPiA+ID4g Rm9yIG9uZSBkb2luZyB0aGVzZSBjaGVja3MgdG8gbWVyZ2UgdG91Y2ggcXVpdGUgYSBmZXcgY2Fj aGUgbGluZXMuCj4gPiA+IFNlY29uZCwgZGV2aWNlcyBhcmUgb2Z0ZW4gYSBsb3QgbW9yZSBlZmZp Y2llbnQgaWYgdGhleSBzZWUgZmV3ZXIgU0dMCj4gPiA+IGVudHJpZXMuICBJLmUuIGhhdmluZyBh IDFNQiBiaW8gYSBzaW5nbGUgU0dMIHRlbmRzIHRvIHdvcmsgYmV0dGVyIHRoYW4KPiA+ID4gaGF2 aW5nIDI1NiBvZiB0aGVtLgo+ID4gPiBUaGUgc2FtZSBpcyB0cnVlIGluIHRoZSBrZXJuZWwgY29k ZSBpdHNlbGYsIGJvdGggaW4gdGhlIHN1Ym1pc3Npb24gcGF0aAo+ID4gPiAoZG1hIG1hcHBpbmcg YW5kIGNvKSwgYW5kIGV2ZW4gbW9yZSBzbyBpbiB0aGUgcGFnZSBjYWNoZSBoYW5kbGluZwo+ID4g PiBib3RoIGJlZm9yZSBzdWJtaXR0aW5nIGFuZCBpbiB0aGUgY29tcGxldGlvbiBwYXRoLgo+ID4g Pgo+ID4gPiBTZWUgQmFydCdzIHBhdGNoIGFib3V0IGhvdyBsb25nIHRoZSB3YWxrIG9mIHRoZSBi aW9fdmVjcyBpbiB0aGUgZjJmcwo+ID4gPiBjb21wbGV0aW9uIHBhdGggY2FuIHRha2UuICBXZSBo YWQgc2ltaWxhciBpc3N1ZXMgaW4gWEZTIGV2ZW4gaW4gdGhlCj4gPiA+IHdvcmtxdWV1ZSBjb21w bGV0aW9uIHBhdGggZHVlIHRvIGxhY2sgb2YgcmVzY2hlZHVsaW5nLCBhbmQgdGhlc2Ugc2ltcGx5 Cj4gPiA+IGdvIGF3YXkgd2hlbiB5b3UgZG8gdGhlIGZvbGlvIG1hbmlwdWxhdGlvbiBpbiBsYXJn ZXIgY2h1bmtzIChMQVpZX1BSRUVNUFQKPiA+ID4gd291bGQgYXZvaWQgdGhlIG5lZWQgdG8gZXhw bGljaXQgcmVzY2hlZHVsaW5nIHRoZXNlIGRheXMsIGJ1dCB0aGF0IGp1c3QKPiA+ID4gcGFwZXJz IG92ZXIgdGhlIHN5bXB0b21zIGluIHRoaXMgY2FzZSkuCj4gPiA+Cj4gPgo+ID4gSSBzZWUuIFRo YXQncyBhbHNvIHN1cGVyIGhlbHBmdWwuIExldCBtZSBraWNrIG9mZiB0aGUgbGFyZ2UgZm9saW8g c3VwcG9ydCBhc2FwLgo+ID4gVGhhbmtzLgo+IAo+IEhpIEphZWdldWssCgpIaSBCYXJyeSwKCj4g Cj4gTmFuemhlIGhhcyBwdXQgc2lnbmlmaWNhbnQgZWZmb3J0IGludG8gdGhpcyB3b3JrIGF0IFhp YW9taSBvdmVyCj4gdGhlIHBhc3Qgc2V2ZXJhbCBtb250aHMuIExhcmdlIGZvbGlvcyBjYW4gbm93 IGJlIHN1cHBvcnRlZCBvbgo+IG5vbi1pbW11dGFibGUgZmlsZXMuCj4gCj4gSGUgaGFzIGNvbmR1 Y3RlZCBleHRlbnNpdmUgdGVzdGluZyBvbiB0aGUgUGl4ZWwgNiBhbmQgZml4ZWQgYQo+IG51bWJl ciBvZiBoYW5ncyBkaXNjb3ZlcmVkIGR1cmluZyBkZXZlbG9wbWVudC4gSGUgaXMgc3RpbGwKPiBi ZW5jaG1hcmtpbmcgcGVyZm9ybWFuY2UsIGJ1dCB0aGUgaW1wbGVtZW50YXRpb24gYXBwZWFycyB0 byBiZQo+IHJlYXNvbmFibHkgc3RhYmxlIGF0IHRoaXMgcG9pbnQuIFdlIGNhbiBydW4gQW5kcm9p ZCBNb25rZXkgZm9yCj4gbWFueSBob3VycyB3aXRob3V0IG9ic2VydmluZyBhbnkgaGFuZ3MuCj4g Cj4gSWYgeW91IHdvdWxkIGxpa2UgdG8gc2VlIGFuIFJGQywgSSBjYW4gYXNrIE5hbnpoZSB0byBz ZW5kIG9uZQo+IGFzIHNvb24gYXMgcG9zc2libGUgYWZ0ZXIgc29tZSBjbGVhbnVwIGFuZCBwb2xp c2hpbmcuCgpZZWFoLCBJIHdhcyBhYm91dCB0byByZWFjaCBvdXQgdG8geW91LiBMZXQncyBkbyBz b21lIGRpc2N1c3Npb24Kb2ZmbGluZS4KClRoYW5rcywKCj4gCj4gQmVzdCByZWdhcmRzLAo+IEJh cnJ5Cj4gCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBMaW51eC1mMmZzLWRldmVsIG1haWxpbmcgbGlzdAo+IExpbnV4LWYyZnMtZGV2ZWxAbGlz dHMuc291cmNlZm9yZ2UubmV0Cj4gaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMv bGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYy ZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2Uu bmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK