From: Patrick Steinhardt <ps@pks.im>
To: Koutian Wu via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Koutian Wu <ktwu01@gmail.com>
Subject: Re: [PATCH v2] gitattributes: fix eol attribute for Perl scripts
Date: Mon, 15 Jun 2026 10:37:17 +0200 [thread overview]
Message-ID: <ai-5vfY8D84UhsB4@pks.im> (raw)
In-Reply-To: <pull.2151.v2.git.1781510039164.gitgitgadget@gmail.com>
On Mon, Jun 15, 2026 at 07:53:58AM +0000, Koutian Wu via GitGitGadget wrote:
> Range-diff vs v1:
>
> 1: 92ba4d499d ! 1: f4b4ca30c7 gitattributes: fix eol attribute for Perl scripts
> @@
> ## Metadata ##
> -Author: ktwu01 <ktwu01@gmail.com>
> +Author: Koutian Wu <ktwu01@gmail.com>
>
> ## Commit message ##
> gitattributes: fix eol attribute for Perl scripts
> @@ Commit message
> Use eol=lf instead, matching the neighboring *.perl and *.pm rules, so
> Perl scripts are checked out with LF line endings.
>
> - Signed-off-by: ktwu01 <ktwu01@gmail.com>
> + Signed-off-by: Koutian Wu <ktwu01@gmail.com>
>
> ## .gitattributes ##
> @@
Thanks, this version looks good to me!
Patrick
next prev parent reply other threads:[~2026-06-15 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 4:25 [PATCH] gitattributes: fix eol attribute for Perl scripts Koutian Wu via GitGitGadget
2026-06-15 7:22 ` Patrick Steinhardt
2026-06-15 7:53 ` [PATCH v2] " Koutian Wu via GitGitGadget
2026-06-15 8:37 ` Patrick Steinhardt [this message]
2026-06-15 15:25 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai-5vfY8D84UhsB4@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ktwu01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.