All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Anthony PERARD <anthony.perard@vates.tech>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	xen-devel@lists.xenproject.org,
	"Ross Lagerwall" <ross.lagerwall@citrix.com>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>,
	"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Subject: Re: Assertion '!is_idle_vcpu(v)' failed after 'Remove fully_eager_fpu' commit on EFI
Date: Mon, 15 Jun 2026 11:02:05 +0200	[thread overview]
Message-ID: <ai-_jUw0QmdC7gPK@macbook.local> (raw)
In-Reply-To: <1781277924.8631fc262581453bbf619ec5b2062170.19ebc701bfb000701b@vates.tech>

On Fri, Jun 12, 2026 at 05:17:31PM +0200, Anthony PERARD wrote:
> On Fri, Jun 12, 2026 at 03:32:00PM +0100, Andrew Cooper wrote:
> > On 12/06/2026 3:20 pm, Jan Beulich wrote:
> > > On 12.06.2026 16:18, Andrew Cooper wrote:
> > >> Well, no intended change.  It was a very big patch.
> > >>
> > >> Nothing should ever be using efi_get_time().  It's unusable (i.e.
> > >> crashing) on hundreds of millions of machines.
> > >>
> > >> So, while we obviously do need to fix the assertion, this is "only"
> > >> collateral damage from having fallen into the efi_get_time() path in the
> > >> first place.  That wants investigating too.
> > > Perhaps a reduced-hardware system with ACPI_FADT_NO_CMOS_RTC set?
> > 
> > The identified system is a Broadwell-D.
> > 
> > Come to think of it, there were some systems of that era which (falsely)
> > claimed to have no CMOS.  (An HP Haswell Blade comes to mind, but it
> > will be a similar chipset.)
> 
> Some info from the boot log about the machine:
>     HPE ProLiant m510 Server Cartridge
>     BIOS Version: H05 v1.98 (02/02/2023)
>     System Memory: 32 GB
>     1 Processor(s) detected, 8 total cores enabled, Hyperthreading is enabled
>     Proc 1: Intel(R) Xeon(R) CPU D-1548 @ 2.00GHz
>     HPE Power Profile Mode: Custom
>     Power Regulator Mode: Dynamic Power Savings
>     Advanced Memory Protection Mode: Advanced ECC Support
>     Boot Mode: UEFI
>     HPE SmartMemory authenticated in all populated DIMM slots.
> 
> One of the cartridge on a Moonshot.
> 
> > > On such systems efi_get_time() would better work properly.
> 
> I guess it works fine on this system. On a different cartridge, with a
> Xen build prior to the commit, I have in the boot logs:
> 
>     Wallclock source: EFI

Can you provide the decoded dump of the ACPI FADT table?

Thanks, Roger.


  reply	other threads:[~2026-06-15  9:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 13:53 Assertion '!is_idle_vcpu(v)' failed after 'Remove fully_eager_fpu' commit on EFI Anthony PERARD
2026-06-12 14:11 ` Marek Marczykowski-Górecki
2026-06-12 14:18   ` Andrew Cooper
2026-06-12 14:20     ` Jan Beulich
2026-06-12 14:32       ` Andrew Cooper
2026-06-12 14:45         ` Jan Beulich
2026-06-12 14:54           ` Andrew Cooper
2026-06-12 15:17         ` Anthony PERARD
2026-06-15  9:02           ` Roger Pau Monné [this message]
2026-06-15 14:39             ` Anthony PERARD
2026-06-15 17:02               ` Andrew Cooper
2026-06-16  6:16                 ` Jan Beulich
2026-06-16  7:07                   ` Roger Pau Monné
2026-06-12 15:10   ` Anthony PERARD
2026-06-12 14:17 ` Jan Beulich
2026-06-12 15:41   ` [PATCH] x86/efi: Skip FPU save/restore for idle vCPU in EFI, runtime path Bernhard Kaindl
2026-06-12 16:00     ` Anthony PERARD
2026-06-15  6:52     ` Jan Beulich
2026-06-16  7:33     ` Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ai-_jUw0QmdC7gPK@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=dpsmith@apertussolutions.com \
    --cc=jbeulich@suse.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.