From: Thorsten Blum <thorsten.blum@linux.dev>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: atmel-ecc - drop unused curve id from atmel_ecdh_ctx
Date: Sat, 13 Jun 2026 16:23:59 +0200 [thread overview]
Message-ID: <ai1n_1FbXrLIRZUt@linux.dev> (raw)
In-Reply-To: <20260611105159.460794-3-thorsten.blum@linux.dev>
On Thu, Jun 11, 2026 at 12:52:01PM +0200, Thorsten Blum wrote:
> ->curve_id is only set once, but never used - remove it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/crypto/atmel-ecc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index 9da9dd6585df..93f219558c2f 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -33,7 +33,6 @@ static struct atmel_ecc_driver_data driver_data;
> * @public_key : generated when calling set_secret(). It's the responsibility
> * of the user to not call set_secret() while
> * generate_public_key() or compute_shared_secret() are in flight.
> - * @curve_id : elliptic curve id
> * @do_fallback: true when the device doesn't support the curve or when the user
> * wants to use its own private key.
> */
> @@ -41,7 +40,6 @@ struct atmel_ecdh_ctx {
> struct i2c_client *client;
> struct crypto_kpp *fallback;
> const u8 *public_key;
> - unsigned int curve_id;
> bool do_fallback;
> };
>
> @@ -250,7 +248,6 @@ static int atmel_ecdh_init_tfm(struct crypto_kpp *tfm)
> struct crypto_kpp *fallback;
> struct atmel_ecdh_ctx *ctx = kpp_tfm_ctx(tfm);
>
> - ctx->curve_id = ECC_CURVE_NIST_P256;
> ctx->client = atmel_ecc_i2c_client_alloc();
> if (IS_ERR(ctx->client)) {
> pr_err("tfm - i2c_client binding failed\n");
I'll need to rebase and resend this assuming [1] is applied first, as it
currently doesn't apply cleanly.
[1] https://lore.kernel.org/lkml/20260609100552.233494-3-thorsten.blum@linux.dev/
prev parent reply other threads:[~2026-06-13 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:52 [PATCH] crypto: atmel-ecc - drop unused curve id from atmel_ecdh_ctx Thorsten Blum
2026-06-13 14:23 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai1n_1FbXrLIRZUt@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.