From: Mike Rapoport <rppt@kernel.org>
To: Zhen Ni <zhen.ni@easystack.cn>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock: Remove redundant pageblock_align() in free_unused_memmap()
Date: Sun, 14 Jun 2026 12:20:39 +0300 [thread overview]
Message-ID: <ai5yZ2AQp3gI21xv@kernel.org> (raw)
In-Reply-To: <20260612031105.3350181-1-zhen.ni@easystack.cn>
On Fri, Jun 12, 2026 at 11:11:05AM +0800, Zhen Ni wrote:
> The assignment `prev_end = pageblock_align(end)` is redundant because
> `prev_end` was already aligned to pageblock oundaries inside the loop.
> Since pageblock_align() is a pure function, calling it again with the
> same input produces the same result.
>
> This line was added in commit f921f53e089a ("memblock: align freed
> memory map on pageblock boundaries with SPARSEMEM"). Remove it to
> simplify the code.
>
> Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
I queued it up for after -rc1.
> ---
> mm/memblock.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-06-14 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 3:11 [PATCH] mm/memblock: Remove redundant pageblock_align() in free_unused_memmap() Zhen Ni
2026-06-14 9:20 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai5yZ2AQp3gI21xv@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.