Re: [PATCH for-4.22 5/5] xen/numa: fix setup of non-aligned memory affinity ranges

["Roger Pau Monné" <roger.pau@citrix.com>]

On Wed, Jun 03, 2026 at 10:54:38AM +0200, Jan Beulich wrote:
> On 03.06.2026 10:53, Jan Beulich wrote:
> > On 01.06.2026 17:43, Roger Pau Monne wrote:
> >> --- a/xen/common/numa.c
> >> +++ b/xen/common/numa.c
> >> @@ -396,7 +396,13 @@ static int __init populate_memnodemap(const struct node *nodes,
> >>  
> >>      for ( i = 0; i < numnodes; i++ )
> >>      {
> >> -        unsigned long spdx = paddr_to_pdx(nodes[i].start);
> >> +        /*
> >> +         * Round down start address: if start is not aligned to the memnodemap
> >> +         * chunk size the tail remainder might not be added.  Overlaps created
> >> +         * by rounding will fall into the same NUMA region.
> >> +         */
> >> +        unsigned long spdx = ROUNDDOWN(paddr_to_pdx(nodes[i].start),
> >> +                                       1UL << shift);
> > 
> > Imo this rounding would better be done ...
> > 
> >>          unsigned long epdx = paddr_to_pdx(nodes[i].end - 1);
> >>  
> >>          if ( spdx > epdx )
> > 
> > ... only after this check (and then perhaps also after the subsequent if()).
> 
> Oh, and: With that adjustment
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Fair enough, I will adjust the rounding placement.

Thanks, Roger.