From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF3242B738 for ; Wed, 3 Jun 2026 22:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780527240; cv=none; b=t/EQrW7p4nlgvDluaBj2wogBFYgMOlpNK/nszPH2Jh0ezm00bb6CzH+1ut0NHcvc6U+oIlJSzEpFaJ36lUKezEUe7Iggurlw3SOvU4dR/Z3kso+diD95X0fRKsWARDGv5/M6Gb81DRSrkZYanw8mj6nRvy4Gke8pKztodd55/7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780527240; c=relaxed/simple; bh=V0RlIRH8OECQBaC5NYAdTI2vBRAWp0XwqUTCZut4kYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XlJ46UpUGLw/iQGuZgcwVQHX5cjwqMtVFOfPefj0w68arUZv2d7owk/jTXkbs3ec3YOvOBtxSlDD72hF37qU/1VJEgC0ti7YX8NbXFU7uneCHFwmwovG2BSMi7uAUhNuUvCmzeLEz+6jMF3goXzBauInP2FPFxlXrnmMO5+HKVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=DGOWj9jt; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="DGOWj9jt" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-486560db81cso42571b6e.0 for ; Wed, 03 Jun 2026 15:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1780527236; x=1781132036; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WCRL1M8f7KgT9oWEGazTM+11LlaS20N0f9r6dImRp7o=; b=DGOWj9jtjhWGrCXmxIOricsnqFFE166gj88qMf01JH1fM69MJ8Ifw3sJAgY/ODHEPL 1xxWII+DTnHHIaM8uNdO5iTcQZ8b4yq95bdHQzg66CtvSIyUz0L7ofFVk5+b8Bff+5ro olsaG51Bl6STQ3JOZOyvRpHbXfIuG8hgksk8IJGq6smph3nnblu6EhVal/KC/DxSTKj7 RGG3gJh9loFwn+bBhZan33yZTbyMWPWZ9nAhPvaLLVEX/uVnMYMfmJnkXWYJIQyH58yP Uy7UYoLz7i4im86OJnKjltuhzhMUdESTxdCqtZDVBk6UG73QE35SamutbJI8KG0hq/TR /U9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780527236; x=1781132036; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WCRL1M8f7KgT9oWEGazTM+11LlaS20N0f9r6dImRp7o=; b=r8T8WToCEJ/dJNNrHSNBnXiNFE0L9tJNDBBTPq8YHdb34W8R9RFDNSc/YVup9kko/F URKI2aosWHzIqCB9xubtcWhLOxZBmQRsFgAmuStwmYq3h5OjeKw0fGosPTeWZlIQpDBc 9G4L+jkJcfXq1w5qArvH5BRrUMkECdXG1trqKtp+SYBQ2bI9BVF3HWsDKyEwFFNgBwzt j8uYvy9HWLKQVF/i/kpSRnL9JtLIK/EU1k+V9qgoGnXOoIo9F+57iEiy3f1iyZnIv4vL QgvT128wIhUckYOp47B69wdlbFiEqFCS1uLmMC0b3EvEtvHlowaEBcWKi8WWdMvdoSeQ j6+w== X-Gm-Message-State: AOJu0Ywg+9bendlu52cyCTldrtKj7htCOJ8PlPfJDxiuZitMsTKJVfMS QWRQqA8IdpnPhpZWQ9G6xCEiWaR5ldXfQ1T35uyawqAD0xQR/97d80f0EqwEh4Pm9PM= X-Gm-Gg: Acq92OFoYuhiLyAqt11fpDDHthBK+COqHTk91BoWRcYMVfCknxj5ZfNB747bzSjcFFX 010DROLQWPTqsB+YztlJnyYhQXv9FGrHqTJw1085JTByO2xjVJrRYychT/6cZdIq18tTz9zP+RF kKBcQi27ADVXvFO3ucvu88HmhzlL864Qw/XyN6jZcoIm4QFmkWezbLWOr4TzAaPTUGWMvYAe+NK DF/uwGWYk+kwqMlkANwyLK/bCUupvrtsOQOfa4N5bS6j1pSjK9jDWteH9vy+1Ps8jc1+z1U5ooW VdrthA+DQ46PAPYD/AHmETAHnVg0RFW6rqAJpo+lRL2K/18OChLpsgAw5D9yBxcjJFbnZ90MMsA L7meSgBsygiuj+vVLeUseHC2vtAp4LMV80iNoAj1xI8pUIJVJ04P79OFYqKq3Hho2TiqSEJBS7x 1Iqz1EpD/d0z2yFREBCNxi3agrwQdFLxCYnKdrLC32/0PAI/mePduxNn0podQHnM92hEnbdbzYF wi0sruhK7wsuPiDO7aOiyauPg== X-Received: by 2002:a05:6808:4481:b0:486:39db:ebf7 with SMTP id 5614622812f47-4865ac2426fmr3535435b6e.44.1780527236261; Wed, 03 Jun 2026 15:53:56 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:144e:c181:b1d6:32f9]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4865b96e2dbsm2844586b6e.13.2026.06.03.15.53.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 15:53:54 -0700 (PDT) Date: Wed, 3 Jun 2026 17:53:50 -0500 From: Corey Minyard To: Rosen Penev Cc: linux-kernel@vger.kernel.org, "moderated list:IPMI SUBSYSTEM" Subject: Re: [PATCH] ipmi: si: Use platform_get_irq() to retrieve interrupt Message-ID: Reply-To: corey@minyard.net References: <20260603192511.6869-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603192511.6869-1-rosenp@gmail.com> On Wed, Jun 03, 2026 at 12:25:11PM -0700, Rosen Penev wrote: > Use platform_get_irq() to retrieve the interrupt resource instead of > directly parsing and mapping the OF node via irq_of_parse_and_map(). > This is the standard pattern for platform devices. > irq_of_parse_and_map() requires ire_dispose_mapping(), which is missing. > > Assisted-by: Antigravity:Gemini-3.5-Flash > Signed-off-by: Rosen Penev > --- > drivers/char/ipmi/ipmi_si_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c > index fb6e359ae494..e10b5d8af092 100644 > --- a/drivers/char/ipmi/ipmi_si_platform.c > +++ b/drivers/char/ipmi/ipmi_si_platform.c > @@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) > io.regspacing = regspacing ? be32_to_cpup(regspacing) : DEFAULT_REGSPACING; > io.regshift = regshift ? be32_to_cpup(regshift) : 0; > > - io.irq = irq_of_parse_and_map(pdev->dev.of_node, 0); > + io.irq = platform_get_irq(pdev, 0); This should be something like: io.irq = platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup = ipmi_std_irq_setup; else io.irq = 0; right? -corey > io.dev = &pdev->dev; > > dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n", > -- > 2.54.0 >