From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27318397AE5 for ; Wed, 3 Jun 2026 22:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780527435; cv=none; b=dq1NRnpLLXtEvfesKBlGw4waIxSZ9WIlNQsXgzXMRMh+N9gYu0pFfQPY8o1p44j3TBx7AvR8PMvBQj8Ml+543O5nxBBFtnHZZJN/O7N/yGimmfWqtRNGJ/l/0vjWKNKFIqIYQnNuEMmp5mw+sDnfuu5rbfMH7rRFWqvKj39V/0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780527435; c=relaxed/simple; bh=H1XwuxoZ++HQQRYUNfTQnrFPOoZa4jfm4xPe1RtqQWc=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aq5ZFjMsfStycCkcrq9EM/nUTIER85nPour3t01ws5sSs4kw3rULrHUHLWika0V/9Qcxzxeg+RqJmwg8HnWsOLZD3togj7uffFCthk/CAqD7HFOvZUcSzDniIJap/b7EsJhBx+7X/yX8Sp+4dBUE/WgdpyI3E18h5tmk5/B/3wc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=MVmTrQjT; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="MVmTrQjT" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-43d16405b54so51068fac.3 for ; Wed, 03 Jun 2026 15:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1780527433; x=1781132233; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=wvFjNISO/d9CrbxS5lupYvAlGYUYzF33rNDwaHayfK4=; b=MVmTrQjT/o3oBaaqKISfYKS1LiBUDI5asiAB71g8Xb99hqHoc3sD4bC6UM1HuVb1Jm md6Cf162aunIA5dLmWmjVsSsiXd9XtYeZqMiwu4fHDeBGQrXBHXfbMqzv/6wJlId29hp vSiA4GaGWvLXFuA+UDuApQM/qNiMGQSam+ARFdOJjnKRe1Yu7KVG4babUX6CCgCstVnj u7cZxpNYoqaqVOrwjAqjtg0Oxj2avAFqpX/gJpEzP5TA47XccWw1jrHwIFaWfkDFDSD8 6ic1NWoJsq31OW8bhStBLYZmb7gAUbKC9zA4zMwLGx1pqmtcEG2yL0/fCA0gNYrTAR/9 lipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780527433; x=1781132233; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:to:from:date:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wvFjNISO/d9CrbxS5lupYvAlGYUYzF33rNDwaHayfK4=; b=lV8WyxM/4QeccJyLl8h1yHM3mdyLPpb8GK+/iR0sBHJ5HTWc4GzdAJtZ8LJT3vCaCw +FRq7HCdeLRExW6dsC84hjMaUsiFEo0p23frjbSvm5XlwMPb68JsBgZ4FVgBVdMKFxJr 5BErUIFj8XTpnVOKCiRnDuDo7QIIlklOC8kQbgzWk6uf8cdMcL+PFTuM1CEL3gjSZYJ4 rAnHIjQEfBFWsi3U5+0y2WyWPqi3VS0twYhfbaWNM7IR5IlQNLRaeosmqExRiu4YxH6h IkORG8/4uIEuAEfvvbx3HeMpsoe5TPUWBzotnfxd7qFumv4EsvihH8jhdtkwyz4txSbX hnZQ== X-Forwarded-Encrypted: i=1; AFNElJ9HJy6E2ucc7dy10KklDGJ09LZkPSmCiLjzRKObSkuMCGXxwT7TtIf6+P+7h/xebPAXEyppSRxmJtrjoCY=@vger.kernel.org X-Gm-Message-State: AOJu0YyTiAlsqp/Fpm9o1K44FnF6QpqsniLOZDgVG+oxeLka2MqeLKUa 8KrlVm8LBEdpkNPLvazKqNrPl3kVt9FMF66MiZV+5LGvZFkIOvtlxMPNEYojhHVLbg4= X-Gm-Gg: Acq92OGnnK7rgdqcJZCDIRilnRhBTnlr41n686HtuNvl4SZ/SW8iot4rK9LBam9jUqX mHb97HTy/UGGJdad2m8MNd+Axmo2E58BBNiP0Y5Hw5RmuaLN2z2hG3hFMLMsVDjT9C+20txDbHz J+XbRf8Jl6sUk6n5wVaErNYLHTz7o/x3WChg2RsDEtz71HDU5V9XGsHaBC9FGUFgMFXfjlTQ/P8 cAgdh5UNG+PCur0l0F9djjw4wSYZZDac7iQniO9hCqBpIZCe7JzfpOmIXNJ9FvshucFOj7Fzot9 bYDPAQwRIMpNZOfjGjPRPVEJtJgtSgYUC0+kupFS5ZWXAzNoVTrH1BWgnPnFGnJPOzWo3Stwz1E zunhqmyfh3q6SFPzCWitwDJDp6w3M1s3NddBszmyZwy/iIfRbMGXAuRhyAikpH9Eqtk3Qebd54p 79GgkG2r+AkGrmhimTe32VsJaOicJl9tzNRvA61wUjlYjtfbbjG6xV73wH2olLDt/1q9A5W+SXU GVXgpoKrrD4vVw1d7DK9CTjSg== X-Received: by 2002:a05:6870:889c:b0:43b:7078:af9a with SMTP id 586e51a60fabf-440db5dd0femr3530793fac.15.1780527433122; Wed, 03 Jun 2026 15:57:13 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:144e:c181:b1d6:32f9]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-440d8295b38sm3768373fac.10.2026.06.03.15.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 15:57:12 -0700 (PDT) Date: Wed, 3 Jun 2026 17:57:08 -0500 From: Corey Minyard To: Rosen Penev , linux-kernel@vger.kernel.org, "moderated list:IPMI SUBSYSTEM" Subject: Re: [PATCH] ipmi: si: Use platform_get_irq() to retrieve interrupt Message-ID: Reply-To: corey@minyard.net References: <20260603192511.6869-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 03, 2026 at 05:53:56PM -0500, Corey Minyard wrote: > On Wed, Jun 03, 2026 at 12:25:11PM -0700, Rosen Penev wrote: > > Use platform_get_irq() to retrieve the interrupt resource instead of > > directly parsing and mapping the OF node via irq_of_parse_and_map(). > > This is the standard pattern for platform devices. > > irq_of_parse_and_map() requires ire_dispose_mapping(), which is missing. > > > > Assisted-by: Antigravity:Gemini-3.5-Flash > > Signed-off-by: Rosen Penev > > --- > > drivers/char/ipmi/ipmi_si_platform.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c > > index fb6e359ae494..e10b5d8af092 100644 > > --- a/drivers/char/ipmi/ipmi_si_platform.c > > +++ b/drivers/char/ipmi/ipmi_si_platform.c > > @@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) > > io.regspacing = regspacing ? be32_to_cpup(regspacing) : DEFAULT_REGSPACING; > > io.regshift = regshift ? be32_to_cpup(regshift) : 0; > > > > - io.irq = irq_of_parse_and_map(pdev->dev.of_node, 0); > > + io.irq = platform_get_irq(pdev, 0); > > This should be something like: > > io.irq = platform_get_irq_optional(pdev, 0); > if (io.irq > 0) > io.irq_setup = ipmi_std_irq_setup; > else > io.irq = 0; > > right? Oops, cut and paste error, try: io.irq = platform_get_irq_optional(pdev, 0); if (io.irq < 0) io.irq = 0; This just disables the interrupt if it can't get it. > > -corey > > > io.dev = &pdev->dev; > > > > dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n", > > -- > > 2.54.0 > >