From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Johan Hovold <johan@kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3 07/10] i2c: core: fix adapter registration race
Date: Thu, 4 Jun 2026 10:50:16 +0200 [thread overview]
Message-ID: <aiE8SONCyzX4LW4M@ninjato> (raw)
In-Reply-To: <20260511143715.729714-8-johan@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Mon, May 11, 2026 at 04:37:12PM +0200, Johan Hovold wrote:
> Adapters can be looked up based on their id using i2c_get_adapter()
> which takes a reference to the embedded struct device.
>
> Make sure that the adapter (including its struct device) has been
> initialised before adding it to the IDR to avoid accessing uninitialised
> data which could, for example, lead to NULL-pointer dereferences or
> use-after-free.
>
> Note that the i2c-dev chardev, which is registered from a bus notifier,
> currently uses i2c_get_adapter() so the adapter needs to be added to the
> IDR before registration.
>
> Fixes: 6e13e6418418 ("i2c: Add i2c_add_numbered_adapter()")
> Cc: stable@vger.kernel.org # 2.6.22
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-06-04 8:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 14:37 [PATCH v3 00/10] i2c: core: adapter registration fixes Johan Hovold
2026-05-11 14:37 ` [PATCH v3 01/10] i2c: core: fix irq domain leak on adapter registration failure Johan Hovold
2026-06-03 9:16 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 02/10] i2c: core: fix hang " Johan Hovold
2026-06-03 9:19 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 03/10] i2c: core: fix NULL-deref " Johan Hovold
2026-06-03 9:27 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 04/10] i2c: core: fix adapter probe deferral loop Johan Hovold
2026-06-03 9:32 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 05/10] i2c: core: fix adapter debugfs creation Johan Hovold
2026-06-03 13:14 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 06/10] i2c: core: disable runtime PM on adapter registration failure Johan Hovold
2026-06-03 13:19 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 07/10] i2c: core: fix adapter registration race Johan Hovold
2026-06-04 8:50 ` Wolfram Sang [this message]
2026-05-11 14:37 ` [PATCH v3 08/10] i2c: core: fix adapter deregistration race Johan Hovold
2026-06-04 8:50 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 09/10] i2c: core: clean up bus id allocation Johan Hovold
2026-06-04 9:55 ` Wolfram Sang
2026-05-11 14:37 ` [PATCH v3 10/10] i2c: core: clean up adapter registration error label Johan Hovold
2026-06-04 9:55 ` Wolfram Sang
2026-05-11 16:35 ` [PATCH v3 00/10] i2c: core: adapter registration fixes Wolfram Sang
2026-05-11 17:49 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiE8SONCyzX4LW4M@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=johan@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.