From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <li.wang@linux.dev>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 1/2] lib: Introduce tst_path_defs.h to consolidate system paths
Date: Thu, 4 Jun 2026 11:50:34 +0200 [thread overview]
Message-ID: <aiFKatipB8ypAsdf@yuki.lan> (raw)
In-Reply-To: <20260604094200.21643-1-li.wang@linux.dev>
Hi!
> +/* NETWORK */
> +#define PATH_NET_IPV4 "/proc/sys/net/ipv4/"
> +#define PATH_NET_IPV4_ICMP_RATELIMIT "/proc/sys/net/ipv4/icmp_ratelimit"
> +#define PATH_NET_IPV4_ICMP_RATEMASK "/proc/sys/net/ipv4/icmp_ratemask"
> +#define PATH_NET_IPV4_ICMP_ECHO_IGNORE_ALL "/proc/sys/net/ipv4/icmp_echo_ignore_all"
> +#define PATH_NET_IPV4_ICMP_MSGS_BURST "/proc/sys/net/ipv4/icmp_msgs_burst"
> +#define PATH_NET_IPV4_TCP_PROBE_INTERVAL "/proc/sys/net/ipv4/tcp_probe_interval"
> +#define PATH_NET_IPV4_TCP_KEEPALIVE_TIME "/proc/sys/net/ipv4/tcp_keepalive_time"
> +#define PATH_NET_IPV4_TCP_NOTSENT_LOWAT "/proc/sys/net/ipv4/tcp_notsent_lowat"
> +#define PATH_NET_IPV4_IP_LOCAL_RESERVED_PORTS "/proc/sys/net/ipv4/ip_local_reserved_ports"
Maybe we can drop the NET here as well, the IPV4 is descriptive enough.
e.g. PATH_IPV4_ICMP_RATELIMIT
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-04 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 9:41 [LTP] [PATCH v5 1/2] lib: Introduce tst_path_defs.h to consolidate system paths Li Wang
2026-06-04 9:42 ` [LTP] [PATCH v5 2/2] metaparse: Explicitly parse essential headers for macros Li Wang
2026-06-04 9:47 ` Cyril Hrubis
2026-06-04 9:50 ` Cyril Hrubis [this message]
2026-06-04 9:57 ` [LTP] [PATCH v5 1/2] lib: Introduce tst_path_defs.h to consolidate system paths Li Wang
2026-06-05 5:18 ` Li Wang
2026-06-04 9:52 ` Li Wang
2026-06-04 11:37 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiFKatipB8ypAsdf@yuki.lan \
--to=chrubis@suse.cz \
--cc=li.wang@linux.dev \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.