From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B44D40B6CF for ; Thu, 4 Jun 2026 11:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571864; cv=none; b=rEQ66qiYeUGZnSOdSRUrS7s9XnymhxY0G2YWHYST49NR6mD8uw/ACzyVSdDY7SRiXKfUWeGfnmf+y5zhsfpsfZZxLvb3HXOYGV1nieUBfDbkU80upDq+jBS1NNIuq3fpwz7rod3+1anBW1YyW9gX5wVhFcRR7+OKi/vBe+OahQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571864; c=relaxed/simple; bh=RXDUQowYZh9h3j6qG/zfu8NnZV/DxLiYcI7PD6e6SN0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZtgX9K31RhVZTttKBHW80fk3jcn6U7Wj5F28lAc161koUTeqsQkl34bV+4EbyrgsUi2Q43kzIu1OMoUG3yNWF8biUPFdYMzoE/bhZgP2/4GfHeFJp8JaFiOg2T8cYo7HkJkp59cPQQNd56go3IAJCND1dDGlEtRN97iJ57INQ4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BFrvfGuN; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BFrvfGuN" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-490a767b782so4920995e9.2 for ; Thu, 04 Jun 2026 04:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780571862; x=1781176662; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vMPINAxbwMQr+CA+jaOG7PHibBNPmddYJIp5CCiKSfg=; b=BFrvfGuN9oSDubYLaDAS12jTS2M9OlRJFlUWVTwP6kmkTbVQa2dp/a8oxL4WYPzQRy bkxb3TVNVb8zWvUQVHOO7g46rXwpQCbzxoqgWm2WixoOeY9B7cRdvnZPRcehGmDZuAj8 mJH1C6OIEyN6q/l+ds7kJaKhp7iTaG5kwhrSm31hED1jTHEv4IhJSRWYJEV/I1mNsFdJ 9cKklyICIuWnj5fAfA8I2CKYwEu6YJraNEMv8491k7Hm99R/WsXYK60yo7mjoYk3wWzq xzcvpe8ywrG1BwVL4O1rgspzZXieoViS3Nf5Wd6OOn9/7R8aOHUnmr7sYpSBcJbdwA7X xuvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780571862; x=1781176662; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vMPINAxbwMQr+CA+jaOG7PHibBNPmddYJIp5CCiKSfg=; b=lZ7S4vnT/MVTmz/V2niO8TZWnOXvf80F1ZvzA8sX6ctpdOdjja8TsmF8jOF2UpGm/L fNL/GEcm6dsp8ZybNb7KXdhK4DNYzazSNRrijLkHuJvWwy3poTfXw7699hORBsWD7JjY QEm4ub7p/z5SQHDfZjlMKbjV7KVzd9XFFaBesxLVQnhLJ9u6NevA/3UvbT42DwMRo3HC nKWjYs8hI93hYkslW4gFG4FBUOSa6STYMMZMPAjglPVrHvS4giZ92U0KMu7tmnQaOD49 ZqRXAVwzfUU1/DvmR6u+vi8CNy9t/J3L2aGc3O/A7Powf9Z0BmjQiHkghTmHgE36HrpL rU+A== X-Forwarded-Encrypted: i=1; AFNElJ9ZuYBbRHd8nfGxm2fxaBjYvk9wqzpQrKvztl8T7FReVnRA/UwLD2kGGTUUvLTvVrDP3lAnpCO6M9k=@vger.kernel.org X-Gm-Message-State: AOJu0YwX09amwBE9+i9BzmvAHDo3jDL9UM0Mbtkwt12oKMeaE4oOpmsZ QKc1HcsUb7y041mHIdYyzWL8yV0i8iK/lSjnRSUPKYR23FEKe6fRTxtVYJHfbNzzPD7nnhAl46f CUEYaACrBANVxhPgr+Q== X-Received: from wmbz1.prod.google.com ([2002:a05:600c:c081:b0:490:af44:67a5]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a016:b0:490:bc46:1a58 with SMTP id 5b1f17b1804b1-490bc461b57mr60168765e9.18.1780571861570; Thu, 04 Jun 2026 04:17:41 -0700 (PDT) Date: Thu, 4 Jun 2026 11:17:40 +0000 In-Reply-To: <20260526-rate-exclusive-get-th1520-v1-2-34cf034e1764@mailbox.org> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260526-rate-exclusive-get-th1520-v1-0-34cf034e1764@mailbox.org> <20260526-rate-exclusive-get-th1520-v1-2-34cf034e1764@mailbox.org> Message-ID: Subject: Re: [PATCH 2/2] pwm: th1520: Lock clock rate with clk_rate_exclusive_get From: Alice Ryhl To: mhi@mailbox.org Cc: Michael Turquette , Stephen Boyd , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Drew Fustini , Guo Ren , Fu Wei , Michal Wilczynski , "Uwe =?utf-8?Q?Kleine-K=C3=B6nig?=" , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Tue, May 26, 2026 at 07:04:58PM +0200, Maurice Hieronymus via B4 Relay wrote: > From: Maurice Hieronymus > > The driver derives period and duty cycle from the clock rate read at > probe, so a later rate change would silently miscompute waveforms. > Switch to the new ExclusiveClk wrapper to hold the rate for the lifetime > of the driver data and drop the corresponding TODO. > > Signed-off-by: Maurice Hieronymus Reviewed-by: Alice Ryhl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61A75CD6E57 for ; Thu, 4 Jun 2026 11:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=VIz6WKhb5zi5OeRWPaPlu4yIgd9+3ioNuWbuuPSBd38=; b=B2G5/77w2BcChP/Amj97jraJ6Z 4Sm87IGcIX5UB1tCdXvfCXvPg83o/Wu+nIrv6QWC+rkF6PZqLkvtFGuMu/8aBSS+MKlmt+3D/7E7e N5V+vo2M6TiEBCpQMmWqz05A2P5Xqq03RylbL709qT+AL7VSSGOJRmbNhJDAxTdMv2ggAk652hlKt KAXZI/Bt3KnyrHO18+VUCs+nI1RdhCU9VK5ff1ZkVFZ/ua9XltfPKuDuuDVsNjVxsFrNMkfQuBsdx 7qI5ZqDRbZhLdoNXQwPoHpU9BELYmLQqWdNAiwBGEzx4k9J0aCS6HULZnIfQRqr3uvikh02kg16Kw S2n1V4nQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wV655-0000000Gcs3-0SVn; Thu, 04 Jun 2026 11:17:47 +0000 Received: from mail-wr1-x449.google.com ([2a00:1450:4864:20::449]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wV652-0000000GcrT-1Jnt for linux-riscv@lists.infradead.org; Thu, 04 Jun 2026 11:17:45 +0000 Received: by mail-wr1-x449.google.com with SMTP id ffacd0b85a97d-45ef3aeeb41so421312f8f.1 for ; Thu, 04 Jun 2026 04:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780571862; x=1781176662; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vMPINAxbwMQr+CA+jaOG7PHibBNPmddYJIp5CCiKSfg=; b=QUNyb4QFr8uE3rsyyLOGN0kcmGdXi8128/D5sZw/nPSm9/vOYls8XbaBvtpgT6M+kX 5sW4xovLCd84Cjt73ydjR4gh7kTxzv7pzZc08TTbbBVRQ5ITecaQOy8hm15Kkp3MXiZZ iCI5ma568szdAU+QZCa+AjynzTYuwh2Kfp+nhC5xN+2WqV6gMaqvInd4jcCBVSd/iMxt HIn84Aoq3+ZDYea5GOJBHM+wO3KDhvbD4Fe5Cg8JROjB+5EXuTT8nnOhtd/XEF7UlvcU ngmMryeuHJm8RRNG0/4tFCywUjHJ5WIsDdMpBVeDgapdGFc9BYRH3gnw8hz5zKZDkoy5 N1rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780571862; x=1781176662; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vMPINAxbwMQr+CA+jaOG7PHibBNPmddYJIp5CCiKSfg=; b=sjd6CAQXGpKmvnGaAC3OY2Yq1fqSowaMVqMXlyoc9yRSMAFSOmo58rfSrCTCCCwuXw BNkgmSgkLErBE5vDLjzhMeEAEWbGcbGjG/fjpVV0OGGpM7rcFdHZlWYu05LGs35VDBnB IM1AuGT4imy6cKCSQ3rbh08YmUdTc6RoZpw+AGcQWy6qEGpMaz4spLTXTEmaMoJT3p8v xSSZxs+JBIOpNg/4x6rGnVXYbQ67JYiBfKFeRu5U1ayWh8eMmRrkzNalR48eykB24dFL HLHb5JVgwiIRy2FdLFARhvdtIZ8M8JoeSP6iRgHoo7zN3stbhLBBHIp1W6nG+Z/TRCa2 uEoA== X-Forwarded-Encrypted: i=1; AFNElJ+uadELDdEa0tjrOD5LbYjJPrj35J6i75zL8HiKldE9je30Nz5e390gM55vZ+hKvN+9k4MEzY095GMr4Q==@lists.infradead.org X-Gm-Message-State: AOJu0YwPqLo7qGn3QmPnUWp98puookF8IbUawOf1TfKt5c+RZ79AHRrx Fi5yEQ6hil0CVNPtnBT6KU4fDP9cP0/61lXYVTkYUlFakO1t51wLl5qe9SL1U2YDwyfK8pKvn9O 1wQFK5xFFkQFAH+Tsig== X-Received: from wmbz1.prod.google.com ([2002:a05:600c:c081:b0:490:af44:67a5]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a016:b0:490:bc46:1a58 with SMTP id 5b1f17b1804b1-490bc461b57mr60168765e9.18.1780571861570; Thu, 04 Jun 2026 04:17:41 -0700 (PDT) Date: Thu, 4 Jun 2026 11:17:40 +0000 In-Reply-To: <20260526-rate-exclusive-get-th1520-v1-2-34cf034e1764@mailbox.org> Mime-Version: 1.0 References: <20260526-rate-exclusive-get-th1520-v1-0-34cf034e1764@mailbox.org> <20260526-rate-exclusive-get-th1520-v1-2-34cf034e1764@mailbox.org> Message-ID: Subject: Re: [PATCH 2/2] pwm: th1520: Lock clock rate with clk_rate_exclusive_get From: Alice Ryhl To: mhi@mailbox.org Cc: Michael Turquette , Stephen Boyd , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Drew Fustini , Guo Ren , Fu Wei , Michal Wilczynski , "Uwe =?utf-8?Q?Kleine-K=C3=B6nig?=" , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260604_041744_355459_CE23D6FC X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, May 26, 2026 at 07:04:58PM +0200, Maurice Hieronymus via B4 Relay wrote: > From: Maurice Hieronymus > > The driver derives period and duty cycle from the clock rate read at > probe, so a later rate change would silently miscompute waveforms. > Switch to the new ExclusiveClk wrapper to hold the rate for the lifetime > of the driver data and drop the corresponding TODO. > > Signed-off-by: Maurice Hieronymus Reviewed-by: Alice Ryhl _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv