From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB56C311C38 for ; Thu, 4 Jun 2026 11:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571835; cv=none; b=TH87IQo5AmoT3/scYlNJKd7hwkIO8VC1OXhcj5KWvUKH/6i9JPYfBUW5XJwgQe4vDzIAxfKhmouIJSSVqVuqgGyxJcLijyXK8UwIcvLqXZUXkZO0nd338N5kEO2VbRmqZPeIYEeaGofpKhivS09XkRHV5kVl+i8TWq8tCgBMmC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571835; c=relaxed/simple; bh=A9r6sdi7fuEvQAl7qMQwwBhCNW97IWECBrekrpHUCkg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uOuSs4kd6WRPNvl2CIvbxVZcooHYAooGF8VUEGyx6lMwHEMbenMItKyFq9GU1I3HwDGntBDG6+dM9wHv8vkDQPN9mQNB8fsA/W121TNVTlMDV36HzkjcAiCDf9YsSpoYLYtoMow2ql+F2VA2DfjtRY67g9lWwqR7rGbNEENINfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=e+sTp28d; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="e+sTp28d" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-48611ccd5aeso296093b6e.2 for ; Thu, 04 Jun 2026 04:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1780571833; x=1781176633; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=6KPg/SEgmYFArpw8Vetv95NBJDkKqeptMKU5Z6y9va4=; b=e+sTp28dW7jMp+YAwh7YfJAuFuiwbt8Fi8UBwoKXBmh018A1lsyv96RyhDNaZ2mSzV 6LlLHrSRCF9VuGrTPI4g2pVGVwH57SU0JLnJGPztJy6e5uF5w562mmolZDrFheDVXFt9 TboD4RpFwFmqbFcdJnTfeoNzXRwyd63Z1mc66/68dml3oMvT+ZfJlOdwfdsn/cGdSZlR pF4WY50VmGTZOKp/ktm9UVnpKAFtkWXB91PLoEC6l8T4StVMLcVyGQyJ/MzowKz+wBrE amx5C8juSxMWhZJs1aFe/zJSK7D4FcCvQAIWNnsKe6H/Ny6xeULk/Yvogqrfi+3rKQPd s33g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780571833; x=1781176633; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6KPg/SEgmYFArpw8Vetv95NBJDkKqeptMKU5Z6y9va4=; b=bNT7cyJRSjdcfhJ5sZ6DTxDlmnn7fWIQ8jWVaJUyD8cJL/szRgZqMwvOPsIfDMPGZ+ 25PgplqnykdptZpT0qdsgKeVm9Tpw4F3pDGu37UCBzWCcCBsfIFtJUGglBasB0mpcaHb X3TnCdnI7hyytLxzO69dKiBPRm73jwEkIEOci+a3kl0fk3YP8S3pSDOaLYXcjyQ8Kxai jUbXTsH3v7sW9DJYgzBZ3Kap9y1sbXzLRgBbXhDe7ljNaVAi70j5fJTgs8oaQrLCK7Ga Dy0u3uQlXj5r26z0A4nr+VJzllkwcHy2kPSbhPUq0pV3z93iMej466xzCkPSSGq9h/+8 Desw== X-Gm-Message-State: AOJu0YytJcjjqO7gDHoQLHaUiF3hxMxq4KmCLZMU1wG4T/zHnCPPWCq4 4h2SkHXYsLVp7IGJGFL3QZolaWxD4rdi3Yqf0wBDkLbnF4S3uLOOX8uZjm8BoePCqApYxmH45jB 4Y9N6 X-Gm-Gg: Acq92OH7LXZHhFrCuEG70goi3igc3cRonnZyU/R6MEczwLUvCm2Lhl2Jh3BW6hq6Cos DpslbtDXOt2eRHN7i58emuvtikxwaGPgiHI9z4CyD47rduQTDncuotF1x3EU5q9TlAlEdb30PMn XSiIJ3Ct9f2te9RUpBHPQJTNuzXp1V6A34TkAXcMox8HdypgsEZFCP6Ry66ukmOGJGB379NLZGG tlE2eeGdmnGcBR/AgPDj/JSweYF4xus5TcokWIGOnggWgYUUdNu19AmMV+5iWfSFc7IHv9CpVaC Kidvyb7lGEVnYXpo3jFsYsYALexCb0GueJ4oywYfC/O4ODjcCTSI64rnX2zVWKHCK2Wb/Vtwq4e /9vhKPIbYMvFiCwYD5QLjgPlzNqIJkK36+i36MNIZou9B+pkEhnf0snEFRxJ9CZmZuwQyNgtFIf f/i2POFsqkt0HJ1SlxF/nfgYG2ruKWohySwp88CN5eAprPmS8slmvXPw2JQwrPh5PUtGEWJ9XGd 94KMjrzRCG99pk2jFPcIyL/iQ== X-Received: by 2002:a05:6808:13c7:b0:482:52f6:b688 with SMTP id 5614622812f47-4865ac087ecmr5135491b6e.45.1780571832777; Thu, 04 Jun 2026 04:17:12 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:144e:c181:b1d6:32f9]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4865b5a5b5fsm4328725b6e.2.2026.06.04.04.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 04:17:11 -0700 (PDT) Date: Thu, 4 Jun 2026 06:17:06 -0500 From: Corey Minyard To: Rosen Penev Cc: linux-kernel@vger.kernel.org, "moderated list:IPMI SUBSYSTEM" Subject: Re: [PATCH] ipmi: si: Use platform_get_irq() to retrieve interrupt Message-ID: Reply-To: corey@minyard.net References: <20260603192511.6869-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jun 03, 2026 at 04:18:57PM -0700, Rosen Penev wrote: > On Wed, Jun 3, 2026 at 4:17 PM Corey Minyard wrote: > > > > On Wed, Jun 03, 2026 at 04:05:54PM -0700, Rosen Penev wrote: > > > On Wed, Jun 3, 2026 at 3:57 PM Corey Minyard wrote: > > > > > > > > On Wed, Jun 03, 2026 at 05:53:56PM -0500, Corey Minyard wrote: > > > > > On Wed, Jun 03, 2026 at 12:25:11PM -0700, Rosen Penev wrote: > > > > > > Use platform_get_irq() to retrieve the interrupt resource instead of > > > > > > directly parsing and mapping the OF node via irq_of_parse_and_map(). > > > > > > This is the standard pattern for platform devices. > > > > > > irq_of_parse_and_map() requires ire_dispose_mapping(), which is missing. > > > > > > > > > > > > Assisted-by: Antigravity:Gemini-3.5-Flash > > > > > > Signed-off-by: Rosen Penev > > > > > > --- > > > > > > drivers/char/ipmi/ipmi_si_platform.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c > > > > > > index fb6e359ae494..e10b5d8af092 100644 > > > > > > --- a/drivers/char/ipmi/ipmi_si_platform.c > > > > > > +++ b/drivers/char/ipmi/ipmi_si_platform.c > > > > > > @@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) > > > > > > io.regspacing = regspacing ? be32_to_cpup(regspacing) : DEFAULT_REGSPACING; > > > > > > io.regshift = regshift ? be32_to_cpup(regshift) : 0; > > > > > > > > > > > > - io.irq = irq_of_parse_and_map(pdev->dev.of_node, 0); > > > > > > + io.irq = platform_get_irq(pdev, 0); > > > > > > > > > > This should be something like: > > > > > > > > > > io.irq = platform_get_irq_optional(pdev, 0); > > > > > if (io.irq > 0) > > > > > io.irq_setup = ipmi_std_irq_setup; > > > > > else > > > > > io.irq = 0; > > > > > > > > > > right? > > > > > > > > Oops, cut and paste error, try: > > > > > > > > io.irq = platform_get_irq_optional(pdev, 0); > > > > if (io.irq < 0) > > > > io.irq = 0; > > > I don't think that if is appropriate. > > > > Can platform_get_irq[_optional]() return < 0? The driver still has to > > work even if there is no interrupt specified. > It can return -EPROBE_DEFER. > > No idea how likely in this driver. Well, I have to handle a negative return value here, the comments above platform_get_irq_optional() say so. The value is optional. So it has to be the above. I'll modify the patch to be what I posted above. > > > > -corey > > > > > > > > > > This just disables the interrupt if it can't get it. > > > > > > > > > > > > > > -corey > > > > > > > > > > > io.dev = &pdev->dev; > > > > > > > > > > > > dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n", > > > > > > -- > > > > > > 2.54.0 > > > > > >