From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D9FCD6E6D for ; Thu, 4 Jun 2026 14:17:40 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gWRV95M9mz2y1Y; Fri, 05 Jun 2026 00:17:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780582657; cv=none; b=gsddXjYXYAePSrgv32DCNB9alv8oN/7UIv4tPr/+x646pg+VWhpDDB5q98RoB4WyOhgxacDPoiijEMcORVG9vhYzK6Bo1GDY7QvwUg7MdPJ3L0ExW7EGeWqlN3CV/vy63ROWrbJlbXfFbOk5wZFgGzwRCbr0ZcZDkw1s+pEBikt+ey19IK2+vH2moP9N1UF5ZPewotess0iXLxSmFSTaQNmXPZxeeQvEZN/JOzD4JHPvxaTUdS84KwJrUOc/2rcBSL27idI+jKFkCfg8nwEf+Q72g+FH6wA3MEzQ1v0jNKaPNhNizgEUjHoxGRlnkJ1NpbR9Q0flwrdpQ+pqLmq4UA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780582657; c=relaxed/relaxed; bh=a23fVnlClqzkGnu4H8lLPL7TNuMOc0N3Wpy71vcyZKw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UHYKkSHBXWXBKul+OH0RQfmv6Ys0c6V/reUCTIo0amT4jRrmvTF3hgpSpZFb19WocvysakFtnA3TWLg+UqPvt2yY9HfD/BHwBljftapCHlbBTA4r8aIZdKzu0vfIbZ0jPQftEvMgZkDMMFa3VbiYcnJwHr5KXNB11rjuRVALmU31Kl+y8cxPQeITwUwYFy3ijI25jyKKc/kYSZpjJwGy3oG1mOZegmwOLP3UByKW32weY8Us9Mu0ftyj7aHqz75qbD0KNwLXn11i+PhpzcN1pwCkTW0xNHhsmfQUFXBlmPfZsfdkg/5BcZCGcASr7kSX4rCkCWnZ+JFVwZ7kFqvTZw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=kCULlyQj; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=acme@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=kCULlyQj; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=acme@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gWRV85j86z2xfB for ; Fri, 05 Jun 2026 00:17:36 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 51B5043D2C; Thu, 4 Jun 2026 14:17:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 924BC1F00893; Thu, 4 Jun 2026 14:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780582654; bh=a23fVnlClqzkGnu4H8lLPL7TNuMOc0N3Wpy71vcyZKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kCULlyQjFdpPWXG4ewMFzM0hHvfv3BE1jLMR+bCTDg8JrJS+unPBUzsVKE6FSqOLF HZW2H2Oxf9EvlUYAZkYnt7EVCN5/8MkRifh6WM0E1Rh3+k00kkZ5mLjO9O2B8rrz+m Xcs/a+EtIo2uHAgpwj+VowrzeTXQx0/qRkePtmVjkI7+pQmH+MKtg+H0/e9mBdkEQS YdjSrfyPrGRUGjIqGGMy3Sa/klvQOxGe74olONPff4xIk/6njjgbdbhn6SrNCM+oaO /fc3AeVL+stfr/0m2PdoLuR1OJf2edRFSZvEPuYXLh5yBQE0YtYhpmbrEvJSI5YfrH 1tf577RlKgbVQ== Date: Thu, 4 Jun 2026 11:17:31 -0300 From: Arnaldo Carvalho de Melo To: Athira Rajeev , Anubhav Shelat Cc: Namhyung Kim , Ian Rogers , jolsa@kernel.org, adrian.hunter@intel.com, mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com, linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, hbathini@linux.vnet.ibm.com, Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, Shivani.Nittor@ibm.com Subject: Re: [PATCH] tools/perf/sched: Update process names of processes in zombie state for both -s and -S options Message-ID: References: <20260426093930.47809-1-atrajeev@linux.ibm.com> <230801A2-5F9C-42A6-9390-B44786309E30@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, May 21, 2026 at 11:17:58AM -0300, Arnaldo Carvalho de Melo wrote: > On Thu, May 21, 2026 at 02:02:53PM +0530, Athira Rajeev wrote: > > > On 27 Apr 2026, at 11:26 AM, Namhyung Kim wrote: > > > On Sun, Apr 26, 2026 at 03:09:30PM +0530, Athira Rajeev wrote: > > >> In redhat perftool testsuite, observed fail for this test: > > >> -- [ FAIL ] -- perf_sched :: test_timehist :: --with-summary (output regexp parsing) > > >> > > >> This led to analysis of "perf sched timehist" summary options. > > >> > > >> # perf sched record -a -o ./perf.data -- sleep 0.1 > > >> This will record using perf sched record > > >> > > >> perf sched timeliest has two options "-s" and "-S" > > >> # perf sched -i ./perf.data timehist -S > > >> -S : Captures summary also at the end > > >> > > >> # perf sched -i ./perf.data timehist -s > > >> -s : Captures only summary > > >> > > >> The test saves -s result which has only summary and compares with > > >> summary which comes at the end from -S . Since there is a difference > > >> in these two, test fails. > > >> > > >> Checking the behaviour change in -S and -s results, difference is: > > >> > > >> rcu_sched[16] 2 4 0.013 0.001 0.003 0.006 33.23 0 > > >> migration/11[73] 2 1 0.006 0.006 0.006 0.006 0.00 0 > > >> migration/3[33] 2 1 0.006 0.006 0.006 0.006 0.00 0 > > >> - :216753[216753] -1 1 0.041 0.041 0.041 0.041 0.00 0 > > >> + sleep[216753] -1 1 0.041 0.041 0.041 0.041 0.00 0 > > >> migration/8[58] 2 1 0.005 0.005 0.005 0.005 0.00 0 > > >> NetworkManager[811] 1 2 0.089 0.028 0.044 0.060 36.06 0 > > >> migration/13[83] 2 1 0.005 0.005 0.005 0.005 0.00 0 > > >> > > >> Here 216753 is pid for sleep which is a zombie process. This is > > >> happening in latest kernel due to an update in "-S" result. > > >> In -S, the process name appears in the results "sleep[216753]", > > >> where as in the -s, only pid is present in the summary result > > >> ":216753[216753]". > > >> > > >> After commit 39f473f6d0b2 ("perf sched timehist: decode process names > > >> of processes in zombie state") > > >> for -S option, if process name is using pid, it uses different way to > > >> set it. So that we get the process name and not just Pid. > > >> > > >> This change went in only for timehist_print_sample() function. > > >> Add this improvement in generic place so that even -s option (which > > >> captures summary) also will have meaningful information. > > >> > > >> Signed-off-by: Athira Rajeev > > > > > > Acked-by: Namhyung Kim > > > > > > Thanks, > > > Namhyung > > Hi, > > > > Can we please have this pulled in, if the patch looks fine ? > > Can you please check applying it on top of current perf-tools-next? So, this seems to be also addressed by: commit 39f473f6d0b24cf375893f2110b1cc9d8a079a42 Author: Anubhav Shelat Date: Wed Jul 16 16:39:15 2025 -0400 perf sched timehist: decode process names of processes in zombie state Previously when running perf trace timehist --state, when recording processes in the zombie state the process name would not be decoded properly and appears with just the PID: 1140057.412177 [0006] Mutter Input Th[3139/3104] 0.956 0.019 0.041 S 1140057.412222 [0012] :1248612[1248612] 0.000 0.000 0.332 Z 1140057.412275 [0004] 0.052 0.052 0.953 I 1140057.412284 [0008] 0.070 0.070 0.932 I 1140057.412333 [0004] KMS thread[3126/3104] 0.953 0.112 0.058 S Now some extra processing has been added to decode the process name: 1140057.412177 [0006] Mutter Input Th[3139/3104] 0.956 0.019 0.041 S 1140057.412222 [0012] sleep[1248612] 0.000 0.000 0.332 Z 1140057.412275 [0004] 0.052 0.052 0.953 I 1140057.412284 [0008] 0.070 0.070 0.932 I 1140057.412333 [0004] KMS thread[3126/3104] 0.953 0.112 0.058 S Signed-off-by: Anubhav Shelat Link: https://lore.kernel.org/r/20250716203914.45772-2-ashelat@redhat.com Signed-off-by: Namhyung Kim No? It is not applying to perf-tools-next, a quick look found the patch above. - Arnaldo