From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B022BCD6E4A for ; Thu, 4 Jun 2026 14:56:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wV9UJ-0002K9-EE; Thu, 04 Jun 2026 10:56:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV9UC-0002Gc-FR for qemu-devel@nongnu.org; Thu, 04 Jun 2026 10:56:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV9U9-0003Uq-NE for qemu-devel@nongnu.org; Thu, 04 Jun 2026 10:55:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780584950; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ShzPLXgmhJILskQVnZdiFFuDSVOaRhlYEIx7QjR1zo=; b=ge3r7bxGi5Nd6+lRxoe7UKxR22qmPaxJZgIU74YUZRY6yiQzEOLRGoTmpS97czSBD82OmT ONiomt/Yw+fN0f99tthn7/BQ7i1q0DbNPKSi3jA/6d3T8jqoO7smqpaze5EzjEz6FaBcij dLIKTHvrQMhCpHwGH2FcVerPyG5gAm0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-DBtu4-NTOQOcwXNPBgHtEQ-1; Thu, 04 Jun 2026 10:55:48 -0400 X-MC-Unique: DBtu4-NTOQOcwXNPBgHtEQ-1 X-Mimecast-MFC-AGG-ID: DBtu4-NTOQOcwXNPBgHtEQ_1780584947 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E2181944B05 for ; Thu, 4 Jun 2026 14:55:47 +0000 (UTC) Received: from redhat.com (unknown [10.44.50.34]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 26EE51800480; Thu, 4 Jun 2026 14:55:45 +0000 (UTC) Date: Thu, 4 Jun 2026 15:55:42 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, armbru@redhat.com Subject: Re: [PATCH v3 14/24] target/i386/sev: add finalize functions and fix leaking setters Message-ID: References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> <20260516-qom-tests-v3-14-3f20c3a029a7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260516-qom-tests-v3-14-3f20c3a029a7@redhat.com> User-Agent: Mutt/2.3.1 (2026-03-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, May 16, 2026 at 11:59:13AM +0400, Marc-André Lureau wrote: > None of the three SEV types (sev-common, sev-guest, sev-snp-guest) > had instance_finalize functions, so all string fields allocated > during init or by property setters were leaked on object destruction. > > Add sev_common_finalize, sev_guest_finalize, and > sev_snp_guest_finalize to free the allocated fields. > > Also fix sev_common_set_sev_device, sev_guest_set_dh_cert_file, > and sev_guest_set_session_file to free the old value before > replacing it. > > Fixes: a9b4942f485b ("target/i386: add Secure Encrypted Virtualization (SEV) object") ^^^ that trailing 'b' shouldn't be there Should also reference 7b34df44260b391e33bc3acf1ced30019d9aadf1 for the SNP struct which came later. > Signed-off-by: Marc-André Lureau > --- > target/i386/sev.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|