From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913C733F59A for ; Thu, 4 Jun 2026 15:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586574; cv=none; b=HDn6nXGkvOhvHs31yQCQHMtqqTIv2E8zRyXadne47vzSul+MfQk+We9iGmftEmM36wSP3hLa/jNfFsvy9WAD2gK42Y6u4PfdG64J1T7B8itViPAG1hyYP1N1TvmqBTEs42tsTty0gQH3ksISrGCu4MV9u0rLkmfeBRoGGAPuyT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586574; c=relaxed/simple; bh=YoyUB9+Pty56y6MKzCmCyjfVATH2z6iO3dZnKbjA12c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HndazQvk41YqHMJFouctiDkLx+G7RrtjIs1twfH1a92aZYzMQ0DDmiyfyrUhGpnvdFUPP6QzH9XXna52dZsaL0hYiSAWSex6sccD1M2pQn3G6fgze4fJXatp6Un0wz24VS966Illd5HcdDkCDb+8lBM8tXBVZ32rmoJxzgaFD60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p8b2X+X6; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p8b2X+X6" Date: Thu, 4 Jun 2026 17:22:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780586571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jDT1nP6S3c7GtGLmFXRfYZnQOBzcp5RrfPhiNrax4Es=; b=p8b2X+X6MPIqca/evlJoSV/lVmta88lccPlLXpCrRhqiPDDezcdzjjRrwFSBqwZIYR3mZD mYTTt+zqCWmcYEC++Z4BLKOLaHCYgU0y2RESRPVNk5fkoBC49nMKugkZGAGO2F+6omMLzd GE4q3eAFu+aXiFcqYf7bZQSMcvAxE6A= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Sudip Mukherjee Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] parport: replace kmalloc + strcpy with kstrdup in parse_data Message-ID: References: <20260518164803.81003-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518164803.81003-2-thorsten.blum@linux.dev> X-Migadu-Flow: FLOW_OUT Gentle ping? On Mon, May 18, 2026 at 06:48:04PM +0200, Thorsten Blum wrote: > Replace kmalloc() followed by strcpy() with a single call to kstrdup() > to simplify parse_data(). > > Signed-off-by: Thorsten Blum > --- > drivers/parport/probe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/parport/probe.c b/drivers/parport/probe.c > index 5d1b9aacb130..bf9d81c0abaf 100644 > --- a/drivers/parport/probe.c > +++ b/drivers/parport/probe.c > @@ -52,7 +52,7 @@ static void pretty_print(struct parport *port, int device) > > static void parse_data(struct parport *port, int device, char *str) > { > - char *txt = kmalloc(strlen(str)+1, GFP_KERNEL); > + char *txt = kstrdup(str, GFP_KERNEL); > char *p = txt, *q; > int guessed_class = PARPORT_CLASS_UNSPEC; > struct parport_device_info *info = &port->probe_info[device + 1]; > @@ -61,7 +61,6 @@ static void parse_data(struct parport *port, int device, char *str) > pr_warn("%s probe: memory squeeze\n", port->name); > return; > } > - strcpy(txt, str); > while (p) { > char *sep; > q = strchr(p, ';');