From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C81D3358B9 for ; Thu, 4 Jun 2026 15:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586816; cv=none; b=emncxvZKNgfDKT0g8Kt2iuEv68RNf64QNmFe28kicBKUIYPDjmC4EJo7SZ9go/MNUnhyTh5zolC/vZgO6bGie+p0qngC5TjqksFopZJUM21jwnbL1VCkLwbw+jNjd9kpFR52FSLgfOAfR3yFtsCj4kWwJL6V4XGlplglciri538= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586816; c=relaxed/simple; bh=yfedOrcJf4mlQaFolzpzpXVyMPi0ydsE16zIqYMttJA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RC2XadAXzBA5apilJf+rotrfc4qcgeDSRvuFdclRkGn/4hOyDYhx8IT1FKD3xpY8cesf3nVbJ4eF/FvPbQM2R9rTd5gGhuJ362QwBqM0NjaI4QUcUZc3qVQ2RdUAaIBzeGH28b0h3XIBJ2RIvSqnLW7m5MRFSd65fZ5W/xLZp4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QuvN99Nh; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QuvN99Nh" Date: Thu, 4 Jun 2026 17:26:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780586813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LsvSKVyscUiDZSDq1fgevWdOHkqj2wcpZKOb0+Do5Pc=; b=QuvN99NhQc3yrS34mpXpJ+OBT3JDnhWS00QjW+H4LJBFf35ovUqFePvDP216SUoF76BEDE oQUfmZ0uNOmFzJ3bpSxjZ86ZDORrwCccBn+9glBI2T5g+LKRh9R1XGL4CZVjKK5EHZiJy8 t6CANb8Id8tUntAKf/1RWd1ncfVwOeA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Parthiban Veerasooran , Christian Gromm Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] most: configfs: use sysfs_emit in sysfs show functions Message-ID: References: <20260504181559.143576-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260504181559.143576-3-thorsten.blum@linux.dev> X-Migadu-Flow: FLOW_OUT Gentle ping? On Mon, May 04, 2026 at 08:16:00PM +0200, Thorsten Blum wrote: > Replace snprintf() with sysfs_emit() in sysfs show functions, which is > preferred for formatting sysfs output because it provides safer bounds > checking. > > Signed-off-by: Thorsten Blum > --- > drivers/most/configfs.c | 28 ++++++++++++---------------- > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/drivers/most/configfs.c b/drivers/most/configfs.c > index 8f5158d95bc3..f2aae6874b64 100644 > --- a/drivers/most/configfs.c > +++ b/drivers/most/configfs.c > @@ -8,6 +8,7 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > #include > #include > +#include > #include > #include > #include > @@ -159,7 +160,7 @@ static ssize_t mdev_link_destroy_link_store(struct config_item *item, > > static ssize_t mdev_link_direction_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->direction); > + return sysfs_emit(page, "%s\n", to_mdev_link(item)->direction); > } > > static ssize_t mdev_link_direction_store(struct config_item *item, > @@ -177,7 +178,7 @@ static ssize_t mdev_link_direction_store(struct config_item *item, > > static ssize_t mdev_link_datatype_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->datatype); > + return sysfs_emit(page, "%s\n", to_mdev_link(item)->datatype); > } > > static ssize_t mdev_link_datatype_store(struct config_item *item, > @@ -196,7 +197,7 @@ static ssize_t mdev_link_datatype_store(struct config_item *item, > > static ssize_t mdev_link_device_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->device); > + return sysfs_emit(page, "%s\n", to_mdev_link(item)->device); > } > > static ssize_t mdev_link_device_store(struct config_item *item, > @@ -211,7 +212,7 @@ static ssize_t mdev_link_device_store(struct config_item *item, > > static ssize_t mdev_link_channel_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->channel); > + return sysfs_emit(page, "%s\n", to_mdev_link(item)->channel); > } > > static ssize_t mdev_link_channel_store(struct config_item *item, > @@ -226,7 +227,7 @@ static ssize_t mdev_link_channel_store(struct config_item *item, > > static ssize_t mdev_link_comp_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->comp); > + return sysfs_emit(page, "%s\n", to_mdev_link(item)->comp); > } > > static ssize_t mdev_link_comp_store(struct config_item *item, > @@ -241,8 +242,7 @@ static ssize_t mdev_link_comp_store(struct config_item *item, > > static ssize_t mdev_link_comp_params_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%s\n", > - to_mdev_link(item)->comp_params); > + return sysfs_emit(page, "%s\n", to_mdev_link(item)->comp_params); > } > > static ssize_t mdev_link_comp_params_store(struct config_item *item, > @@ -257,8 +257,7 @@ static ssize_t mdev_link_comp_params_store(struct config_item *item, > > static ssize_t mdev_link_num_buffers_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%d\n", > - to_mdev_link(item)->num_buffers); > + return sysfs_emit(page, "%d\n", to_mdev_link(item)->num_buffers); > } > > static ssize_t mdev_link_num_buffers_store(struct config_item *item, > @@ -275,8 +274,7 @@ static ssize_t mdev_link_num_buffers_store(struct config_item *item, > > static ssize_t mdev_link_buffer_size_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%d\n", > - to_mdev_link(item)->buffer_size); > + return sysfs_emit(page, "%d\n", to_mdev_link(item)->buffer_size); > } > > static ssize_t mdev_link_buffer_size_store(struct config_item *item, > @@ -294,8 +292,7 @@ static ssize_t mdev_link_buffer_size_store(struct config_item *item, > static ssize_t mdev_link_subbuffer_size_show(struct config_item *item, > char *page) > { > - return snprintf(page, PAGE_SIZE, "%d\n", > - to_mdev_link(item)->subbuffer_size); > + return sysfs_emit(page, "%d\n", to_mdev_link(item)->subbuffer_size); > } > > static ssize_t mdev_link_subbuffer_size_store(struct config_item *item, > @@ -313,8 +310,7 @@ static ssize_t mdev_link_subbuffer_size_store(struct config_item *item, > static ssize_t mdev_link_packets_per_xact_show(struct config_item *item, > char *page) > { > - return snprintf(page, PAGE_SIZE, "%d\n", > - to_mdev_link(item)->packets_per_xact); > + return sysfs_emit(page, "%d\n", to_mdev_link(item)->packets_per_xact); > } > > static ssize_t mdev_link_packets_per_xact_store(struct config_item *item, > @@ -331,7 +327,7 @@ static ssize_t mdev_link_packets_per_xact_store(struct config_item *item, > > static ssize_t mdev_link_dbr_size_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "%d\n", to_mdev_link(item)->dbr_size); > + return sysfs_emit(page, "%d\n", to_mdev_link(item)->dbr_size); > } > > static ssize_t mdev_link_dbr_size_store(struct config_item *item,