From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C9033FE09 for ; Thu, 4 Jun 2026 15:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586961; cv=none; b=l0cQac8m31R09jKpsWi+BuFDfmzD4yPkFPAq3Wub6xfrGYYKTKv8xQT0XScuGCPNrVeHGbTU7dz6WwMUOFkOeSrSp5Kq2FShkNkMZpjlb6lv/guOyjxyOMkhv5YswFkE+Te6favEwQcDm5yraNswIFEta2pIxg1OmHrxNamoPeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586961; c=relaxed/simple; bh=GSBY+T9nbFZxAFbk6YZOBiwLmi/q/TNzN8kdWQfDcc8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QEroEVsVCWPLIDQeMuNyg5eepWUncg8yGspOWqB8NSJPHYppAxLhLQKMzgJ8oikSIg67hJMtGvOPNa2j4ySXo6GSQUycHodsk7pSm1TDA3K9BcuKyTX+lEOz0InHbpKBrfREmUtjQ2lb88c7CDbO64EzldYg+G/Ms2Of2RzswVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WcUC9SUg; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WcUC9SUg" Date: Thu, 4 Jun 2026 17:29:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780586957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3P1orFamnpm5OY7W5CE69Xi4mNxqnnftrnidK8jsuVk=; b=WcUC9SUgQms01BX2mghqnOUJfVM5dndDKMMNj7IFVUaElQV0OISuZyh9NrnT26iZCHe4sC pln4Iv26Mi1ELQYg1YeWhCPlGS0Cz3kdyj2T4s5Js3QmS6chOMMA9GhzGPcd/GJWCpJ/ng tCsBdVqIHZnq42vFpvAzec+OAXjvgqE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Parthiban Veerasooran , Christian Gromm Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] most: replace snprintf("%s") with strscpy in audio_probe_channel Message-ID: References: <20260429000858.1442-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260429000858.1442-3-thorsten.blum@linux.dev> X-Migadu-Flow: FLOW_OUT Gentle ping? On Wed, Apr 29, 2026 at 02:08:59AM +0200, Thorsten Blum wrote: > Replace snprintf("%s") with the faster and more direct strscpy(). > > Signed-off-by: Thorsten Blum > --- > drivers/most/most_snd.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/most/most_snd.c b/drivers/most/most_snd.c > index 68b9e6c64033..dc366813c31e 100644 > --- a/drivers/most/most_snd.c > +++ b/drivers/most/most_snd.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -554,10 +555,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id, > sizeof(*channel), &adpt->card); > if (ret < 0) > goto err_free_adpt; > - snprintf(adpt->card->driver, sizeof(adpt->card->driver), > - "%s", DRIVER_NAME); > - snprintf(adpt->card->shortname, sizeof(adpt->card->shortname), > - "Microchip INIC"); > + strscpy(adpt->card->driver, DRIVER_NAME); > + strscpy(adpt->card->shortname, "Microchip INIC"); > snprintf(adpt->card->longname, sizeof(adpt->card->longname), > "%s at %s", adpt->card->shortname, iface->description); > skip_adpt_alloc: