From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp01-ext2.udag.de (smtp01-ext2.udag.de [62.146.106.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C909494A15 for ; Fri, 5 Jun 2026 08:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.146.106.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780647113; cv=none; b=B2yhk85oAsnBgWgFwbdkPE/0Eyjkxu9DgpmM4m/AK1iJ8fOCoa0XxhlxvXssq8l88pkUHQK0ujY1JzeqLy4Nf+BSTq+9m2ybRSxPrayYorpiiR5Uf2EvOS6kvqGPLMjjFxQ6iUKIY/c7oFsJcafBWmRs5iOPvzU10+0m44R9gOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780647113; c=relaxed/simple; bh=99horYYel+XnjflGyToF3UOxxwVSaj7jPocNodLA2RI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XcO10cF2veXz1rAHLncz62GqcZZpMTOQrKQwTWLfUDpse6g2SjUSpGlkfLCJmQdlAtfNpmqSvzpMQFJ8fayZrCMD95Ax49AGDXmkcZGBIbLrz0PVjCSAYdSRSnEVOVBYR36islBgv13Y7tT0VNKP0YKFRDPNZHydcvIFk1xA3FY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=birthelmer.de; spf=pass smtp.mailfrom=birthelmer.de; arc=none smtp.client-ip=62.146.106.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=birthelmer.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birthelmer.de Received: from localhost (065-142-067-156.ip-addr.inexio.net [156.67.142.65]) by smtp01-ext2.udag.de (Postfix) with ESMTPA id 8DF0EE015C; Fri, 5 Jun 2026 10:03:17 +0200 (CEST) Authentication-Results: smtp01-ext2.udag.de; auth=pass smtp.auth=birthelmercom-0001 smtp.mailfrom=horst@birthelmer.de Date: Fri, 5 Jun 2026 10:03:16 +0200 From: Horst Birthelmer To: Amir Goldstein Cc: Horst Birthelmer , Miklos Szeredi , Bernd Schubert , Joanne Koong , Luis Henriques , linux-kernel@vger.kernel.org, fuse-devel@lists.linux.dev, Horst Birthelmer Subject: Re: Re: [PATCH v7 1/4] fuse: add compound command to combine multiple requests Message-ID: References: <20260604-fuse-compounds-upstream-v7-0-27331d085c2a@ddn.com> <20260604-fuse-compounds-upstream-v7-1-27331d085c2a@ddn.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Thanks a lot, Amir, for looking at this! On Fri, Jun 05, 2026 at 09:41:00AM +0200, Amir Goldstein wrote: > On Thu, Jun 4, 2026 at 11:51 AM Horst Birthelmer wrote: > > +/* > > + * FUSE: Filesystem in Userspace > > + * Copyright (C) 2025-2026 > > Copyright to /dev/null? > LOL, that's a copy paste error of the header ... > > diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c > > index 5dda7080f4a9..7b20e4e9971a 100644 > > --- a/fs/fuse/dev.c > > +++ b/fs/fuse/dev.c > > @@ -413,11 +413,47 @@ const struct fuse_iqueue_ops fuse_dev_fiq_ops = { > > }; ... > > Move more of those compound helpers to compound.c instead of bloating dev.c > I completely get your point and I will change that. I just thought that it would be easier to 'review' if it is clearly visible where the change is done to the normal flow, since this was one of the main things for this version > > + */ > > +struct fuse_compound_req_in { > > + uint8_t dep_index; > > + uint8_t reserved[3]; > > +}; > > + > > > It's ok that currently only nodeid (outarg[0]) is propagated, > but I think that the UAPI should describe that this is the case. > Something like this? > > uint8_t dep_index; > uint8_t dep_arg_idx; > uint8_t dep_arg_type; > }; > Good idea, I will add this and let 0 be the nodeid type(?), so that the code does not change ;-) > We probably don't need to waste uint8_t on dep_arg_idx IDK > > TBH, I did not look at NFS/SMB compound protocols, not io_uring > command chains, so I would appreciate it if you include a survey of the > state of the art in other protocols practices for compound commands. OK, I will do that. I don't remember how NFS does it. > > Thanks, > Amir. Thanks, Horst