All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Loidolt <dominik.loidolt@univie.ac.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Alejandro R Sedeño" <asedeno@google.com>,
	"Alejandro R. Sedeño" <asedeno@mit.edu>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] compat/posix.h: enable UNUSED warning messages for Clang
Date: Fri, 5 Jun 2026 10:44:40 +0200	[thread overview]
Message-ID: <aiKMeHXOCulPAaXq@four.local> (raw)
In-Reply-To: <xmqqqznsossj.fsf@gitster.g>

On Mon, May 04, 2026 at 10:41:16AM +0900, Junio C Hamano wrote:
> > Does this "drop support" because you force _all_ versions of Clang
> > to use the "deprecated" attribute, even though you _know_ some older
> > versions do not understand it?  Don't these versions identify
> > themselves so that you can do
> >
> > 	#if defined(__clang__) && CLANG_VERSION >= 2.9
>
> IOW, something like this, perhaps?

Yes, you're right. My original patch breaks older Clang versions for no
good reason.

I'll send a v2 with an explicit Clang version check, as you suggested.

Thanks,
 Dominik

  reply	other threads:[~2026-06-05  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 15:12 [PATCH] compat/posix.h: enable UNUSED warning messages for Clang Dominik Loidolt
2026-05-04  1:10 ` Junio C Hamano
2026-05-04  1:41   ` Junio C Hamano
2026-06-05  8:44     ` Dominik Loidolt [this message]
2026-06-05  9:46 ` [PATCH v2] " Dominik Loidolt
2026-06-05 10:40   ` Patrick Steinhardt
2026-06-05 11:50     ` Dominik Loidolt
2026-06-05 13:22       ` Patrick Steinhardt
2026-06-05 15:53         ` Dominik Loidolt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiKMeHXOCulPAaXq@four.local \
    --to=dominik.loidolt@univie.ac.at \
    --cc=asedeno@google.com \
    --cc=asedeno@mit.edu \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.