Re: [PATCH v4 2/2] dump: enhance win_dump_available to report properly

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jan 08, 2026 at 10:30:29AM +0100, Denis V. Lunev wrote:
> On 1/8/26 09:11, Marc-André Lureau wrote:
> > Hi Nikolai
> >
> > On Wed, Sep 24, 2025 at 12:30 PM Marc-André Lureau
> > <marcandre.lureau@redhat.com> wrote:
> >> Hi
> >>
> >> On Thu, Sep 11, 2025 at 4:37 PM Nikolai Barybin <nikolai.barybin@virtuozzo.com> wrote:
> >>> QMP query-dump-guest-memory-capability reports win dump as available for
> >>> any x86 VM, which is false.
> >>>
> >>> This patch implements proper query of vmcoreinfo and calculation of
> >>> guest note size. Based on that we can surely report whether win dump
> >>> available or not.
> >>>
> >>> To perform this I suggest to split dump_init() into dump_preinit() and
> >>> dump_init_complete() to avoid exausting copypaste in
> >>> win_dump_available().
> >>>
> >>> For further reference one may review this libvirt discussion:
> >>> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HJ3JRLWLGN3IKIC22OQ3PMZ4J3EFG5XB/#HJ3JRLWLGN3IKIC22OQ3PMZ4J3EFG5XB
> >>> [PATCH 0/4] Allow xml-configured coredump format on VM crash
> >>>
> >>> Signed-off-by: Nikolai Barybin <nikolai.barybin@virtuozzo.com>
> >>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> >>
> > Have you looked at my review & updated the patches? thanks
> I will send updated version next week after vacation. Nikolai has
> left Virtuozzo.
> 
> Thank you for the reminder and best regards,

I don't recall seeing a followup v5 for this ? Were you still
interested in progressing this work ?

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|