From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3648B404BD0 for ; Fri, 5 Jun 2026 16:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780676289; cv=none; b=lWDU+4cvyvzIjnOXcnXrQpw+b0kPfkiY7F6Om0n1B8VfZu2+Kl4Zw2aIptVaYlsuU4Vp1YxuxDl4QlfOPUHeA+o3xLixv17MFj2azyTpbYjp2vzPwUruA3UHVk5BgsrSE2jT0eey9EHO0KQj7r2xmbklwU9w4UiQJdFVrmeA8BQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780676289; c=relaxed/simple; bh=XRGI76MigkpSmoBHVTbHez1J+BmuHbL3tcuBjvVJSVU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LvEzeu93A0JMyTP3qwwiOdhR2XM728siT8yv9RVUM4WXx0c3yDkaWH9kUGsWxYaxEWGYrCsuVYrkpXMYmxYyr+Bg+FqzmIvoGE31YjUoKASGPiMG0GaYlr2hnCrIBKp0eCjttVW7ZSt0c04KGnhOSe5IMLOvsvaptKY0bOafeoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HW4tGWhD; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HW4tGWhD" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c0b1a48855so142125ad.0 for ; Fri, 05 Jun 2026 09:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780676287; x=1781281087; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0Kt2tlKaxHAEAtMQ5U0c1x3clX9wtZ7zN2hv6EXts24=; b=HW4tGWhDcz6lLciajGPKQEGtOdxi48G4TGG+kYcEeXAEDxQy55+9nOoYyv/1nkUqGq W13WGOqpsSa6fEri3l3XHz6KP4RH+CWBv2C3lUFqoOLiKkPzkcB21ZdhEINsPMKFJo3R PVS2W7mRARbCf1rDZDfGDWlGTfdYSQAOLQFyq+A5pPXJloewYk05EXYMFSFSQGj0dHqK zlLB8s2Dtse4q57FQX2IKZUENwUH39ZqT1YMrp7WUTU6Sd4gmCdryjz1vToCl6w+aKcY gcoxlvkz1bNv9zNOOgIaWAG/GKg6ZWy9MNITAtJ18D69XNwV8sSWR89Po6Qybosc9imV JtEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780676287; x=1781281087; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Kt2tlKaxHAEAtMQ5U0c1x3clX9wtZ7zN2hv6EXts24=; b=WRLE4tWkhebburowuHKllgej33YJdZWhY5bBC8VVDqYRvLH6uAAk6ZU/ZDYFt9pe32 Fm+1hrpYbeUh5AP6HxHkiGJNGwHk7w7xqVTqUsY6f+yX3ll5oYIWUJcgYkUH80YGms18 XwbnAhXW+gNbCNGnHSEHZlPoO7Dd5C7SKO1ATG7Q7n/nxPY4iIwOWtnTte5fKMBrtIrl fQhIYJtUkTW+ZSqhmkJpaLyBugw1wgJ/rOe/oSJCqldiVAymEePVnGEzWJ2+EayYBiWZ uHtRkjSqBDA8mrkxEccpyyfqBw9DuAYgMjY+uH9hyH0Ngx87kW1CnqS8BDE38EFBCZMC 4pMQ== X-Forwarded-Encrypted: i=1; AFNElJ91krqWRbLi/yTmble8T/aafyvvYYcoDJlAZ7dm6RSX37gzjli2vw5IfSe88Iaa/QDl33TAsvT7OLX6bLo=@vger.kernel.org X-Gm-Message-State: AOJu0YzxPogdt3A/4k8GF+YBX7cdijIaS2Sh9u5sJ222HT9kiUEIIrFk RzBqtm/5eKPdA1q1DrXJQyHgo1/gSurtvVrrtiUe8EwY3+YV0M7wK7vFoJufV6YlXg== X-Gm-Gg: Acq92OE2PZ4mvixVoqbQLlUY5lZn7nYVnLAz8Qr2UJZOP/9iVhNDhUW2CcgDPtpploC Sv6U8PGtpHAy38vA/ViGdRAP5ixxAeIJtMRkmIULsgGUiXrIaQCXyu084vYdA8acW4sHmJtHaxU KE9fz1gzVwq63Wq1rZq7jVVDaxt51h7KBjzSI4uJx5CZ/SO6qdt/z2ZMOKF/yKUPWDPktpRmLMa IZOkQ6KNXjX9/l/93Q88qXZGWdvdN8xutVmFMwaj1xOHxJrrRlgPGnrIY0O9WYMqw+hES/qOHvO RPGE1WbE2OJH8gHfVAQN/NUromhHh5lM1pFoWEm4UY9FsX2czjmqJEirQcvgkWlGX4RLImaPpSH iRFPkos7yCmleCl5laApP8hLtMW5Pe00IxN6uayk6/L8ESCHoeaIr+dryLD1G4oGzcQbRr0FH3k 2Vd4y8G75Kwk6m415dl/I3l4tgQQL1y3uLcO23a0U0o72kcvkHWp8GUS36CESi0gYOVmZrLdPSD v78REOxuVh1vpYu0Tal7Dzy2SUmaw== X-Received: by 2002:a17:903:2349:b0:2bd:a61:8536 with SMTP id d9443c01a7336-2c1eb74103fmr1371525ad.6.1780676286817; Fri, 05 Jun 2026 09:18:06 -0700 (PDT) Received: from google.com (25.75.145.34.bc.googleusercontent.com. [34.145.75.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f890b2sm97716405ad.26.2026.06.05.09.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 09:18:06 -0700 (PDT) Date: Fri, 5 Jun 2026 16:18:02 +0000 From: Samiullah Khawaja To: Pranjal Shrivastava Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Will Deacon , Robin Murphy , Baolu Lu , Jason Gunthorpe , Kevin Tian , Bjorn Helgaas Subject: Re: [PATCH v8 3/4] iommu/arm-smmu-v3: Standardize ATS enablement failure reporting Message-ID: References: <20260604182116.3179005-1-praan@google.com> <20260604182116.3179005-4-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260604182116.3179005-4-praan@google.com> On Thu, Jun 04, 2026 at 06:21:15PM +0000, Pranjal Shrivastava wrote: >Update arm_smmu_enable_ats() to wrap the pci_enable_ats() call in >WARN_ON(). Since probe-time checks now preclude configuration errors >any failure during hardware enablement is considered a kernel bug. > >Reviewed-by: Kevin Tian >Signed-off-by: Pranjal Shrivastava >--- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >index a10affb483a4..0494c68daa19 100644 >--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >@@ -2956,7 +2956,12 @@ static void arm_smmu_enable_ats(struct arm_smmu_master *master) > * ATC invalidation of PASID 0 causes the entire ATC to be flushed. > */ > arm_smmu_atc_inv_master(master, IOMMU_NO_PASID); >- if (pci_enable_ats(pdev, stu)) >+ >+ /* >+ * Since pci_prepare_ats() has already verified the HW capability >+ * and programmed the STE, pci_enable_ats() should not fail here. >+ */ >+ if (WARN_ON(pci_enable_ats(pdev, stu))) > dev_err(master->dev, "Failed to enable ATS (STU %zu)\n", stu); > } > >-- >2.54.0.1032.g2f8565e1d1-goog > Reviewed-by: Samiullah Khawaja