From: Oleg Nesterov <oleg@redhat.com>
To: Chris Li <sparse@chrisli.org>, Luc Van Oostenryck <lucvoo@kernel.org>
Cc: Alexey Gladkov <legion@kernel.org>, linux-sparse@vger.kernel.org
Subject: [PATCH 2/4] sparse/dissect: fold lookup_member() into find_report_member()
Date: Fri, 5 Jun 2026 16:56:46 +0200 [thread overview]
Message-ID: <aiLjrseuO-EnSUep@redhat.com> (raw)
In-Reply-To: <aiLjjDwKRB1UjNcs@redhat.com>
After the previous change lookup_member() has a single caller. Fold it
into find_report_member() and rename __lookup_member().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
dissect.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/dissect.c b/dissect.c
index 6b5cb0ef..c790807e 100644
--- a/dissect.c
+++ b/dissect.c
@@ -283,7 +283,7 @@ static struct symbol *base_type(struct symbol *sym)
?: &bad_ctype;
}
-static struct symbol *__lookup_member(struct symbol *type, struct ident *name, int *p_addr)
+static struct symbol *lookup_member(struct symbol *type, struct ident *name, int *p_addr)
{
struct symbol *node;
int addr = 0;
@@ -294,7 +294,7 @@ static struct symbol *__lookup_member(struct symbol *type, struct ident *name, i
return node;
}
else if (node->ident == NULL) {
- node = __lookup_member(node->ctype.base_type, name, NULL);
+ node = lookup_member(node->ctype.base_type, name, NULL);
if (node)
goto found;
}
@@ -310,9 +310,11 @@ found:
return NULL;
}
-static struct symbol *lookup_member(struct symbol *type, struct ident *name, int *addr)
+static struct symbol *find_report_member(usage_t mode, struct position *pos,
+ struct symbol *type, struct ident *name,
+ int *p_addr)
{
- struct symbol *mem = __lookup_member(type, name, addr);
+ struct symbol *mem = lookup_member(type, name, p_addr);
if (!mem) {
static struct symbol bad_member = {
@@ -328,14 +330,7 @@ static struct symbol *lookup_member(struct symbol *type, struct ident *name, int
mem->ident = name;
}
- return mem;
-}
-
-static struct symbol *find_report_member(usage_t mode, struct position *pos,
- struct symbol *type, struct ident *name,
- int *p_addr)
-{
- return report_member(mode, pos, type, lookup_member(type, name, p_addr));
+ return report_member(mode, pos, type, mem);
}
static struct expression *peek_preop(struct expression *expr, int op)
--
2.52.0
next prev parent reply other threads:[~2026-06-05 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 14:56 [PATCH 0/4] sparse/dissect: fix missing usage reports for unnamed members of named types Oleg Nesterov
2026-06-05 14:56 ` [PATCH 1/4] sparse/dissect: introduce find_report_member() Oleg Nesterov
2026-06-05 14:56 ` Oleg Nesterov [this message]
2026-06-05 14:56 ` [PATCH 3/4] sparse/dissect: introduce struct lookup_args for lookup_member() Oleg Nesterov
2026-06-05 14:56 ` [PATCH 4/4] sparse/dissect: fix missing usage reports for unnamed members of named types Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiLjrseuO-EnSUep@redhat.com \
--to=oleg@redhat.com \
--cc=legion@kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lucvoo@kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.