From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEB1F3DC4A9 for ; Fri, 5 Jun 2026 20:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780691397; cv=none; b=M7C5xbxGhHV5QLi3MCO5KgHpoF7aXZ/7XBeoKKHitpP06C32d7WcvYmSJMaYC2RsdPbrAMfGwobRR9vCzV5N22iXlbwszCtXkIQyzf5x/eQDxNgpn/GOVe5lVEkiWTV96SzkSUjEStgl+9fg4+LPSQdtYadJPkPBx4Y1MO4fJ34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780691397; c=relaxed/simple; bh=7al36cHo3BDtHFQYQ08gLrpOS4J2fFoCoT+d8jqHRo0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=k/Ctc7Qqvuod9SYy/lImJOpBnfiBkh8O/UymZeDSrZZNkXnXfiGlPsDDBv2LvayWymUCZZMbdKBtW2sZfDYrYF/2dw1PtPM1WZsKbuDwIG4lvw3VBKljO4b8VP7K6gx9zxf458sVP0PsEBode/2S85hJihTRqTdoa/aCUUGbuto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nO7zffms; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nO7zffms" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c0c1e112dfso33460745ad.0 for ; Fri, 05 Jun 2026 13:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780691395; x=1781296195; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=2PAYaiZVnbp+27NnF9Bl6rTCI8Ayo8ev30bWFSCGO6k=; b=nO7zffmsGhZWxqOhNPTlta/QVfkHANQkM7SuhLLYZWmIxM+IxhLa20rQJaDGY+wtX9 Ostr6Dj/GKoNTW/3EX2bGlve3PR0d49cbDvsja/eiULewjr4iAIFv04mH3LhdVsP84Zh BzclKRUiFYxsfHGW44/ihkoFZK2VlrUIO8ay06g+pf8oBJJ3/nkll6yv369jTzkCRXdu +In3KKIbPkT1c02jCjL0RmXFQ8feZY7OuErt28gbld+X/Ls8lTVVw3HLvSAEh7iVtmW1 jPs/iI0tXi/U9c7rLsN0gWYTzXy0wNlqhhSqeRXLTXWLBEoFgiZPpOmKUtVmieO1gSwL QmGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780691395; x=1781296195; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2PAYaiZVnbp+27NnF9Bl6rTCI8Ayo8ev30bWFSCGO6k=; b=QFZCpqa6GNnBuEw6JDW3HyGZJFkk8acwtMIpaFFuVzdSpNZQS0rAvzaPBWMmyxXC4q bk1Bp06n0rwEVnscJ0HwQWFlTCyrcBO4neQwJ9EBM1yfGWWAuVYc51Owf3tVIoSBFxU7 0xvZkiCuCVNtIG3QTtY8/VFKhnTopfb73J2CEAY88NyUBkid5RvLdL8+rXl62mCLSHPZ AGC6ac1jd+CAG71fanTMJIEYdAlJ3bz8Wuf3xYQXiQRMHzKwZdXd3zAfuq/HTtJg1WNi JncjQCGFxCAMTM5sphTmq4tyiIOYp4Vy/aFEAudkF38Kk7363eY8WCH2ZQZZ3mo3eW8t wzqg== X-Forwarded-Encrypted: i=1; AFNElJ/G7k5U7mXwsM2b0wg4ykHyxdVD2mLuesBL0AIlbObutppeCSmGECjw2tnfjo6Kukz2oNBVPENBCO2EUjM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4x3Ml6iyzy4nP1t36qDsrx7xN+RbbriZQTeu37A84AefCn/AM e4LVBA/z+Lp4GZ7l4+Aoo9FrGuQrTh3H2RFr1kRH1s+Q8ORR3pFx/5P8x7FmqIobrjhwRdFiyXZ MU6PV+w== X-Received: from pgvq15.prod.google.com ([2002:a65:624f:0:b0:c82:7af9:6a4b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:69b:b0:3b4:6f7e:d107 with SMTP id adf61e73a8af0-3b4ccd4c8b5mr7257822637.14.1780691395017; Fri, 05 Jun 2026 13:29:55 -0700 (PDT) Date: Fri, 5 Jun 2026 13:29:54 -0700 In-Reply-To: <652e8b73f2264316eaf72a604b89446df4874a2a.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260529222223.870923-1-seanjc@google.com> <20260529222223.870923-34-seanjc@google.com> <652e8b73f2264316eaf72a604b89446df4874a2a.camel@intel.com> Message-ID: Subject: Re: [PATCH v3 33/40] KVM: x86: Move kvm_cpu_get_apicid() from kvm_host.h => avic.c From: Sean Christopherson To: Kai Huang Cc: "pbonzini@redhat.com" , "vkuznets@redhat.com" , "dwmw2@infradead.org" , "paul@xen.org" , "kvm@vger.kernel.org" , "dwmw@amazon.co.uk" , "linux-kernel@vger.kernel.org" , "yosry@kernel.org" , "binbin.wu@linux.intel.com" Content-Type: text/plain; charset="us-ascii" On Fri, Jun 05, 2026, Kai Huang wrote: > On Fri, 2026-05-29 at 15:22 -0700, Sean Christopherson wrote: > > #define KVM_CLOCK_VALID_FLAGS \ > > diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c > > index b7083cd692ad..9264c8ef1fa1 100644 > > --- a/arch/x86/kvm/svm/avic.c > > +++ b/arch/x86/kvm/svm/avic.c > > @@ -146,6 +146,11 @@ static void avic_set_x2apic_msr_interception(struct vcpu_svm *svm, > > svm->x2avic_msrs_intercepted = intercept; > > } > > > > +static int kvm_cpu_get_apicid(int mps_cpu) > > +{ > > + return default_cpu_present_to_apicid(mps_cpu); > > +} > > + > > > > Looks it is only used by AMD (svm/avic.c). I don't know why, but it would be > nice if you can mention this in changelog, since this function seems pretty > common to both Intel and AMD. Huh, right, VMX posted interrupts needs the APIC ID too. Gah, posted_intr.c uses cpu_physical_id(): #define cpu_physical_id(cpu) per_cpu(x86_cpu_to_apicid, cpu) which is basically the same thing as default_cpu_present_to_apicid(): u32 default_cpu_present_to_apicid(int mps_cpu) { if (mps_cpu < nr_cpu_ids && cpu_present(mps_cpu)) return (int)per_cpu(x86_cpu_to_apicid, mps_cpu); else return BAD_APICID; } EXPORT_SYMBOL_FOR_KVM(default_cpu_present_to_apicid); Given that AVIC uses kvm_cpu_get_apicid() only when getting the pCPU for a loaded vCPU, it darn well should be impossible for the CPU to be offline, let alone not even present. I'll drop this patch, and instead send a separate patch to have AVIC use cpu_physical_id(), and kill off both kvm_cpu_get_apicid() and the above EXPORT. Thanks!