From: Len Bao <len.bao@gmx.us>
To: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Kees Cook <kees@kernel.org>
Cc: Len Bao <len.bao@gmx.us>,
linux-gpio@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: viperboard: mark gpioa_clk variable as __ro_after_init
Date: Sat, 6 Jun 2026 17:27:14 +0000 [thread overview]
Message-ID: <aiRYclMAqbfxv9nX@ubuntu> (raw)
In-Reply-To: <20260516100118.42728-1-len.bao@gmx.us>
Hi,
On Sat, May 16, 2026 at 10:01:12AM +0000, Len Bao wrote:
> The 'gpioa_clk' variable is initialized only during the init phase in
> the 'vprbrd_gpio_init' function and never changed. So, mark it as
> __ro_after_init.
>
> Signed-off-by: Len Bao <len.bao@gmx.us>
> ---
Friendly ping.
Any comments are welcome.
Regards,
Len
> drivers/gpio/gpio-viperboard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-viperboard.c b/drivers/gpio/gpio-viperboard.c
> index 89087fd48..4e6442390 100644
> --- a/drivers/gpio/gpio-viperboard.c
> +++ b/drivers/gpio/gpio-viperboard.c
> @@ -70,7 +70,7 @@ struct vprbrd_gpio {
> };
>
> /* gpioa sampling clock module parameter */
> -static unsigned char gpioa_clk;
> +static unsigned char gpioa_clk __ro_after_init;
> static unsigned int gpioa_freq = VPRBRD_GPIOA_FREQ_DEFAULT;
> module_param(gpioa_freq, uint, 0);
> MODULE_PARM_DESC(gpioa_freq,
> --
> 2.43.0
>
prev parent reply other threads:[~2026-06-06 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 10:01 [PATCH] gpio: viperboard: mark gpioa_clk variable as __ro_after_init Len Bao
2026-06-06 17:27 ` Len Bao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiRYclMAqbfxv9nX@ubuntu \
--to=len.bao@gmx.us \
--cc=brgl@kernel.org \
--cc=kees@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.