From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013063.outbound.protection.outlook.com [52.101.72.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EE123B19CF for ; Mon, 8 Jun 2026 09:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780910019; cv=fail; b=sGvFCifhYh59LThvXOopWaSsPS0X/P4i3FQsfn56m3Fd0QPpN4Rm34XaL3zC+Cprhv5TgbUtQqHW/beji6eKcjEuT+2d0wSotOJr2WLtkaQvLgOhV/uFd3IhG6YvkozMVd63FmDhiA18I34d7yNiyIEerqMo/hs8xo6D2HYlh3M= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780910019; c=relaxed/simple; bh=eAyZetlBhTX/P+9sSK98q+F/BrTcXT/N+3ldN6rY5tE=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=LbQ6Wk9D4zl9kw8ezGC7yEnt/c1xRsia9oezbv3un4t0/wf+VnPVn9l+Vm5fqNqVj87DYzxbUzW8NTTU5/jG40NQTmnUIFh9MTdW+tU8rG1DYaJ9NO7CaoUDh9qUxT14Uqu6iX3qs2esdNn/WB3k3d9ReHOuA8X8cHPNj/0JNtg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=L26QDNm6; arc=fail smtp.client-ip=52.101.72.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="L26QDNm6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pjaUhfe8r5p4Lb6uyPuiYr9nncztmpVA0XRNl3p9gr/amGPOXqKD4KInaXNUOFGO6hqbR7Xy96Fhch2Nt+eDboVUMmW8OCjvwSQpDYiWc9h6AvQncN6rsyYEnmY3+Mmj/bZtYsOFGRDJmk+/EEIXXTg/tnnI0fmWPoyCW7LdOjJo/PRY9hEDuuswfrYE86WFzrZpNCv8/HtEEqbrN/zsf1/eYWKCaLAvQA8vStaWcWuYxtPM1CeYCa54bTnKZ20O9X0Yx5WKDbcZlQfbHoE3eFyki03GrOgWv/OPDQVX81E03kKLbYQ7iKniDqU1bhQOANTymlv2Y0+grYw67wuQkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=61J5DCwDaCX/phkY6ZkufjRO8hhjS0y4z0LL83wORAY=; b=SgfiVUQ1Gby+FCk2sWQvb9K9XOVdwh0PylUmjxuEUnhZre9Y/N4Bboaxs1qGDwHKCi/WeZCPN4J/GRYMKdu3j78IOJuj+ZeLoREZb7VMq6PEpyNzQmvvItyUFMgrT6QWCI4IwHN2cE6oCi0G1EaWBJQXHlXiFPkbFnLjgHEo0vskNWS4Se1z0v9fFslssCGfygNpqjtciQUjrBuDyCo6A/XbpFjH2zdcs+SGbrtNTFh5OEtzb7S8xVESl/I2Jtl+0aWHxY0p+3672kmqdXnazYA+sLkf0oG/ELhTtOKkgkqjTbTJEXEtofueJUM0CtmXJB0MNO0OQ/w5/RoxEzU3cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61J5DCwDaCX/phkY6ZkufjRO8hhjS0y4z0LL83wORAY=; b=L26QDNm62C8JS922jVXHLyyUfkF4agrfecFjxWHHfWpYTq4PsqzFffmbINEw7eqTWUxa8bPMNE8+u7V2baRGAOqxLf7o4AmZAueCXjdUG8/xw1HzLDjfS5Sn5YnX/Sv/4f+KKSJOSxkL7c3XqQ8T73rOZ8sF9XlpC+B869b3cLG3JswQvBJFQaX7m/S3NcPR65owg2DRosV+vmEpZ91NikU/dpK7+bb8lGIgr+xn6/IEWgHCn4sBg+fZbYwrcWeYflX+1miwhen4DBaLUc+xM2josgcE15HKja4GE/yOHUqawSzQGbC7Mlz3g+Z2cyuZ9fv7s7tJIvgXWwai+17OyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS1PR04MB9287.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::8) by DB9PR04MB9990.eurprd04.prod.outlook.com (2603:10a6:10:4ee::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.13; Mon, 8 Jun 2026 09:13:34 +0000 Received: from AS1PR04MB9287.eurprd04.prod.outlook.com ([fe80::6f30:763d:17d2:b79c]) by AS1PR04MB9287.eurprd04.prod.outlook.com ([fe80::6f30:763d:17d2:b79c%3]) with mapi id 15.21.0092.011; Mon, 8 Jun 2026 09:13:33 +0000 Date: Mon, 8 Jun 2026 17:15:02 +0800 From: Liu Ying To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Luca Ceresoli Cc: Dmitry Baryshkov , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drm/bridge: imx93-mipi-dsi: Fix mode validation Message-ID: References: <20260515-imx93-mipi-dsi-fix-mode-validation-v3-1-91f7d22b2fe4@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515-imx93-mipi-dsi-fix-mode-validation-v3-1-91f7d22b2fe4@nxp.com> X-ClientProxiedBy: SI3PR03CA0004.apcprd03.prod.outlook.com (2603:1096:4:297::11) To AS1PR04MB9287.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS1PR04MB9287:EE_|DB9PR04MB9990:EE_ X-MS-Office365-Filtering-Correlation-Id: aa8e8fc6-2c3c-4c0e-62c8-08dec53e36f8 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|7416014|376014|22082099003|18002099003|921020|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: RzvKTIjrAPVernH7KqW4Xdj6p+HryLh1Mz5zhRKE4r7kNUBBrvwSXqAP8gEoeTklm+FqpIty2DKeHxo1CfdDzBElRvNq67ANxlVN4kCrWpu63a7d6K2tCvJ3H8UnU2Ky88dSQqSYfXRIMUyORk2QraWuWtGkyH13RI/P7+B4rICGlARP1FSzykKkKZxT1UpcHAz45oUvA0XsxVzIJlTWhhrgbqeZ18QmOOuj3H7WH/ibqWr8Vl5xgEBJI4lHenyAqeUZ8spgBidImSA+R40UmYjmP0GvZdxYbjXDAt17k7/3ZZewblcaMwGL2vvlCipZkZXRA5I84RCVKxCS9uPDd5ygysdrmW7haErr2xyHoHJTNDlAhotjjBfFr/HjlQVYzQSzIrT3XbTOuKJ8y3MQQzmN+FlxyyVyntUlEDhQtk5/O+ees7LDjLtTCD9JWBULClDAv7UpHRIE2IiLY4XUjVBRmK2tZutC8fmRbn+1vLjrdBkyMvTzIo8IspUid2QsXg4QC5vWmie0t7nHpyQvC+jmpsbDf55AZPbdMmH8C3ZHHP55DOMr4z4v4uM8HV8Wb0+sN0hxfiimA7M7X/jDqmlnjF8ttb37msjf47JVD5AQbvbkGiJT7nvlyeX9uuSqZx6CeVEvtyk5CWWha49bpGiLps1rr1NQrvBhz4TWbK0hYjSpmbkaiZyVOe/dJGu2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS1PR04MB9287.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(7416014)(376014)(22082099003)(18002099003)(921020)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ohd4y8l0PL4oF9GR0loksVeJd4KouxDBVIW0GfDAZNnpK+ypxurOjZLJ56Qp?= =?us-ascii?Q?nhQaqenPdiB5fw9BRheJmEI+9PwIO5KnhLr0eYZ6Gxfqbm4avFtA/zqa1Y16?= =?us-ascii?Q?u0C/a0AYtS8XTLzajFCDuu3xha7EJNch6zkepQBSutiaGF2+eFzGqLT9UjvH?= =?us-ascii?Q?l2+RUkxiEob/6PUpCl2riOMGb625ldJYrM/z6SbhmlXD0SR7B/csWLjjhFbF?= =?us-ascii?Q?ag00bqC8M5CWw7VvPZY4cLhiSqx6IXfOMHwQMfCPvOn2WbZMNx8vQwKtBBcG?= =?us-ascii?Q?6M6XVbmxziMybYLWsmAl1Prl5V/VnyHFBdxUkLoMP15y79pG2+3txkAJ7LEN?= =?us-ascii?Q?oRLTQlT2qOreQT55oZES8HEWbADX5aiGnrpYNWVsqJA/ojpIaZ+/LLDRF7PY?= =?us-ascii?Q?j1Dxi4ymVAsTTOXuPpk9XlyjA18Lm7cZBp2123koyU8NSDbR3D0kEQswO02M?= =?us-ascii?Q?D5JHm3zkyLlKjUECu1ImmRgrSGRclwyMGaNH2m1JIN6n22BYVyEfdXyFvVtw?= =?us-ascii?Q?Lcg3YqUYa6QtdWVolT1E3Zu0Jb08uQxhv9Ky2z20YeMZCOvsil8j5cUB2bzN?= =?us-ascii?Q?aewoZ1g7VApwZ81Xu760KNwhK6MnI27u4CxGFXb4ASI7pNdxWqi18S06UKwn?= =?us-ascii?Q?QU/XMuw25j/UKP9LdqqYj1wHQZ2/egNaCOT0p83M69ReEaQw43+0qo7RW9eG?= =?us-ascii?Q?+boogQH5e4+QvyoSmEoAHHf2HaIGk50/MeEkFXBRPIzK011WiAVdQ2Oes2Qu?= =?us-ascii?Q?pqu4TBskedabThBEFjRJm0khUpVUEyBOo3gkFgEhuQdWi883aUm7yIZMiSLo?= =?us-ascii?Q?NjoFwijAbzwd82L8zre9rIZz1Y/f7LrgkPhFSJerfEEXMsiPa+FxnoonFtl/?= =?us-ascii?Q?8TdDBSWvKeHvhykKrCgp3nINGQvwzoWdqQWtJB4fIkoPIgTxhzJB7ePKOHb8?= =?us-ascii?Q?6bte2bsPwZYWXFESD2JH45XXh42ut7ZupHrjce+lv36M0hAimZRq57LJ2Ork?= =?us-ascii?Q?krjqmelVO9fqP/hxIkjfX6rYAgUTiXD7wkrTbtecDvsQbqx+0DQRLWrWlsnj?= =?us-ascii?Q?Sxvst7iYry2E/PfFm5KfQp2A02XSDv1ZHjkFhPXyd5jt++Y6bAYFJc1CQJ1t?= =?us-ascii?Q?WOQETOK+hB1noffHJTwLY1HPRZ2BXNwyxlJNdkkv4uqd2Vmo8FGVPb0+3kkc?= =?us-ascii?Q?UbgwX8/xfy1HSmYFADRYE3YByPueQSwRQ5GLzez2FSqs+C76LVM/JY3NDYcw?= =?us-ascii?Q?Wk4YmKtOW6AaOhbkVRIPLtns32TrqTp42OlqRrXLRM/td3RdNz2np/HlWVv9?= =?us-ascii?Q?M4/GqJq5SVN5tOXGV/QIP0lHNDHrNMvTZvmPVofHlewr+IXTjmT6uxgakfok?= =?us-ascii?Q?GFqQXDGQdFbMsG66PiKF94Jrog0s9GRuwrDHWX0FExb+TT3WHQPgijkiCSv+?= =?us-ascii?Q?3m5kN6zf6TbL1UIzvQ0Savedzy3mPlNBvcBWoBbLtbdiQv3l4c/KJQrwGeor?= =?us-ascii?Q?URTIv9Pgy2UeimsvLIjHW9HtGN3u/TAapaXwzKQYsHoG9qUwQJN0j1bE5pMN?= =?us-ascii?Q?x70OhLU5yPmUK6teBSw6jVaaRaVBwD0tIvLNTK2bEftjSQkpiuUOuuof03aq?= =?us-ascii?Q?Pw9FSlW+3ZOOyMLlLHDDATbbC+SsGBEPjk/Ufsb4JSv52N75D+FaCd8NYb/5?= =?us-ascii?Q?pbFi1ezLGX66DV1ALf+JrtkqFvsFmkn3MRhdrTOt6Jknh1An8R7OVe+6ZG9c?= =?us-ascii?Q?Mm8/dZG6OQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa8e8fc6-2c3c-4c0e-62c8-08dec53e36f8 X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9287.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2026 09:13:33.8886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TW1oedy3zaeVjFfbC1YXvfHtrcuCThSNcfo1k8fWQkwZkGCpwRSy8wSp6nta/JBjTKTyhszgxKVcHCvKm0vF5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9990 On Fri, May 15, 2026 at 02:54:16PM +0800, Liu Ying wrote: > i.MX93 MIPI DPHY PLL has limitation for matching with some pixel clock > rates, e.g., the best DPHY PLL frequency is 445.333333MHz for a typical > 1920x1080p@60Hz CEA/DMT display mode with a pixel clock rate running > at 148.5MHz with 4 data lanes + RGB888 pixel in MIPI DSI sync pulse mode, > while the expected PLL frequency is (148.5 * 24) / 4 / 2 MHz = 445.5MHz. > Fortunately, VESA Display Monitor Timing Standard allows +/-0.5% pixel > clock rate deviation for timings. So, for those display modes read > from EDID through a bridge with DRM_BRIDGE_OP_DETECT and DRM_BRIDGE_OP_EDID > operation bit masks set, pixel clock rate could be adjusted to match > with the PLL frequency(for the above example, the pixel clock rate is > adjusted to be 148.444444MHz with about -0.03% deviation from the 148.5MHz > nominal rate so that the adjusted rate matches with the 445.333333MHz PLL > frequency). > > Instead of checking the last bridge's operation bit masks against > DRM_BRIDGE_OP_DETECT and DRM_BRIDGE_OP_EDID to determine if allowing > +/-0.5% pixel clock rate deviation, check any bridge after this bridge, > because the last bridge is usually a display connector bridge without > any operation bit mask when the clock rate deviation is allowed. > > Fixes: ce62f8ea7e3f ("drm/bridge: imx: Add i.MX93 MIPI DSI support") > Fixes: 5849eff7f067 ("drm/bridge: imx93-mipi-dsi: use drm_bridge_chain_get_last_bridge()") > Reviewed-by: Frank Li > Signed-off-by: Liu Ying > --- > Changes in v3: > - Iterate over next bridges manually instead of calling > drm_for_each_bridge_in_chain_from() to avoid deadlock issue. (sashiko bot) > - Fix a typo in commit message - s/modes/mode/. > - Link to v2: https://patch.msgid.link/20260512-imx93-mipi-dsi-fix-mode-validation-v2-1-7aec3be5da2c@nxp.com > > Changes in v2: > - Collect Frank's R-b tag. > - Add an explanation to commit message about the reason why mode validation > checks bridge's operation bit masks. (Dmitry) > - Copy Dmitry. > - Link to v1: https://lore.kernel.org/r/20260227-imx93-mipi-dsi-fix-mode-validation-v1-1-a9cd67991280@nxp.com > > To: Liu Ying > To: Andrzej Hajda > To: Neil Armstrong > To: Robert Foss > To: Laurent Pinchart > To: Jonas Karlman > To: Jernej Skrabec > To: Maarten Lankhorst > To: Maxime Ripard > To: Thomas Zimmermann > To: David Airlie > To: Simona Vetter > To: Frank Li > To: Sascha Hauer > To: Pengutronix Kernel Team > To: Fabio Estevam > To: Luca Ceresoli > Cc: Dmitry Baryshkov > Cc: dri-devel@lists.freedesktop.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 44 ++++++++++++++++++++--------- > 1 file changed, 31 insertions(+), 13 deletions(-) If possible, can I get a R-b or A-b tag from a drm/drm-misc maintainer/committer so that this can be picked up with good review? -- Regards, Liu Ying