From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51D65330B30 for ; Mon, 8 Jun 2026 09:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780911208; cv=none; b=TY+JV9XC7dpEHnZsH6v+g4kpS4N+vUQIuUeclwwE8z//dke/vZLcifUmeXAX52IinxxR6YcIAuBOmp++gghjWgN3EEvmvkH0nWfcqhseHYluhI27b82Mz1wjpwxYz8LPxCPgijaQvDub73NTlbP6Kg642id3VL3u1MwMn2q7Nqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780911208; c=relaxed/simple; bh=r82kQOW1kThHDjtCCpF9ipmtg24qsa0Xwm4O4dM9vyk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KQishqUZLbfjcNpiJ53fO63i/2OfRbTvYsf3dV19mU9lWe3wpc47Ed7Qhl7B78p50qSOzS26qC3RpmsXzxGqRu9bOjKc1R2bFLDzoDD+NyowjXQqUkfVDhEP5UCIgirYE24Sx0BVkytnaavr6ourII/wpSP2t5ZKJBQfiFjpy9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=nalvBhvm; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="nalvBhvm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lIBwNon+Y6QG8cGu84O7TniagGEto7BaLPHsrpyJedE=; b=nalvBhvm1MhlgDUmpbdAO+OFa1 u4CD8X4wxZVzYG3jpEo80+jXyDK2okghCNSWx7N3qpv0yrH0r7sLbcZgklvcBqbBIaOXa7yj0EqLG J+SwvkS66Vaaye2Gis1nlurSaR2bJtCJbR0DNNCurfKGBt9xukGLC05SNT7dZ+wA0x1cw2yNWMB2O G/DIZeibyV9PwntoBtqvwKg/IoDX65HgLkOwVgl1Z2iUzDoFBPntWBas6MhzLozXyQ9z4b2kd1kpq 9JTz9kh+sxsDAJORJ61w0YjjTsorlqeNc79Rkg2isTuKkHB1Vtz4MAYjo7DDteb1vX3Oy6Wsd1ViK KlulMTmw==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wWWME-007WjU-1I; Mon, 08 Jun 2026 09:33:22 +0000 Date: Mon, 8 Jun 2026 02:33:17 -0700 From: Breno Leitao To: Marco Crivellari Cc: linux-kernel@vger.kernel.org, Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Tejun Heo , Frederic Weisbecker , Sebastian Andrzej Siewior , Michal Hocko Subject: Re: [PATCH v4] checkpatch: Check WQ_PERCPU or WQ_UNBOUND presence in alloc_workqueue() users Message-ID: References: <20260608083711.76885-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608083711.76885-1-marco.crivellari@suse.com> X-Debian-User: leitao On Mon, Jun 08, 2026 at 10:37:11AM +0200, Marco Crivellari wrote: > The workqueue API introduced a new flag, WQ_PERCPU, that has to be used when > WQ_UNBOUND is not present. One of these flags must be present, but not > both of them. > > To limit usage mistakes, emit an ERROR if one of the below condition is met: The changelog still says "emit an ERROR", but since v3 the code uses WARN() > - alloc_workqueue() is called without WQ_PERCPU nor WQ_UNBOUND > - alloc_workqueue() is called with both WQ_PERCPU and WQ_UNBOUND > > Signed-off-by: Marco Crivellari Reviewed-by: Breno Leitao