From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B52193CF960 for ; Mon, 8 Jun 2026 16:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780937394; cv=none; b=MlPOr+T0CLgnfqwTIkU/fbqZPdqGrYcP45I/wZzlkltjUWreh+fKVb0pDTypZt8k/nu+Bad0WPoTCzWnthdTJDH0YWLQEFVdCsxLDXB0CqiJnfZATm9fDJfINKERsiIhraqcpmLvQ+6xCYCIf6TKNrrlyc8ozaYz6S4EMmTtvv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780937394; c=relaxed/simple; bh=jZvmmH1uKvNZYOfEfT6p1tDpG6SsK3RrxXYTj7zVMOM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K/RfIFEuFhH67mgpmm/um5rlildslhbqoyJgIf/zHMPTMqIkfVCjn1fGW9wKLnYir7vclurNIwiKSs5hrr+HZawFMKVaXfFwKuYEpmBbaC78FjbIpB6984+J+kG01g/0uTMtd898jWoD8DFS7x2tFLqi9Zg//2MiuVH7Os6ygnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GDL4WCAF; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GDL4WCAF" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-137dd523634so7140794c88.1 for ; Mon, 08 Jun 2026 09:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780937393; x=1781542193; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uFNq16ybtpJLrH2YCQxzG3Y0AWxx7vbMDrUovLcXEC0=; b=GDL4WCAFvFK1SPJrcaFDzfkZxVNjJJkoxjdZBMEQfHLAhJ+N3hViph1mT5h4WsAH5X 3EiuetFTa3F3XEUq/dKQcNEebvA/Gnefr5brt/NFbCJwNrQjJ5mipiB4iuaQ+5xvgvUC mMD2sxajebXgkmqNe/M3hxVE2g4CXTDKpp0ALxhKTT3X/OQfn8z2V7NmY9vmOUsn1eyb 2up6f0X35SakB9E3ZGDE6Qg7G2V9DP7aH2Hntpo37GbUrd1UViObtNu61C1vQnm6FTv3 d/T6wnd1FZfSRAoYZTVWh/FpkdDN0/1FaCcCdxf5wiJSjldmgiOL3h9jbSGy1lv0lKFQ RHlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780937393; x=1781542193; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uFNq16ybtpJLrH2YCQxzG3Y0AWxx7vbMDrUovLcXEC0=; b=T/5vPqsroy4mMetdC4xOfL/KFhI/Rs3XAl/vPzxkNDwoM0BWwcJxUdhbY2CCSri8Do kVvw9OIBentmtPzPvWLjt+O5WmUEhHwj4v+qzblnr+ylMgVPBYJjI1DyeoAbRp3pPQfv tfZQxq7mPRKbgylikFHmvZwZSuaxVz1f65OS1vV8IAASaP1dkHqmb1IlZm+DOHrQiYMo FyJFdKesO9s1C/GiedZ2JHqCN1T015pVlJhPqUkQjwH79tzLCG/P04cV08UqlGJvvNJg u0GFSHKGDL+kMadjJvtzG/IPm5jCfLIzuzqScLvpbtqMZ56luo30zKlY4Q0erLURqTXY tDTA== X-Forwarded-Encrypted: i=1; AFNElJ+M1la1IpM7R84gtKygl7aiUNj6+MVRmQpSCzg0+V7R7GpqGHSpdh1vn198wgF3p/MHOA14ddH6+W86k94=@vger.kernel.org X-Gm-Message-State: AOJu0YywNe4TuQU+Bj7x44aOpdcXkovYVZt/0ueORpW9DtDP0foVu+fC OwyydaXKw/TcF5DZz3Fzd+vc0H4dG3r74EDh6X8EKZngTposz0fXH2eEcMzRyQ== X-Gm-Gg: Acq92OHryny8SuzWBnNmwbuoZl8QjEYHp38XX6QoaJiho994zv4GhCd07Ar7VNWAlP8 yJgM04/269zhjeOS2eB28ZWEwzGRRWb9BZQ+zyKR6i5BozduCyEHjmV7dYRsExtNii/zkeisHsE +jKdOej0UJMchmOGWefyrEwJlMijb9aUsV0OZUnX2KK/zdOyh49IbrUutgXINdXzhQzwFuW66SJ WxKPOotgGpgJmJDihHxsblZ+XWmjRao3stqxmoOXwbKAQmgYTVHceSAm58rPgDlvDuk4D7Nzqhl ZLnYtQVj2H0smLrAsXlFLtqJAIRyzPIPbi4f4obG0RM9nQDvBCk1ysYKVS0v/N9L3GqyNsP0eLq Hlyv5h3UABfW5vv/W5QawQTXDACDNkMfazDMxpYaLezD4lM9wYXOaIiLZxNZbbb/nvxxE8lBIxv hROutnhPk90qgT12jwbpQXmo/mHsJg9W/vhccF4oCr7J0eBJZV8qKqyMfmlCJnk07GSAEbphk63 Oc= X-Received: by 2002:a05:7022:699d:b0:132:5d42:55ba with SMTP id a92af1059eb24-138066d8107mr7520419c88.16.1780937392714; Mon, 08 Jun 2026 09:49:52 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:355d:c69b:fe36:8969]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-137f5539432sm15053915c88.9.2026.06.08.09.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 09:49:51 -0700 (PDT) Date: Mon, 8 Jun 2026 09:49:49 -0700 From: Dmitry Torokhov To: Rosen Penev Cc: linux-input@vger.kernel.org, open list Subject: Re: [PATCH] input: ipaq-micro-keys: simplify allocation Message-ID: References: <20260608045041.4664-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608045041.4664-1-rosenp@gmail.com> Hi Rosen, On Sun, Jun 07, 2026 at 09:50:41PM -0700, Rosen Penev wrote: > Use a flexible array member to have a single allocation. Why does it have to be flexible? The size is known. > > Signed-off-by: Rosen Penev > --- > drivers/input/keyboard/ipaq-micro-keys.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/input/keyboard/ipaq-micro-keys.c b/drivers/input/keyboard/ipaq-micro-keys.c > index ca7ec054b1ce..0fc5b5dcdef5 100644 > --- a/drivers/input/keyboard/ipaq-micro-keys.c > +++ b/drivers/input/keyboard/ipaq-micro-keys.c > @@ -23,7 +23,7 @@ > struct ipaq_micro_keys { > struct ipaq_micro *micro; > struct input_dev *input; > - u16 *codes; > + u16 codes[]; > }; > > static const u16 micro_keycodes[] = { > @@ -90,10 +90,11 @@ static int micro_key_probe(struct platform_device *pdev) > int error; > int i; > > - keys = devm_kzalloc(&pdev->dev, sizeof(*keys), GFP_KERNEL); > + keys = devm_kzalloc(&pdev->dev, struct_size(keys, codes, ARRAY_SIZE(micro_keycodes)), GFP_KERNEL); Please keep to the limits for the kernel. 100 columns is acceptable when leads to better readability, but I prefer 80 when it makes sense. checkpatch.pl would have warned you. Thanks. -- Dmitry