All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Hofstaedtler <zeha@debian.org>
To: Karel Zak <kzak@redhat.com>, 1138789@bugs.debian.org
Cc: util-linux@vger.kernel.org,
	"Johannes Wüller" <johanneswueller@gmail.com>,
	debian-loongarch@lists.debian.org
Subject: Re: Bug#1138789: [PATCH] mkswap: use 64k pages in file-existing test
Date: Mon, 8 Jun 2026 20:44:03 +0200	[thread overview]
Message-ID: <aicNc4MZ3dfH7sDb@per.namespace.at> (raw)
In-Reply-To: <vwrh76odob5kr7mdtatgsuqrftfybisieyhb3dmgch5y4rdukq@6zmqirjnhewi>

On Mon, Jun 08, 2026 at 01:00:58PM +0200, Karel Zak wrote:
> On Thu, Jun 04, 2026 at 02:20:56PM +0200, Chris Hofstaedtler wrote:
> > Some systems run with kernels using page sizes other than 4K. The
> > file-existing test used a file of 10 pages at 4K. This would fail on
> > kernels with higher page sizes (here 16K) like this:
> > 
> >   mkswap: error: swap area needs to be at least 160 KiB
> > 
> > Use 10 * 64K pages, hopefully allowing all kernels with 4K, 16K, 64K
> > pages to pass the tests.
> > 
> > Noticed on Debian loong64 kernel 7.0.9+deb14-loong64, and on sparc64 and
> > alpha.
> > 
> > Bug: https://bugs.debian.org/1138789
> 
> It was already fixed by commit c5da6dcfe, which explicitly forces the
> page size to 4096 rather than extending the file size.

Ah, thank you! I've pulled this commit into our build.

Best,
Chris

      reply	other threads:[~2026-06-08 18:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <aiCHUJ8pmy_Atx2S@per.namespace.at>
2026-06-03 20:04 ` Bug#1138789: FTBFS on loong64: mkswap: error: swap area needs to be at least 160 KiB Chris Hofstaedtler
2026-06-04 12:20   ` [PATCH] mkswap: use 64k pages in file-existing test Chris Hofstaedtler
2026-06-08 11:00     ` Karel Zak
2026-06-08 18:44       ` Chris Hofstaedtler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aicNc4MZ3dfH7sDb@per.namespace.at \
    --to=zeha@debian.org \
    --cc=1138789@bugs.debian.org \
    --cc=debian-loongarch@lists.debian.org \
    --cc=johanneswueller@gmail.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.