Re: [PATCH net-next 08/15] netfilter: cttimeout: detach dataplane timeout policy and repurpose refcount

[Pablo Neira Ayuso <pablo@netfilter.org>]

Hi,

On Sun, Jun 07, 2026 at 11:49:47AM +0200, Pablo Neira Ayuso wrote:
> @@ -56,8 +73,14 @@ struct nf_conn_timeout *nf_ct_timeout_ext_add(struct nf_conn *ct,
>  #ifdef CONFIG_NF_CONNTRACK_TIMEOUT
>  	struct nf_conn_timeout *timeout_ext;
>  
> +	if (!timeout)
> +		return NULL;
> +
>  	timeout_ext = nf_ct_ext_add(ct, NF_CT_EXT_TIMEOUT, gfp);
> -	if (timeout_ext == NULL)
> +	if (!timeout_ext || timeout_ext->timeout)
                         ^^^^^^^^^^^^^^^^^^^^^^^
This check is useless, it is always going to be null.


There is also Julian Anastasov issue with documentation.

>> Documentation/networking/ipvs-sysctl.rst:76: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
   Documentation/networking/ipvs-sysctl.rst:76: ERROR: Unexpected section title or transition.

And regarding:

  netfilter: synproxy: fix unaligned memory access in timestamp adjustment

it is fixing the unaligned access, but inet_proto_csum_replace4()
wants 16-bit words starting from an even offset, sashiko reports that
this still would not work in uneven. I don't think this is worth, but
at least it is possible to add a note in the patch description.

I can post a v2 for this PR.