From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABCCE31E82A; Tue, 9 Jun 2026 06:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780984824; cv=none; b=Xi2XHWqjbQHfy3HtqwAYZ2O5xhH1sdQkOieLyA/mPqUUfywseDEBA/FrVE1yW9dFBLK1NpMSZywoKiyn6p0WKIYGfzcq8uv6zG35TGaZ2lVIDp41PnBea2ZEdtnHoFDFBMZyVUdSvy8LDOlxB4Qn8ru2ya8e8a+gKE1pRAKcThY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780984824; c=relaxed/simple; bh=Q/lK+sZt7GwPlBwwK69dLZf6j3mFRNG9lHSwsTuyARA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GzKoz5LDB5yyPAEqWRHvETtCqy3VGi19QMyLUflCXKm2vvVT16COsmdBXe8dEg65cM2mbjC4B/0dNn06A1MVuRjmuwdPAMo8A8SV8BEXRIp5ByvjwRV+UrodgZSL3XQCN+/WS6w7gVf293Bx9wAOMtMMN4A02teTTHLOMXJHiyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=drjmgkvJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="drjmgkvJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B93301F00893; Tue, 9 Jun 2026 06:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780984823; bh=6YEx4I/Sr7vXQXTyMNROcZn4c8xb3Zj7/Z8myQZrk0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=drjmgkvJM1vlu8xRrW9saDMhI097o+thAO1rGgg4CcKxIYNXkjoai4MOlL67qk0f9 ipMD7LKALWNGE3pnFM4Li6P0hW1G74wTbiEIu200rT1tGhc7O+aLWu5B3xIL9inqG+ pSiHYT0XfWc4Uv+fsybdjqw5adPkSoavFfeGW3+BZQq2oIl0e1/pNSRD+S4zdvOUQZ GtNTIUuvabK76FdLO5RRZ8hiyJ1yvx6VhcjBbZpBuR5u7OGu2ns8clegh+1sncccvc FsAY514AIekPUpsPIZDhSzDukdLHseCcHmixgB7JWXsJ4PYJ8WRh1Uz8CricT2PHTz 1RaRjL6MokItg== Date: Mon, 8 Jun 2026 23:00:21 -0700 From: Drew Fustini To: Icenowy Zheng Cc: Guo Ren , Fu Wei , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Greg Kroah-Hartman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Jisheng Zhang , Philipp Zabel , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, Icenowy Zheng , Han Gao , Yao Zi Subject: Re: [PATCH 02/12] clk: thead: th1520-ap: add support for MISC subsys clocks Message-ID: References: <20260507081710.4090814-1-zhengxingda@iscas.ac.cn> <20260507081710.4090814-3-zhengxingda@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260507081710.4090814-3-zhengxingda@iscas.ac.cn> On Thu, May 07, 2026 at 04:17:00PM +0800, Icenowy Zheng wrote: > The TH1520 SoC contains a MISC_SUBSYS clock controller, which allows > controlling of USB related clocks and MMC/SD controller AHB bus clocks. > > Add support for this clock controller, in order to enable USB support. > > Signed-off-by: Icenowy Zheng > --- > drivers/clk/thead/clk-th1520-ap.c | 64 +++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/drivers/clk/thead/clk-th1520-ap.c b/drivers/clk/thead/clk-th1520-ap.c > index 3a6847f1c950f..24f785f0b329a 100644 > --- a/drivers/clk/thead/clk-th1520-ap.c > +++ b/drivers/clk/thead/clk-th1520-ap.c [...] > @@ -1609,6 +1663,12 @@ static int th1520_clk_probe(struct platform_device *pdev) > return ret; > } > > + if (plat_data == &th1520_ap_platdata) { > + ret = devm_clk_hw_register(dev, &usb_suspend_div_clk.hw); > + if (ret) > + return ret; > + } Should usb_suspend_div_clk.hw instead be registered under 'if (plat_data == &th1520_ap_platdata)'? Thanks, Drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D53F8CD8CAD for ; Tue, 9 Jun 2026 06:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7D8weQMUSp6ubSp1xQvFIOSDGBPg8mc2ibRbY37oF6o=; b=24/U92rar70U+R yYI9bYcoBuyTWz2mC6n5eM7nis+zLFOSMkVkGK53RCT3HVxFW+AwjFgF6HqCfKOz5buzmU6La2agp o7kT8/X+uODiUn3+FGDsaCSf3xQzX0pgMs9p6eIGvzG2qW6iwk6cXsv+/0FHJ1qLlCV3FzXiuF/t7 eHdMe2LiX8uiX2z+BoU0/YEJ0SwtoDn+JlrWqc7t8p+iYc2X7cA7OGkE31Kt3JvkflfZaoXRlGWK3 tx5TqrwKBiFPBbfmnCwyo8j2wFGzWMIC50rXBJLrCD9TY7Cl9wz4BwK9uTmBBxT+CCVBgT3vUy8C2 y6PNfYOvxwix9hWvpJSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWpVi-00000004mAy-0rnD; Tue, 09 Jun 2026 06:00:26 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWpVg-00000004mAn-0qcK; Tue, 09 Jun 2026 06:00:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5B65A44073; Tue, 9 Jun 2026 06:00:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B93301F00893; Tue, 9 Jun 2026 06:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780984823; bh=6YEx4I/Sr7vXQXTyMNROcZn4c8xb3Zj7/Z8myQZrk0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=drjmgkvJM1vlu8xRrW9saDMhI097o+thAO1rGgg4CcKxIYNXkjoai4MOlL67qk0f9 ipMD7LKALWNGE3pnFM4Li6P0hW1G74wTbiEIu200rT1tGhc7O+aLWu5B3xIL9inqG+ pSiHYT0XfWc4Uv+fsybdjqw5adPkSoavFfeGW3+BZQq2oIl0e1/pNSRD+S4zdvOUQZ GtNTIUuvabK76FdLO5RRZ8hiyJ1yvx6VhcjBbZpBuR5u7OGu2ns8clegh+1sncccvc FsAY514AIekPUpsPIZDhSzDukdLHseCcHmixgB7JWXsJ4PYJ8WRh1Uz8CricT2PHTz 1RaRjL6MokItg== Date: Mon, 8 Jun 2026 23:00:21 -0700 From: Drew Fustini To: Icenowy Zheng Cc: Guo Ren , Fu Wei , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Greg Kroah-Hartman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Jisheng Zhang , Philipp Zabel , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, Icenowy Zheng , Han Gao , Yao Zi Subject: Re: [PATCH 02/12] clk: thead: th1520-ap: add support for MISC subsys clocks Message-ID: References: <20260507081710.4090814-1-zhengxingda@iscas.ac.cn> <20260507081710.4090814-3-zhengxingda@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260507081710.4090814-3-zhengxingda@iscas.ac.cn> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2026 at 04:17:00PM +0800, Icenowy Zheng wrote: > The TH1520 SoC contains a MISC_SUBSYS clock controller, which allows > controlling of USB related clocks and MMC/SD controller AHB bus clocks. > > Add support for this clock controller, in order to enable USB support. > > Signed-off-by: Icenowy Zheng > --- > drivers/clk/thead/clk-th1520-ap.c | 64 +++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/drivers/clk/thead/clk-th1520-ap.c b/drivers/clk/thead/clk-th1520-ap.c > index 3a6847f1c950f..24f785f0b329a 100644 > --- a/drivers/clk/thead/clk-th1520-ap.c > +++ b/drivers/clk/thead/clk-th1520-ap.c [...] > @@ -1609,6 +1663,12 @@ static int th1520_clk_probe(struct platform_device *pdev) > return ret; > } > > + if (plat_data == &th1520_ap_platdata) { > + ret = devm_clk_hw_register(dev, &usb_suspend_div_clk.hw); > + if (ret) > + return ret; > + } Should usb_suspend_div_clk.hw instead be registered under 'if (plat_data == &th1520_ap_platdata)'? Thanks, Drew -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E04C0CD8CAD for ; Tue, 9 Jun 2026 06:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MMaYk9MFEpwHL7+l061yyRTDB1NQyUx/iWGX5Wgf2TE=; b=ILN6WlCXBbiIHE BtEcLS0LRSVbxQP8gIttF6mqBbBOwcQIO7pu43WZKKm3cE93PS2De2mG4eotfPBB0ZHC3qGbeWDrE L/PUNdt3XXbbNiKDn/GqQWN7QZm56C2q7TnKDfFkE+EPlMlG6Jb2OjgJqy9WGITLqF0zf/v3OLKzl vo8oBhZbUwGtAbmRRInxdl2XjIu4Ea1rSWpD94e0H7GHGuwUYmkrgtlERLPvuwVWzrRa2rlhRgLu/ +hqQr/xGdEkhoB7fTaqyHJfZoFjCVwOKIonyDtTSbCA/AelFDCF7ir3pzZEN3I3gljkHXERvJ9zVq ayOtMRaAeB6eQbEMwQ4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWpVi-00000004mB2-23K9; Tue, 09 Jun 2026 06:00:26 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWpVg-00000004mAn-0qcK; Tue, 09 Jun 2026 06:00:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5B65A44073; Tue, 9 Jun 2026 06:00:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B93301F00893; Tue, 9 Jun 2026 06:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780984823; bh=6YEx4I/Sr7vXQXTyMNROcZn4c8xb3Zj7/Z8myQZrk0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=drjmgkvJM1vlu8xRrW9saDMhI097o+thAO1rGgg4CcKxIYNXkjoai4MOlL67qk0f9 ipMD7LKALWNGE3pnFM4Li6P0hW1G74wTbiEIu200rT1tGhc7O+aLWu5B3xIL9inqG+ pSiHYT0XfWc4Uv+fsybdjqw5adPkSoavFfeGW3+BZQq2oIl0e1/pNSRD+S4zdvOUQZ GtNTIUuvabK76FdLO5RRZ8hiyJ1yvx6VhcjBbZpBuR5u7OGu2ns8clegh+1sncccvc FsAY514AIekPUpsPIZDhSzDukdLHseCcHmixgB7JWXsJ4PYJ8WRh1Uz8CricT2PHTz 1RaRjL6MokItg== Date: Mon, 8 Jun 2026 23:00:21 -0700 From: Drew Fustini To: Icenowy Zheng Subject: Re: [PATCH 02/12] clk: thead: th1520-ap: add support for MISC subsys clocks Message-ID: References: <20260507081710.4090814-1-zhengxingda@iscas.ac.cn> <20260507081710.4090814-3-zhengxingda@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260507081710.4090814-3-zhengxingda@iscas.ac.cn> X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , Guo Ren , Jisheng Zhang , linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Rob Herring , Alexandre Ghiti , devicetree@vger.kernel.org, Conor Dooley , Albert Ou , Yao Zi , linux-gpio@vger.kernel.org, Paul Walmsley , Neil Armstrong , Stephen Boyd , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Palmer Dabbelt , Philipp Zabel , Han Gao , Krzysztof Kozlowski , Fu Wei Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2026 at 04:17:00PM +0800, Icenowy Zheng wrote: > The TH1520 SoC contains a MISC_SUBSYS clock controller, which allows > controlling of USB related clocks and MMC/SD controller AHB bus clocks. > > Add support for this clock controller, in order to enable USB support. > > Signed-off-by: Icenowy Zheng > --- > drivers/clk/thead/clk-th1520-ap.c | 64 +++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/drivers/clk/thead/clk-th1520-ap.c b/drivers/clk/thead/clk-th1520-ap.c > index 3a6847f1c950f..24f785f0b329a 100644 > --- a/drivers/clk/thead/clk-th1520-ap.c > +++ b/drivers/clk/thead/clk-th1520-ap.c [...] > @@ -1609,6 +1663,12 @@ static int th1520_clk_probe(struct platform_device *pdev) > return ret; > } > > + if (plat_data == &th1520_ap_platdata) { > + ret = devm_clk_hw_register(dev, &usb_suspend_div_clk.hw); > + if (ret) > + return ret; > + } Should usb_suspend_div_clk.hw instead be registered under 'if (plat_data == &th1520_ap_platdata)'? Thanks, Drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv