From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3303ECD8CA4 for ; Tue, 9 Jun 2026 09:14:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wWsXX-0006nF-OF; Tue, 09 Jun 2026 05:14:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wWsXU-0006mo-8U for qemu-devel@nongnu.org; Tue, 09 Jun 2026 05:14:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wWsXS-00025x-EX for qemu-devel@nongnu.org; Tue, 09 Jun 2026 05:14:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780996464; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=80Mbl0vxjpEpAXTPhlU+Jl9lITfoge7XnA9WBo4UBk0=; b=jHk024xvTMtmsaYdQ+9h8cZI1fxDmly8HeiIxdEeiTZgpgmUFNv1exoRdoKdQrPu8qSh0d rwhlPcVAmqorKRY8CJq91Eae2pF+2XEO1kJgGZkgqc7615nKN3pHvf9B4w23fyhO6oxJM3 47w7GpxWDIfFjCzW1mEtvtTZaV347LQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-n08Sm4idO9C2Oj-lvZiIdg-1; Tue, 09 Jun 2026 05:14:21 -0400 X-MC-Unique: n08Sm4idO9C2Oj-lvZiIdg-1 X-Mimecast-MFC-AGG-ID: n08Sm4idO9C2Oj-lvZiIdg_1780996459 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9CD8C180AB0A; Tue, 9 Jun 2026 09:14:18 +0000 (UTC) Received: from redhat.com (unknown [10.44.49.219]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 38ABC3008B36; Tue, 9 Jun 2026 09:14:13 +0000 (UTC) Date: Tue, 9 Jun 2026 10:14:11 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Naveen N Rao (AMD)" Cc: Paolo Bonzini , qemu-devel , Eduardo Habkost , Eric Blake , Markus Armbruster , Marcelo Tosatti , Zhao Liu , Nikunj A Dadhania , Tom Lendacky , Michael Roth , Roy Hopkins , Srikanth Aithal , Kim Phillips , Joerg Roedel Subject: Re: [PATCH v4 2/9] target/i386: SEV: Ensure SEV features are only set through qemu cli or IGVM Message-ID: References: <6939de99f13d7170af68b74e711eb9f03f32f682.1779281646.git.naveen@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6939de99f13d7170af68b74e711eb9f03f32f682.1779281646.git.naveen@kernel.org> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, May 20, 2026 at 06:57:55PM +0530, Naveen N Rao (AMD) wrote: > In preparation for qemu being able to set SEV features through the cli, > add a check to ensure that SEV features are not also set if using IGVM > files. > > Reviewed-by: Tom Lendacky > Signed-off-by: Naveen N Rao (AMD) > --- > target/i386/sev.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index 22c350fe14b7..641a295c42b7 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -1908,6 +1908,16 @@ static int sev_common_kvm_init(ConfidentialGuestSupport *cgs, Error **errp) > * as SEV_STATE_UNINIT. > */ > if (x86machine->igvm) { > + /* > + * Test only the user-set SEV features by masking out > + * SVM_SEV_FEAT_SNP_ACTIVE which is set by default. > + */ > + if (sev_common->sev_features & ~SVM_SEV_FEAT_SNP_ACTIVE) { > + error_setg(errp, > + "%s: SEV features can't be specified when using IGVM files", > + __func__); IMHO, including __func__ in error messages is redundant / undesirable. The error msg alone should be sufficient to diagnose problems.Perhaps we should include the actual feature values though "SEV features 0x%x can't be specified when using IGVM files", sev_common->sev_features & ~SVM_SEV_FEAT_SNP_ACTIVE); this case, however, you should report which features are not permitted > + return -1; > + } > if (IGVM_CFG_GET_CLASS(x86machine->igvm) > ->process(x86machine->igvm, machine, true, errp) == -1) { > return -1; > -- > 2.54.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|