From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20A06CD8CA4 for ; Tue, 9 Jun 2026 13:25:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wWwSB-0005iU-3C; Tue, 09 Jun 2026 09:25:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wWwS9-0005i8-Cx for qemu-devel@nongnu.org; Tue, 09 Jun 2026 09:25:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wWwS7-0003KW-Gb for qemu-devel@nongnu.org; Tue, 09 Jun 2026 09:25:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781011509; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TXYiZF3sWwln94XmffATwkbolA912h3VY8ZsteHXvRU=; b=SviTFAOgVWg9mJQwUmlumOSZpOhyzLdHTkLUY/LK37cYsNH752cwDLqDdWllPOzR8GEDFO YAo/MiLx44MKsfrNmKRD/d9j4bFlFdtr1HE5eBMtTfEtA0e+1J/hwzDtzROf8DhcWdYBHF uYpmnBYenugYYMQTVDCHd3IDzZWjWto= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-xPqZY3RGO9Gpvrg5ThY4iA-1; Tue, 09 Jun 2026 09:25:07 -0400 X-MC-Unique: xPqZY3RGO9Gpvrg5ThY4iA-1 X-Mimecast-MFC-AGG-ID: xPqZY3RGO9Gpvrg5ThY4iA_1781011507 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 02630195605F for ; Tue, 9 Jun 2026 13:25:07 +0000 (UTC) Received: from redhat.com (unknown [10.44.49.219]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D1D9D6E; Tue, 9 Jun 2026 13:25:04 +0000 (UTC) Date: Tue, 9 Jun 2026 14:25:01 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Luigi Leonardi Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Stefano Garzarella , Ani Sinha , Paolo Bonzini Subject: Re: [PATCH] igvm: populate errp in stub functions Message-ID: References: <20260609-igvm_stubs-v1-1-5f39d6e0db4a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260609-igvm_stubs-v1-1-5f39d6e0db4a@redhat.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jun 09, 2026 at 03:20:14PM +0200, Luigi Leonardi wrote: > Use error_setg() to report that IGVM is not available, matching > the pattern used by other stubs in the tree. > > Suggested-by: Stefano Garzarella > Signed-off-by: Luigi Leonardi > --- > stubs/igvm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/stubs/igvm.c b/stubs/igvm.c > index 9e9f683fc9..dfb85eb548 100644 > --- a/stubs/igvm.c > +++ b/stubs/igvm.c > @@ -17,15 +17,18 @@ int qigvm_x86_get_mem_map_entry(int index, > ConfidentialGuestMemoryMapEntry *entry, > Error **errp) > { > + error_setg(errp, "IGVM not supported on this platform"); > return -1; > } > > int qigvm_x86_set_vp_context(void *data, int index, Error **errp) > { > + error_setg(errp, "IGVM not supported on this platform"); > return -1; > } > > int qigvm_directive_madt(QIgvm *ctx, const uint8_t *header_data, Error **errp) > { > + error_setg(errp, "IGVM not supported on this platform"); > return -1; > } This is not wrong per-se, so on that basis Reviewed-by: Daniel P. Berrangé but are any of these stubs actually reachable when IGVM is not enabled in the build ? Usually with stubs we find that one or two methods are the primary entrypoints which must return an error, at which point everything else becomes unreachable. The latter cases can just be g_assert_not_reached() as a sanity check that some unexpected codepath isn't calling in without checking status earlier. Those would thus would not need error_setg, nor a 'return' statement. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|