From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBF3E343892 for ; Tue, 9 Jun 2026 14:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781014559; cv=none; b=LCSHpXWpGZnbtjsTCluY90A42RHTRHl/iW+i32BLVPxQ5NGqwPRUPL42aC1b+05222SEYZrzojH2QJnyIghKQPf+99xMP2C0ksCwrqb684Lbmshro4yBfcTJ5ywPrhcVtlgNkxV8e2e5vcHo+ixB+9uFqkwpa4I+GVELoRppzMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781014559; c=relaxed/simple; bh=9CIJb88IKWbWT6IEhObvHO6UhRZhTYKH7PhKE6eSb3c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=htCrhqKy29c6njstQrhcgxNbERsDu6q7bz+RZlUWZGv5nA/PjYQj0RhopYbP+ikVUHlMtoobx/ql7Jaqi2HB8UeKZUqnoqIMuk0ZlPXHefk/DI12tdgTXiqQ1J+w7HonQqkpQiRwaoBIUJRwkdFRsv8oesMIn4ptts+Ek1Bhfx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CDlsObfR; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CDlsObfR" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-7e87602f26aso62559837b3.1 for ; Tue, 09 Jun 2026 07:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781014557; x=1781619357; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O1hcL5eJx6MWJvlu7fWXmuLzT2QrGx87Ta518j+s/Zc=; b=CDlsObfRA6zeJVPR80IO2VEbnyTpPoQjQ7aA0T+iMmbWqJSzex/G/klZorHDEzj78n cV2CSea2JYpgTxXYpwzPIQcvCXmM85NaIIrjygGtVKOEEgrNhSNZNAx6+lpZkBHsy865 Hslu1f9AiMIptd4if0cOgWqTF5uVRZXCbTJtKh7QiLugzQ89Nnop7mPRoDOYmB91O2dE I7O4ru34uXJIXoMRh4EI2jLmmcXT+qcBTICoXVwkxbXCn7iYGEk0m7kwE2tHdogr/j+z MTr7Zx4jvQHPr0/4y5qB6TxXhKMNULQhlfwn0dozxeQXsvS2U5PaQx8VnQ87TNZxJfUw w85w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781014557; x=1781619357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O1hcL5eJx6MWJvlu7fWXmuLzT2QrGx87Ta518j+s/Zc=; b=cCWR/FIrFemmll0KtMWJNAYl3TK26WFJTTf36AS0tKB3FVxaYK9v1XQ15a8JonSKxc vTEuoHAenm4SaDR/n/aD41PoU3X4Q4LfXzozh8R3JSSuQ6BQNEjEUkL/vf6f459JGo1+ /mrUQlGdOFAnolKG7xSqCz2+w3kJ4IuV3HuTVEIlZdUVqF2F3JR36ZxX1tdX8V3SEF93 h1ZabjdbWKR0kTjKNMfyCYC4dncKzcJsAV77dZvpEfMq/4H4nFkLRWWyxK2G3vIHf4DA LCznpofzV+0Ue5MDEX0wuY8R8PYGWRAYg3FxvmVhFMFuyCDGXa9oNZBoWa/mIy+I3MXr ZGEg== X-Forwarded-Encrypted: i=1; AFNElJ8oX5ZM/5qgPS4aPq5QKqajdNBJLDLBcBa2SmyiVljysl1CArreeoZc4U98oA9bb830EArhG4U4I0EEa/U=@vger.kernel.org X-Gm-Message-State: AOJu0YxjZddMi1x6WYoyNF1PTTgZu1Hyx8CWHNNXTBAvKgHo/DzzHr5F hA9XJ5V/Oi1+r0NhQh6CoiyH3DRdeUmmflb8OGWukcjTFCi9AB0QRRtM X-Gm-Gg: Acq92OHTlgjowqS3ZU/xt/Lf43DPeN6kdguzpm0YdW8Hrcil+sCj+FbVSaCsq/IczhG bqkMiucqvnpgBM/5GSLIpFKRBWPaSdoGFG3Zf98+DOTptPTcR/uVmOm243p9qYkTs4gH+olvBdT 3HFueqIzO4A3PKvUww2LOatapHIIFIKTD5NMKdBSafcbaSVUKspyBRLME0gN2ddsDgG9YbNLEIC abMn5Ly7TAdl1PFRoZjgsw+OGvjrl4+hvVHnl3sVBf0QnJ5OjpiHAD7R8hNR7NRv7ZZ766YrgAX lT2pV1kSjTftO3K9vetmW63mtAhRX9H5fb7wyx1rhuAUXsfbE9HqIfv1RyMLLDHAWsgFnCG6HBg +KLevv6HrUyebrNX20vHX1iSUgzc4K/ROt3DxORZ6oiWy3eR+mW/TZvqe1M2kQAIClYUe0l0Bqm 67jRGVBrVlyFVU8NGV4aqX X-Received: by 2002:a05:690c:c641:b0:7ef:9fd9:db07 with SMTP id 00721157ae682-7ef9fd9ec08mr72816327b3.12.1781014556604; Tue, 09 Jun 2026 07:15:56 -0700 (PDT) Received: from geday ([2804:7f2:800b:dd29::dead:c001]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea2148cc98sm96519887b3.13.2026.06.09.07.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 07:15:55 -0700 (PDT) Date: Tue, 9 Jun 2026 11:15:51 -0300 From: Geraldo Nascimento To: Denis Batishchev Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a Message-ID: References: <20260604131518.45993-1-ii343hbka@gmail.com> <20260609135607.3960625-1-ii343hbka@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260609135607.3960625-1-ii343hbka@gmail.com> Hi Denis, On Tue, Jun 09, 2026 at 03:56:07PM +0200, Denis Batishchev wrote: > The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. > Without a quirk no fixup is selected and the mic-mute LED stays off. > It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the > already-supported 14" variant (SSID 103c:8dfb), so add it. What is your exact variant of this hardware? Also please refrain from sending V2 in response to V1: it makes patches harder to track. > > Signed-off-by: Denis Batishchev > Cc: > --- > v2: reword commit message as was required by Takashi Iwai > > sound/hda/codecs/realtek/alc269.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c > index 78a865709635..8eebf91595d3 100644 > --- a/sound/hda/codecs/realtek/alc269.c > +++ b/sound/hda/codecs/realtek/alc269.c > @@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > + SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), The description string of the quirk seems copy-pasted. Are you sure you have the 14" variant? Thanks, Geraldo Nascimento > SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED), > -- > 2.53.0 > >