All of lore.kernel.org
 help / color / mirror / Atom feed
From: Horst Birthelmer <horst@birthelmer.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: bernd@bsbernd.com, Joanne Koong <joannelkoong@gmail.com>,
	 Luis Henriques <luis@igalia.com>, Gang He <dchg2000@gmail.com>,
	fuse-devel@lists.linux.dev,  Bernd Schubert <bschubert@ddn.com>
Subject: Re: Re: [PATCH v5 0/7] fuse: {io-uring} Allow to reduce the number of queues and request distribution
Date: Wed, 10 Jun 2026 13:51:52 +0200	[thread overview]
Message-ID: <ailOn2SPjhUVV3e5@fedora> (raw)
In-Reply-To: <CAJfpegty63HGGNR7Vm0mpfs+PW0-r-hJDSASsRMk3JwsHTyrvw@mail.gmail.com>


On Wed, Jun 10, 2026 at 12:51:13PM +0200, Miklos Szeredi wrote:
> On Fri, 29 May 2026 at 00:55, Bernd Schubert via B4 Relay
> <devnull+bernd.bsbernd.com@kernel.org> wrote:
> >
> > This adds bitmaps that track which queues are registered and which queues
> > do not have queued requests.
> > These bitmaps are then used to map from request core to queue
> > and also allow load distribution. NUMA affinity is handled and
> > fuse client/server protocol does not need changes, all is handled
> > in fuse client internally.
> >
> > Signed-off-by: Bernd Schubert <bschubert@ddn.com>
> 
> Joanne, your RvB is on the first few patches but not the rest.
> 
> I'd be more happy with a fully reviewed patchset, since this falls
> outside my current expertise.
> 
> Related question: do we want to request automatic reviews by sashiko
> on fuse-devel?  I do see dangers in relying too much on AI reviews
> since it makes us lazy and complacent, otoh sashiko does seem to
> provide useful feedback.
> 
> What do you all think?

Hi Miklos,

regarding the automatic reviews, I would like those, even though AI
most of the time cannot really grasp 'the idea' and tell us if the 
intention of the approach is wrong in the first place (think of
my intention to limit dentry cache a couple of weeks ago)
but it would find obvious or overtly visible mistakes.
It only makes us complacent if we let it.

> 
> Thanks,
> Miklos
> 

Thanks,
Horst

  reply	other threads:[~2026-06-10 11:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28 22:55 [PATCH v5 0/7] fuse: {io-uring} Allow to reduce the number of queues and request distribution Bernd Schubert via B4 Relay
2026-05-28 22:55 ` Bernd Schubert
2026-05-28 22:55 ` [PATCH v5 1/7] fuse: {io-uring} Add queue length counters Bernd Schubert via B4 Relay
2026-05-28 22:55   ` Bernd Schubert
2026-05-28 22:55 ` [PATCH v5 2/7] fuse: {io-uring} Rename ring->nr_queues to max_nr_queues Bernd Schubert via B4 Relay
2026-05-28 22:55   ` Bernd Schubert
2026-05-28 22:55 ` [PATCH v5 3/7] fuse: {io-uring} Use bitmaps to track registered queues Bernd Schubert via B4 Relay
2026-05-28 22:55   ` Bernd Schubert
2026-05-28 22:55 ` [PATCH v5 4/7] fuse: {io-uring} Allow reduced number of ring queues Bernd Schubert via B4 Relay
2026-05-28 22:55   ` Bernd Schubert
2026-05-28 22:55 ` [PATCH v5 5/7] fuse: {io-uring} Queue background requests on a different core Bernd Schubert via B4 Relay
2026-05-28 22:55   ` Bernd Schubert
2026-05-28 22:55 ` [PATCH v5 6/7] fuse: {io-uring} Add retry attempts for numa local queues for load distribution Bernd Schubert via B4 Relay
2026-05-28 22:55   ` Bernd Schubert
2026-05-28 22:55 ` [PATCH v5 7/7] fuse: {io-uring} Prefer the current core over mapping Bernd Schubert via B4 Relay
2026-05-28 22:55   ` Bernd Schubert
2026-06-10 10:51 ` [PATCH v5 0/7] fuse: {io-uring} Allow to reduce the number of queues and request distribution Miklos Szeredi
2026-06-10 11:51   ` Horst Birthelmer [this message]
2026-06-10 16:33   ` Amir Goldstein
2026-06-11  2:15     ` Joanne Koong
2026-06-11  2:13   ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ailOn2SPjhUVV3e5@fedora \
    --to=horst@birthelmer.de \
    --cc=bernd@bsbernd.com \
    --cc=bschubert@ddn.com \
    --cc=dchg2000@gmail.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=joannelkoong@gmail.com \
    --cc=luis@igalia.com \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.