From: Keith Busch <kbusch@kernel.org>
To: Carlos Maiolino <cem@kernel.org>
Cc: brauner@kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] iomap: enforce DIO alignment check in iomap]
Date: Wed, 10 Jun 2026 09:37:17 -0600 [thread overview]
Message-ID: <aimErft1NoW-4Map@kbusch-mbp> (raw)
In-Reply-To: <aimCIEpCwUUyoORf@nidhogg.toxiclabs.cc>
On Wed, Jun 10, 2026 at 05:27:42PM +0200, Carlos Maiolino wrote:
> The DIO alignment check has been lifted from iomap layer to rely on the
> block layer to enforce proper alignment when issuing direct IO
> operations. This though, depending on the IO size and buffer address
> passed to the IO operation may lead to user-visible behavior change.
>
> This has been caught initially by LTP test diotest4 running on
> PPC architecture, where the test fails because a read() operation
> with a supposedly misaligned buffer succeeds instead of an expected
> -EINVAL.
It's not supposed to matter where in the stack we determined this be an
invalid request: it should still fail if it's misaligned. Could you
clarify how this is succeeding?
next prev parent reply other threads:[~2026-06-10 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 15:27 [PATCH] iomap: enforce DIO alignment check in iomap] Carlos Maiolino
2026-06-10 15:37 ` Keith Busch [this message]
2026-06-10 16:58 ` Carlos Maiolino
2026-06-10 17:14 ` Keith Busch
2026-06-10 18:19 ` Carlos Maiolino
2026-06-10 19:54 ` Keith Busch
2026-06-11 2:49 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aimErft1NoW-4Map@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.