From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BFF8CD8CB9 for ; Wed, 10 Jun 2026 16:22:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXLeq-0007VU-V0; Wed, 10 Jun 2026 12:20:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXLep-0007Nv-Ei for qemu-arm@nongnu.org; Wed, 10 Jun 2026 12:19:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXLen-0002pS-8j for qemu-arm@nongnu.org; Wed, 10 Jun 2026 12:19:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781108396; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=KPxM7JPrYnyM6ediqrKrMvZ91huDBa+SM17tsnloIR0=; b=GbbPKs+BWPYvdwsNp1xt1Z+dIlM6L7NEV5ixMQx60vSty8bqo3cPdCbHSOnXMwgcFw3j2P O6g2hbqF/nqaVetMdOkrWNPfbslFEiMjcZTRS7FfDGobavjwP88QDNGsOcuy/ofywOlsvQ R9M0DUlPcmPSb9d1YifVPREIg2Qdx6o= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-ZIzlEbrbMomlf60wXH1_BA-1; Wed, 10 Jun 2026 12:19:51 -0400 X-MC-Unique: ZIzlEbrbMomlf60wXH1_BA-1 X-Mimecast-MFC-AGG-ID: ZIzlEbrbMomlf60wXH1_BA_1781108389 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 72622187BE3C; Wed, 10 Jun 2026 16:19:48 +0000 (UTC) Received: from redhat.com (unknown [10.44.50.112]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97C8D1800591; Wed, 10 Jun 2026 16:19:41 +0000 (UTC) Date: Wed, 10 Jun 2026 17:19:38 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Xu Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Fabiano Rosas , Vladimir Sementsov-Ogievskiy , Peter Maydell , "Dr . David Alan Gilbert" , Eric Blake , Akihiko Odaki , Paolo Bonzini , Kevin Wolf , Sana Sharma , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Juraj Marcin , qemu-rust@nongnu.org, Markus Armbruster , Mark Cave-Ayland Subject: Re: [PATCH v2 09/10] qom: Allow default values for instance properties Message-ID: References: <20260609172514.2037645-1-peterx@redhat.com> <20260609172514.2037645-10-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20260609172514.2037645-10-peterx@redhat.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-MFC-PROC-ID: 7hTSsXPjMNZScYUchIqngIYwiuJNeaj_PXk1E5ovfTs_1781108389 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Tue, Jun 09, 2026 at 01:25:13PM -0400, Peter Xu wrote: > ObjectProperty allows default value settings via proper setup of > prop->init() and prop->defval. It currently is only supported in class > properties, not instance properties. > > However, since QOM allows class and instance properties, it should also > allow instance to add properties during instance_init() and allow the > default values to be applied properly for this instance only. > > Add the logic. It will be useful for all kinds of pointer based properties > because pointers are normally not accessble in a class but only when an > instance is available. This will be able to achieve similar function as > what qdev properties have (which works by remembering offsets within a > structure instead). Again, I don't think we should be adding more features to the instance properties concept, as new code should use class level properties. > > Signed-off-by: Peter Xu > --- > qom/object.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|