Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Jacopo Mondi <jacopo.mondi@ideasonboard.com>]

On Wed, Jun 10, 2026 at 06:35:36PM +0200, Ricardo Ribalda wrote:
> Hi Jacopo
>
> On Wed, 10 Jun 2026 at 18:30, Jacopo Mondi
> <jacopo.mondi@ideasonboard.com> wrote:
> >
> > Hi Ricardo
> >
> > On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> > > The variable has been previously removed but not its kerneldoc.
> > >
> > > Also remove the leftover reference to state in the description of qlock.
> > >
> > > This patch fixes the following warning:
> > >
> > > Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> > > Excess struct member 'state' description in 'rzg2l_cru_dev'
> >
> > upsie
> >
> > indeed!
> >
> > >
> > > Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
> >
> > My only question is if this qualifies for stable or not...
> > Honestly, I would drop the Fixes tag here
>
> Yeah, I am not even sure myself
>
> On one hand, it might help other CIs down there have cleaner logs, it
> is very low risk, and I doubt that it will have any conflicts.
> On the other, what real user will benefit from this backport?
>
> I wrote in the cover that this can be dropped. I'd let more clever
> people decide :P
>

From Documentation/process/stable-kernel-rules.rst:

- It must either fix a real bug that bothers people or just add a device ID.
  To elaborate on the former:

  - It fixes a problem like an oops, a hang, data corruption, a real security
    issue, a hardware quirk, a build error (but not for things marked
    CONFIG_BROKEN), or some "oh, that's not good" issue.
  - Serious issues as reported by a user of a distribution kernel may also
    be considered if they fix a notable performance or interactivity issue.
    As these fixes are not as obvious and have a higher risk of a subtle
    regression they should only be submitted by a distribution kernel
    maintainer and include an addendum linking to a bugzilla entry if it
    exists and additional information on the user-visible impact.
  - No "This could be a problem..." type of things like a "theoretical race
    condition", unless an explanation of how the bug can be exploited is also
    provided.
  - No "trivial" fixes without benefit for users (spelling changes, whitespace
    cleanups, etc).

Are Documentation warnings considered "build errors" ?

> >
> > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> >
> > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> >
> > > ---
> > >  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > > index 5bf334e173d2..b426bc7898bf 100644
> > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > > @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
> > >   * @scratch_phys:    physical address of the scratch buffer
> > >   *
> > >   * @qlock:           protects @queue_buf, @buf_list, @sequence
> > > - *                   @state
> > >   * @queue_buf:               Keeps track of buffers given to HW slot
> > >   * @buf_list:                list of queued buffers
> > >   * @sequence:                V4L2 buffers sequence number
> > > - * @state:           keeps track of operation state
> > >   *
> > >   * @format:          active V4L2 pixel format
> > >   */
> > >
> > > --
> > > 2.54.0.1099.g489fc7bff1-goog
> > >
>
>
>
> --
> Ricardo Ribalda