From: Deborah Brouwer <deborah.brouwer@collabora.com>
To: Gary Guo <gary@garyguo.net>
Cc: Daniel Almeida <daniel.almeida@collabora.com>,
Alice Ryhl <aliceryhl@google.com>,
Danilo Krummrich <dakr@kernel.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Benno Lossin <lossin@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] drm/tyr: remove imports available from prelude
Date: Wed, 10 Jun 2026 09:45:43 -0700 [thread overview]
Message-ID: <aimUt9awGi-0cx_F@um790> (raw)
In-Reply-To: <20260610141359.1033755-1-gary@kernel.org>
On Wed, Jun 10, 2026 at 03:13:58PM +0100, Gary Guo wrote:
> From: Gary Guo <gary@garyguo.net>
>
> No functional changes intended.
>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> ---
> drivers/gpu/drm/tyr/regs.rs | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/tyr/regs.rs b/drivers/gpu/drm/tyr/regs.rs
> index 562023e5df2f..831357a8ef87 100644
> --- a/drivers/gpu/drm/tyr/regs.rs
> +++ b/drivers/gpu/drm/tyr/regs.rs
> @@ -48,17 +48,12 @@ pub(crate) fn read_u64_no_tearing(lo_read: impl Fn() -> u32, hi_read: impl Fn()
> /// These registers correspond to the GPU_CONTROL register page.
> /// They are involved in GPU configuration and control.
> pub(crate) mod gpu_control {
> - use core::convert::TryFrom;
> use kernel::{
> - error::{
> - code::EINVAL,
> - Error, //
> - },
> num::Bounded,
> + prelude::*,
> register,
> uapi, //
> };
> - use pin_init::Zeroable;
>
> register! {
> /// GPU identification register.
> @@ -964,14 +959,9 @@ pub(crate) mod mmu_control {
> ///
> /// This array contains 16 instances of the MMU_AS_CONTROL register page.
> pub(crate) mod mmu_as_control {
> - use core::convert::TryFrom;
> -
> use kernel::{
> - error::{
> - code::EINVAL,
> - Error, //
> - },
> num::Bounded,
> + prelude::*,
> register, //
> };
>
>
> base-commit: 7d570075805918f5ec33f03949c6a7c610397340
> --
> 2.54.0
>
Acked-by: Deborah Brouwer <deborah.brouwer@collabora.com>
next prev parent reply other threads:[~2026-06-10 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 14:13 [PATCH] drm/tyr: remove imports available from prelude Gary Guo
2026-06-10 16:45 ` Deborah Brouwer [this message]
2026-06-10 17:43 ` Onur Özkan
2026-06-10 17:45 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aimUt9awGi-0cx_F@um790 \
--to=deborah.brouwer@collabora.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.