All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Taniya Das <taniya.das@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Georgi Djakov <djakov@kernel.org>,
	Shawn Guo <shengchao.guo@oss.qualcomm.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 04/12] clk: qcom: gcc-mdm9607: Fix BIMC PLL definition
Date: Wed, 10 Jun 2026 19:58:10 +0200	[thread overview]
Message-ID: <aimlsgJssczxBGhQ@linaro.org> (raw)
In-Reply-To: <022fb465-df10-4d95-a05c-1ff8e59558c1@oss.qualcomm.com>

On Wed, Jun 10, 2026 at 10:43:12PM +0530, Taniya Das wrote:
> On 6/9/2026 7:44 PM, Stephan Gerhold wrote:
> > The gcc-mdm9607 driver was originally based on gcc-msm8916, but a closer
> > match nowadays is gcc-msm8909. Looking at the differences between
> > gcc-mdm9607 and gcc-msm8909, there is quite some confusion around the
> > definitions for the BIMC PLL.
> > 
> > It turns out the BIMC PLL on MDM9607 is actually an Alpha PLL just like on
> > MSM8909. We can vote for it using BIT(2), which explains why BIT(3) was
> > used for GPLL2.
> 
> BIMC PLL is never controlled from High Level OS (APSS). These are
> controlled by other subsystems and voting should be via the ICC for BW
> requirements.
> 

The driver doesn't really control the BIMC PLL here, the PLL is defined
with fixed/shared/read-only ops so it mostly just exists to model the
clock tree properly and have the clock rate readable for the PLL itself
and any downstream consumers.

There are multiple drivers that do it like this (e.g. gcc-msm8916,
gcc-msm8939), is there a reason why we should drop this?

Thanks,
Stephan

  reply	other threads:[~2026-06-10 17:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 14:14 [PATCH 00/12] clk: qcom: Assorted fixes for gcc-mdm9607 (and gcc-msm8916/39) Stephan Gerhold
2026-06-09 14:14 ` [PATCH 01/12] clk: qcom: gcc-msm8916: Fix enable_reg for gcc_blsp1_sleep_clk Stephan Gerhold
2026-06-10 13:40   ` Konrad Dybcio
2026-06-09 14:14 ` [PATCH 02/12] clk: qcom: gcc-msm8939: " Stephan Gerhold
2026-06-10 13:40   ` Konrad Dybcio
2026-06-09 14:14 ` [PATCH 03/12] clk: qcom: gcc-mdm9607: " Stephan Gerhold
2026-06-10 13:42   ` Konrad Dybcio
2026-06-09 14:14 ` [PATCH 04/12] clk: qcom: gcc-mdm9607: Fix BIMC PLL definition Stephan Gerhold
2026-06-10 13:46   ` Konrad Dybcio
2026-06-10 13:56     ` Stephan Gerhold
2026-06-10 17:13   ` Taniya Das
2026-06-10 17:58     ` Stephan Gerhold [this message]
2026-06-09 14:14 ` [PATCH 05/12] clk: qcom: gcc-mdm9607: Fix halt_reg for gcc_apss_axi_clk Stephan Gerhold
2026-06-10 13:43   ` Konrad Dybcio
2026-06-10 17:24   ` Taniya Das
2026-06-09 14:14 ` [PATCH 06/12] clk: qcom: gcc-mdm9607: Increase delay for USB PHY reset Stephan Gerhold
2026-06-10 13:46   ` Konrad Dybcio
2026-06-09 14:14 ` [PATCH 07/12] clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src Stephan Gerhold
2026-06-09 14:27   ` sashiko-bot
2026-06-10 13:50   ` Konrad Dybcio
2026-06-10 14:09     ` Stephan Gerhold
2026-06-09 14:14 ` [PATCH 08/12] clk: qcom: gcc-mdm9607: Drop incorrect system_noc_bfdcd_clk_src Stephan Gerhold
2026-06-10 13:50   ` Konrad Dybcio
2026-06-09 14:14 ` [PATCH 09/12] dt-bindings: clock: qcom: gcc-mdm9607: Drop incorrect clocks Stephan Gerhold
2026-06-09 14:14 ` [PATCH 10/12] dt-bindings: clock: qcom,gcc-mdm9607: Add missing "clocks" property Stephan Gerhold
2026-06-10 13:44   ` Konrad Dybcio
2026-06-09 14:14 ` [PATCH 11/12] dt-bindings: clock: qcom,gcc-mdm9607: Use proper address in example Stephan Gerhold
2026-06-10 13:44   ` Konrad Dybcio
2026-06-09 14:14 ` [PATCH 12/12] clk: qcom: gcc-mdm9607: Drop redundant register update during probe Stephan Gerhold
2026-06-10 13:44   ` Konrad Dybcio
2026-06-10 17:31   ` Taniya Das
2026-06-10 18:02     ` Stephan Gerhold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aimlsgJssczxBGhQ@linaro.org \
    --to=stephan.gerhold@linaro.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shengchao.guo@oss.qualcomm.com \
    --cc=taniya.das@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.