From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D493639182A for ; Wed, 10 Jun 2026 23:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781134870; cv=none; b=sIwU3eg66mx/o+L0wKk3lV7aNiZUNo6aKrYVYRr51Q5JS7Wy5wrHpmPLZJDkG9EXv48OEBOgzfMUo7WcMR2+cCVbyEZSzAc+3aw2/3/XKMB6lcyODvQhyQBL066U6PKsxABMNRVCmmEmzZR6Ld7+cXzMfS4DY0V5GQrgnqE/MUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781134870; c=relaxed/simple; bh=9rozZdgv7t8p8ynviikc0qoAvrM/IC3PX/LUZKZPytU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A1QQCM6fsGzc0pWjotLtDkhhtVVqWdC3CKwMdK+tSrfTVnE8zFfEgmnOo/U6bs3x6P219D1iBTRtzMhGi5DDkmcoOb3VXR5DEiRK7YLBMyEzzeS1VVzPSBC2N+SgEEgY0Q7FVT3j+4rk1BG8I/LZK95/RG0NyQGt4UthI34Mf0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i3E+Nmdn; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i3E+Nmdn" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-307263ad0cbso10352777eec.0 for ; Wed, 10 Jun 2026 16:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781134868; x=1781739668; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/EpTMNZ1obqYILWzMgsVeOkGLftyPXzrtSogbriqTbI=; b=i3E+NmdnxPvm+TD2ZOVj1ywISWo+42wLfmxGd2DaUMupAJhVGVn6tvFU8YYC1zZioP ND+5yb6XPgfaGd/nEBMCQwokjXfN7ZXvklItOIHD/eq/ljpIA1wVZtlZNR2tTaiFGaQ5 vaqQzl+wSP+7rMX7gQrB1Z53JvUKtwSUv4+xsSz4rPWT1wR/ONtlMjtsJ3uRSFJL0J0V MnjHteblJtfSG5rkEU6mg9bNfDhuBneFkv6N+VICAgb1LkJMzI7O88L7TLqCdGZqnzZw 6kACqFKLFnEv71uR8f+WrT7z/FpH+V3alLGtRx3KmXJjuWi4zuxIzFX6O++RPxHFBhkV 23Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781134868; x=1781739668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/EpTMNZ1obqYILWzMgsVeOkGLftyPXzrtSogbriqTbI=; b=dHlrSmXuXqPZEzRpOvZtO7O5VjHQj/ei4j8TWy/sltEwkxYlvJDoYAekFgPtd65Ahr m9wKbsjWytPA05vpJg9Hm76uMEJzg+TdqzFjmVsh8x0xHecFHJ3lYXk9HUwigBAGfLjE gSzUI9LyuBPNzoK99YXQx7hxXLCo+dqp8ScE1SMIWpi5yyiWKLPbDSAdCM+JGH0x9PL7 O9qmTsSKThEW0C5ysQvX6bmuV4+vKhd8ZBlnka4KitFA+EnTwhC63EICdkpBWqgISS6H MUk8jSfff2e61jhaUKDw4jGM4eNtRGc6wQfk212bNPLbHhsfiIhQVzu92L5/q/kmQfJj SfvA== X-Forwarded-Encrypted: i=1; AFNElJ+1qJFV0D2WrjcNz3OyDb7upBP9RLHMQu1bMuaTIUTBVh+RHxnIZRJHNuWVbh+kNJvMYLC6xDlznd/1AjU=@vger.kernel.org X-Gm-Message-State: AOJu0YwMKmAWlH0kCQG+TL6rLwCkS8C5oUa3HnOqd7x75b6R2gjwhNl6 5k0eSE7NoPjjQWUPFwCKjPpzMiIBZH/A1D0jO8Ck1/MqhFs7Hzoi4Xh8 X-Gm-Gg: Acq92OHgMPxfsVnIypygShWQXxK00mVB0P2FyWxkbQgpw6brinlhX3xMDUMDhD+gobo kW9C50kWGDZrtBmtdkk5LLI7YQFfPSHC0NhHS4KcqSn1ZDlpF8HGS+mTPCC6S8DZyMLrdjniUhT mquPHhu7TPbc/6M1qmUBCbgQrDp/ez1uDvtOlyP8ik+3Sx5bum6mYmbPSqePn3hJyMf+cO4UR/M e4yPupvI4Thl0+zO2K+ByrPnMzPeERk4Y+FLSoxHHRhNVykkVQ0/l+BuHck9ZKf4cryMm1H/sXr SBie+3EBwkHNiddabvrJU2D/cVMcY1n+PSlm++pqJPML09CUWsTdC200Rumx9g7mMz1F2z+RXdJ VJS8hRaKVs9VA37SwsgfiexaOoMMXMmJP4jz01a/anewpBwKbKG6gXuR+Qp1OYnIZAwN4R69uei UoDZp58uuqK89BuuXg/eogS4I4NzVclwvw9s0mjg/njg5unjkYVEM88PaZn5CG2BUwvrYErs/os +Y= X-Received: by 2002:a05:7300:6c25:b0:307:934e:da79 with SMTP id 5a478bee46e88-30804b769b7mr347241eec.34.1781134867104; Wed, 10 Jun 2026 16:41:07 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:ae0e:e075:91c8:6570]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074df77a0asm29449322eec.27.2026.06.10.16.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 16:41:06 -0700 (PDT) Date: Wed, 10 Jun 2026 16:41:03 -0700 From: Dmitry Torokhov To: Haoxiang Li Cc: git@apitzsch.eu, Marge.Yang@tw.synaptics.com, kees@kernel.org, jiapeng.chong@linux.alibaba.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Input: synaptics-rmi4 - unregister function handlers on physical driver registration failure Message-ID: References: <20260610064633.2837084-1-haoxiang_li2024@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260610064633.2837084-1-haoxiang_li2024@163.com> Hi Haoxiang, On Wed, Jun 10, 2026 at 02:46:33PM +0800, Haoxiang Li wrote: > If rmi_register_physical_driver() fails, the current error path > unregisters only the RMI bus. The function handlers registered > earlier remain registered with the driver core. > > Add a separate error path to unregister the function handlers > before unregistering the bus in this failure case. > > Fixes: d6e680837ec5 ("Input: synaptics-rmi4 - fix function name in kerneldoc") This is not correct commit for fixes. I changed this to 2b6a321da9a2 ("Input: synaptics-rmi4 - add support for Synaptics RMI4 devices") and applied, thank you. Thanks. -- Dmitry