From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: linux-i2c@vger.kernel.org, Jean Delvare <jdelvare@suse.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH i2c-tools v5] i2ctransfer: Add optional message modifier flags
Date: Wed, 10 Jun 2026 22:48:20 +0200 [thread overview]
Message-ID: <ainNlID05qsaaCD-@shikoro> (raw)
In-Reply-To: <20260610-msg-flags-v5-1-0814fcd44693@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
Hi Benoît,
On Wed, Jun 10, 2026 at 09:49:01AM +0200, Benoît Monin wrote:
> Allow setting protocol mangling and repeated start elision flags of an i2c
> message with a set of optional command-line flags. These optional flags
> are parsed at the beginning of the DESC field up to a read or write flag.
>
> For example, to read one byte from address 0x50 followed by a stop, then
> write two bytes at 0x54 on bus 0, one would call i2ctransfer as follow:
>
> i2ctransfer 0 pr1@0x50 w2@0x54 0x10 0x20
>
> Since the new flags are optional, this patch preserves the compatibility
> of the i2ctransfer syntax.
>
> Handling of the message flags is done in add_flag_if_supported(). This
> function checks if the flag is defined at compile time and if the adapter
> supports the required functionality to handle the flag at runtime.
>
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
Applied, thank you!
It would be awesome if the PRINT_HEADER part could be extended to
display to the user the flags used per message, if any. As an
incremental patch. I don't know if you have time for that?
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-06-10 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 7:49 [PATCH i2c-tools v5] i2ctransfer: Add optional message modifier flags Benoît Monin
2026-06-10 20:48 ` Wolfram Sang [this message]
2026-06-11 7:22 ` Benoît Monin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ainNlID05qsaaCD-@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=benoit.monin@bootlin.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.