From: Pablo Neira Ayuso <pablo@netfilter.org>
To: kernel test robot <lkp@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: net/netfilter/nfnetlink_cthelper.c:227:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true
Date: Thu, 11 Jun 2026 02:25:39 +0200 [thread overview]
Message-ID: <aioAgw4VQVAL78nj@chamomile> (raw)
In-Reply-To: <202606110148.Pn8XckYm-lkp@intel.com>
On Thu, Jun 11, 2026 at 01:32:48AM +0200, kernel test robot wrote:
> vim +227 net/netfilter/nfnetlink_cthelper.c
>
> 209
> 210 static int
> 211 nfnl_cthelper_create(const struct nlattr * const tb[],
> 212 struct nf_conntrack_tuple *tuple)
> 213 {
> 214 struct nf_conntrack_helper *helper;
> 215 struct nfnl_cthelper *nfcth;
> 216 unsigned int size;
> 217 int ret;
> 218
> 219 if (!tb[NFCTH_TUPLE] || !tb[NFCTH_POLICY] || !tb[NFCTH_PRIV_DATA_LEN])
> 220 return -EINVAL;
> 221
> 222 nfcth = kzalloc_obj(*nfcth, GFP_KERNEL_ACCOUNT);
> 223 if (nfcth == NULL)
> 224 return -ENOMEM;
> 225
> 226 helper = kzalloc_obj(*helper, GFP_KERNEL_ACCOUNT);
> > 227 if (!helper)
> 228 goto err_cth;
This seems to be running on an older patch.
prev parent reply other threads:[~2026-06-11 0:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 23:32 net/netfilter/nfnetlink_cthelper.c:227:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true kernel test robot
2026-06-11 0:25 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aioAgw4VQVAL78nj@chamomile \
--to=pablo@netfilter.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.