From: "Oscar Salvador (SUSE)" <osalvador@kernel.org>
To: Lorenzo Stoakes <ljs@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Hildenbrand <david@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 3/3] mm/vma: eliminate mmap_action->error_hook, introduce error_override
Date: Thu, 11 Jun 2026 10:01:47 +0200 [thread overview]
Message-ID: <aipra0klNhB7SG2w@localhost.localdomain> (raw)
In-Reply-To: <55d13f7d016b827c459946d46a56105635be111c.1780397980.git.ljs@kernel.org>
On Tue, Jun 02, 2026 at 12:06:27PM +0100, Lorenzo Stoakes wrote:
> Rather than providing a hook, simplify things by providing the ability to
> override mmap action errors. This allows us to more carefully validate the
> value provided and thus ensure only a valid error code is specified, and
> simplifies the interface.
>
> This way, we eliminate all hooks but mmap_prepare and allow only mmap
> actions to be specified (which core mm controls).
>
> This significantly improves robustness and eliminates any unnecessary code
> duplication in driver mmap hooks.
>
> We also update the /dev/mem logic (the only user) to use
> mmap_action->error_override instead.
>
> Signed-off-by: Lorenzo Stoakes <ljs@kernel.org>
Reviewed-by: Oscar Salvador (SUSE) <osalvador@kernel.org>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2026-06-11 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 11:06 [PATCH v3 0/3] remove mmap_action success, error hooks Lorenzo Stoakes
2026-06-02 11:06 ` [PATCH v3 1/3] drivers/char/mem: eliminate unnecessary use of success_hook Lorenzo Stoakes
2026-06-03 16:25 ` Greg Kroah-Hartman
2026-06-11 7:56 ` Oscar Salvador (SUSE)
2026-06-02 11:06 ` [PATCH v3 2/3] mm/vma: remove mmap_action->success_hook Lorenzo Stoakes
2026-06-11 8:00 ` Oscar Salvador (SUSE)
2026-06-11 9:44 ` Lorenzo Stoakes
2026-06-02 11:06 ` [PATCH v3 3/3] mm/vma: eliminate mmap_action->error_hook, introduce error_override Lorenzo Stoakes
2026-06-02 12:05 ` David Hildenbrand (Arm)
2026-06-11 8:01 ` Oscar Salvador (SUSE) [this message]
2026-06-02 20:10 ` [PATCH v3 0/3] remove mmap_action success, error hooks Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aipra0klNhB7SG2w@localhost.localdomain \
--to=osalvador@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=david@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.