All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Christian Brauner" <brauner@kernel.org>,
	devel@lists.libvirt.org, "Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>
Subject: Re: [PATCH v2 31/35] qom: add method for getting the "id" of a QOM object
Date: Thu, 11 Jun 2026 19:12:53 +0100	[thread overview]
Message-ID: <air6paJPVUJt-pkF@redhat.com> (raw)
In-Reply-To: <178112600400.209622.3065709276056576577.b4-review@b4>

On Thu, Jun 11, 2026 at 01:13:24AM +0400, marcandre.lureau@redhat.com wrote:
> On Wed, 10 Jun 2026 13:34:11 +0100, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > diff --git a/include/qom/object.h b/include/qom/object.h
> > index 11f55613fcd..c828ac63652 100644
> > --- a/include/qom/object.h
> > +++ b/include/qom/object.h
> > @@ -1759,6 +1759,16 @@ ObjectProperty *object_property_try_add_child(Object *obj, const char *name,
> >  ObjectProperty *object_property_add_child(Object *obj, const char *name,
> >                                            Object *child);
> >  
> > +/**
> > + * object_property_get_child_name:
> > + * @obj: the object that owns the property
> > + * @child: the object referenced by the child property
> > + *
> > + * Return the property name against which @child is registered
> > + * with @obj, or NULL if non is present
> 
> "non" -> "none"

I've decided it'll read better saying

  ", or NULL if @obj is not a parent of @child."


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



  reply	other threads:[~2026-06-11 18:13 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 12:33 [PATCH v2 00/35] monitor: turn QMP and HMP into QOM objects Daniel P. Berrangé
2026-06-10 12:33 ` [PATCH v2 01/35] qom: replace 'can_be_deleted' with 'prepare_delete' Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 02/35] monitor: replace 'common' with 'parent_obj' in MonitorHMP Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 03/35] monitor: replace 'common' with 'parent_obj' in MonitorQMP Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 04/35] monitor: rename monitor_init* to monitor_new* Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 05/35] monitor: minimal conversion of monitors to QOM Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 06/35] monitor: add 'chardev' property to Monitor base class Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-11 18:04     ` Daniel P. Berrangé
2026-06-10 12:33 ` [PATCH v2 07/35] monitor: add 'readline' property to HMP Monitor class Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 08/35] monitor: add 'pretty' property to QMP " Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 09/35] monitor: remove 'skip_flush' field Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 10/35] monitor: move monitor_data_(init|destroy) into QOM init/finalize Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 11/35] monitor: use class methods for monitor_vprintf Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 12/35] monitor: use class methods for monitor_qapi_event_emit Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 13/35] monitor: use class methods for monitor_accept_input Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 14/35] monitor: use class method for I/O thread request Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 15/35] monitor: use dynamic cast in monitor_qmp_requests_pop_any_with_lock Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 16/35] util: use dynamic cast in error vreport Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 17/35] monitor: drop unused monitor_cur_is_qmp Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 18/35] monitor: use dynamic cast in QMP commands Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:33 ` [PATCH v2 19/35] monitor: use dynamic cast in monitor_is_hmp_non_interactive Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 20/35] monitor: drop unused monitor_is_qmp method Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 21/35] monitor: eliminate monitor_is_hmp_non_interactive method Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 22/35] monitor: implement "user creatable" interface for adding monitors Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 23/35] qemu-options: document new monitor-hmp and monitor-qmp objects Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 24/35] monitor: convert from oneshot BH to persistent BH Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 25/35] monitor: reject attempts to delete the current monitor Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 26/35] monitor: protect qemu_chr_fe_accept_input with monitor lock Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 27/35] monitor: implement support for deleting QMP objects Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 28/35] tests/qtest: add tests for dynamic monitor add/remove Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 29/35] tests/functional: add e2e test for dynamic QMP monitor hotplug Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 30/35] tests/functional: add a stress test for monitor hot unplug Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-11 18:11     ` Daniel P. Berrangé
2026-06-10 12:34 ` [PATCH v2 31/35] qom: add method for getting the "id" of a QOM object Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-11 18:12     ` Daniel P. Berrangé [this message]
2026-06-10 12:34 ` [PATCH v2 32/35] qom: add trace events for user creatable create/delete APIs Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 33/35] monitor: add support for auto-deleting monitors upon close Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-11 18:18     ` Daniel P. Berrangé
2026-06-10 12:34 ` [PATCH v2 34/35] tests: switch from -mon to -object monitor-qmp Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau
2026-06-10 12:34 ` [PATCH v2 35/35] docs: mark '-mon' as deprecated in favour of -object Daniel P. Berrangé
2026-06-10 21:13   ` marcandre.lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=air6paJPVUJt-pkF@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=brauner@kernel.org \
    --cc=dave@treblig.org \
    --cc=devel@lists.libvirt.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@mailo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.