Re: [PATCH v3 RESEND 1/2] scsi: mpt3sas: add IO Unit Page 7 config accessor

[Louis Sautier <sautier.louis@gmail.com>]

On Wed, 10 Jun 2026 08:12:05 +0800, Damien Le Moal wrote:
> > +int
> > +mpt3sas_config_get_iounit_pg7(struct MPT3SAS_ADAPTER *ioc,
> 
> Please do not break the line after "int"

Hi and thanks for the review.

Sure, I can change this. Can you confirm we want to diverge from the
convention used by neighbouring functions such as
mpt3sas_config_get_iounit_pg8?

> > +	Mpi2ConfigReply_t *mpi_reply, Mpi2IOUnitPage7_t *config_page)
> > +{
> > +	Mpi2ConfigRequest_t mpi_request;
> > +	int r;
> > +
> > +	memset(&mpi_request, 0, sizeof(Mpi2ConfigRequest_t));
> > +	mpi_request.Function = MPI2_FUNCTION_CONFIG;
> > +	mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_HEADER;
> > +	mpi_request.Header.PageType = MPI2_CONFIG_PAGETYPE_IO_UNIT;
> > +	mpi_request.Header.PageNumber = 7;
> > +	mpi_request.Header.PageVersion = MPI2_IOUNITPAGE7_PAGEVERSION;
> > +	ioc->build_zero_len_sge_mpi(ioc, &mpi_request.PageBufferSGE);
> > +	r = _config_request(ioc, &mpi_request, mpi_reply,
> > +	    MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0);
> 
> 	r = _config_request(ioc, &mpi_request, mpi_reply,
> 			    MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0);
> 
> is a lot nicer to read.

Do I also align the signature like so in both the source file and the
header?

int mpt3sas_config_get_iounit_pg7(struct MPT3SAS_ADAPTER *ioc,
				  Mpi2ConfigReply_t *mpi_reply,
				  Mpi2IOUnitPage7_t *config_page)