From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3C93750D7 for ; Thu, 11 Jun 2026 22:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781215742; cv=none; b=u32W4qj8yslgY4rzDPDgR/GUQ6MJDjmKocP/ZG9Pgix7i2/xPUld9VYYHBJ9dCP1/umKfucBJZ9MJitxK5PvvFzsGqc5wQOdr2eG2k+ylafZ0lfbxB30R5aPG1HDPKnfUb91YTibNBOX9nFGvkMOXnG9NL6d5l3Cn1HH6Az9wqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781215742; c=relaxed/simple; bh=tdYIWkIppgi9TdVj5TLsUADT2USDPBaMKl8umwjUS0Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LS883E5q88RLeXwRiYB57lqIEjaikSQCYlG4pfm+W6KLfbr5Leb2lLzwaGr56OV9be5SMiv9+OCWxGgztXGbK3rcTNHIHT50s9JN5zdwZSff1xDMAxb3fwC9Ilf8k+DgypuJRB6Fdh4Jogbw9Nv6YF51Ag0UkZLQBLXJe8uGsO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=NcwosydE; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="NcwosydE" Date: Fri, 12 Jun 2026 00:08:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1781215739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m9qk78MQ9cepfQ7j55pEXsUCwYOxq6YxqkT2NLtU6go=; b=NcwosydE5fMA8AlB/wCuQl5aBu/KK1tVy8T0EY24bljBF1U83oryN47rPSTtMG9o8hsyUL cYqce1dPg+DStI+DgVODdA4SMlkGVm0XOdwodeBqBWm5sWywcoU+SHDhmsPlKYeojN5k5U lcFsIMS1U5kRj8Uku7w0fCVCJjn3WQw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Mike Marshall , Martin Brandenburg Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] orangefs: Remove commented out code in find_cached_xattr Message-ID: References: <20251221124713.171813-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251221124713.171813-2-thorsten.blum@linux.dev> X-Migadu-Flow: FLOW_OUT Gentle ping or do you prefer to keep this for some reason? On Sun, Dec 21, 2025 at 01:47:13PM +0100, Thorsten Blum wrote: > The code has been commented out since 2017 - remove it. > > Signed-off-by: Thorsten Blum > --- > fs/orangefs/xattr.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/orangefs/xattr.c b/fs/orangefs/xattr.c > index eee3c5ed1bbb..4043942a3c33 100644 > --- a/fs/orangefs/xattr.c > +++ b/fs/orangefs/xattr.c > @@ -72,11 +72,6 @@ static struct orangefs_cached_xattr *find_cached_xattr(struct inode *inode, > if (hlist_empty(h)) > return NULL; > hlist_for_each_entry_safe(cx, tmp, h, node) { > -/* if (!time_before(jiffies, cx->timeout)) { > - hlist_del(&cx->node); > - kfree(cx); > - continue; > - }*/ > if (!strcmp(cx->key, key)) > return cx; > }