From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1C02C158A for ; Fri, 12 Jun 2026 05:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781240971; cv=none; b=QoqY+PMLgGdeqony8PredMbOOEVr57y7OThtvfzJwDb5TDmY9dc7l9O27KQVXwiefxAdlYWU70pV6FM63atgqqenIujEImowdnF5NPYqA71TrFOpxsK4Jbr6VnBKMMPUmYLYd8HcFumYRUAzHGoOKPBda0HgA2BBmhLYBXxOY/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781240971; c=relaxed/simple; bh=2d9RYWj8r1oTCAkc+C4XVoWcBwvVv9VJWnvoviVxx+g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m1RhaD1PYRLuRJj0rOpwqrULvF/D4em1hGAX/OK+AvuiOrS4l1agMqr4PpYHfiNJD6iQNaxPSdxhRReugCe/TPqhRoaTRXRS66uKRH4Z2TAw6RkT7oRuMcXbPZq1quN/jI93wtpWZ00ojgSVGA9/J2Ilh+pLBHioKKW6m4lOgMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZAXgndqI; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZAXgndqI" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-3078e0dcd67so821840eec.0 for ; Thu, 11 Jun 2026 22:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781240969; x=1781845769; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qQf40t+XAnj4WjkRJ82enIpqA5VF4hgAzXWBOuP1Kmo=; b=ZAXgndqIWxSWN72kV/xWNVNfmizyvU/WIXucxs8FUpOEVUEjl5O9Msmqh1utJHR3/g hs8j/fZQSw39HrVeQXpITlFJAiditDdb3ZATKKJSAWlWm4llneFF3VpFwwosQuCPCvLe 8AATw7sXeH+dIwgYFaM3XC25/+LVpvQNd41EE/p7j8KDca0sc5HfLT1Tq8c5zLTXqr39 tSulhcKd+/XyQn7awT0j5Z078HKuCOlcNSGMTirvvx2leV7dHsFIbtvULZfMm3aOdOFd u4yhk5lZqbqy/NzQpfA7fu8zVjzpCMLfgoKEtjjlp/ug+gPgCTPNbxZFoZP67jno61zs 6lEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781240969; x=1781845769; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qQf40t+XAnj4WjkRJ82enIpqA5VF4hgAzXWBOuP1Kmo=; b=dLWFVEmCal/+1k5yBPufI+a7VvgCAOb7wkArpdGXpKGPcB0cOD6jfNzEF+DRA7YTiq 3M1fqRvZ700sFSzqS24SeAAU7q7mIF68K3LhmVOf1f4ySg/2s7GgnBEcxd9XwPEzGoUx gKS/P/DbiGRFy1IUE2EO5ClAe3f0iRIrV//Vv6xSdJpjBRkUqhGXnSwZb0vGc6XMIyLv wJXc3zBu6UYmTFiViwB6X9YGFiUYoDAZAzLfUDV6v+UgNy0LVOYnR8oYaat0qTwqrztb hvpiRPhx8SnGFN5CWuRIfcnge59Skagm9nYNYODgHIliz88KiawDbmVHVJ76RAt43TG8 Wwqw== X-Forwarded-Encrypted: i=1; AFNElJ8Ou6gplWgDh8kcHNQsn1KkQmit3Jyi4l0ScyYV79yKUdgy+C4m/I5HUYWLTfbxAHiSZzowkp7Cle6Dqm4=@vger.kernel.org X-Gm-Message-State: AOJu0YxeRFBShuSt5K0/v1m40Id29LJxHJ58R04/mt33T+KKLKMEQNT7 mgLx+PmrSuWXrOcA8s9ZCHuliLezMyG1lO40qslPNHqLa5jNYC69IB5i X-Gm-Gg: Acq92OHba2FTI5Og/rSV2OULbIMAc3Bq7a88n/lgXRU7SecjDloPPqbh1rhm7xznWj7 NC75yigDK59K+XCnt2gqxoJyczOOSlmsWu/H7no3PUczHdJ3u3tQgr+FP3mGOCD99JG+aOpOFxV mrQWq9zRqfIf83Y8uoSXP+M4HiqGR3abXk4iSxv2FBON2ljel/AO8MKCd7byOeyDeOFz3hk/Qx/ 0mejYBx7LqGCIY/SSJt5qGnn5it0Ro3i1dZwY6jWWBleKPGWcfYg/RGsxoeUkb4REolwe/qWwpw dhGAQhwOKXNevj0aXAXVTlYZWIkFdrLCqSGJulcp206T0Wkd9Kd3g+FvNRQPt18XP5sRLfSWlrU LvDTaeL+oiYLdnWStzIMGT6iuXBo8jzvCgIO9qKc2U86aDsKV1f4VFDwyFhd5zkepV9nKvZLrk7 ruu2q8BjJ8GrpS3UNqVhV0ksjhruEMN9r6b7UvLw46c4ZIgK50Z3Vn5CyLrPS9JA8= X-Received: by 2002:a05:7300:a14b:b0:2c4:4363:3742 with SMTP id 5a478bee46e88-3081ff8dc35mr697001eec.9.1781240969388; Thu, 11 Jun 2026 22:09:29 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:9d2c:f2c6:4caa:ca5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e4898c0sm1961017eec.3.2026.06.11.22.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 22:09:28 -0700 (PDT) Date: Thu, 11 Jun 2026 22:09:25 -0700 From: Dmitry Torokhov To: Matti Vaittinen Cc: Lee Jones , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys Message-ID: References: <20260611-rohm-software-nodes-v5-0-0244664a3b65@gmail.com> <075d48b7-5cb2-43a4-aacb-e11a9ac916a5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <075d48b7-5cb2-43a4-aacb-e11a9ac916a5@gmail.com> Hi Matti, On Fri, Jun 12, 2026 at 07:40:49AM +0300, Matti Vaittinen wrote: > On 12/06/2026 07:38, Matti Vaittinen wrote: > > On 11/06/2026 18:48, Dmitry Torokhov wrote: > > > Now that gpio-keys can use platform resources to identify interrupts > > > assigned to buttons we can convert ROHM power buttons to use software > > > nodes and device properties for configuration, removing the need to use > > > platform data. > > > > > > Signed-off-by: Dmitry Torokhov > > > ---> Changes in v5: > > > Addressed Lee's comments: > > > - moved static constants out of function to module level > > > - added #defines for nodes' indexes > > > - adjusted error message > > > - renamed "error" to "ret" > > > - dropped unneeded comments > > > - Link to v4: https://patch.msgid.link/20260427-rohm-software-nodes- > > > v4-0-ffeb5b0c4774@gmail.com > > > > I think I did already review these? Is there a reason my tags were dropped? > > "These" referring to these patches, not the v5 changes (which seem minor to > drop the tags). Sorry, I decided to exercise caution and not carry over the tags. I apologize for the mistake. > Furthermore, is there a reason I was not CC'd? Especially if > there was a reason to drop the tags. I see the following on the emails: > To: Matti Vaittinen , Lee Jones so I am not sure why they did not reach you... Thanks. -- Dmitry