From: Weijie Yuan <wy@wyuan.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] MyFirstContribution: mention trimming quoted text in replies
Date: Fri, 12 Jun 2026 16:39:36 +0800 [thread overview]
Message-ID: <aivFyBanzoHnYRsy@wyuan.org> (raw)
In-Reply-To: <xmqqcxxwljue.fsf@gitster.g>
On Thu, Jun 11, 2026 at 04:48:25PM -0700, Junio C Hamano wrote:
> [...]
> > diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> > index 607876f3d8..0e2a9313ce 100644
> > --- a/Documentation/MyFirstContribution.adoc
> > +++ b/Documentation/MyFirstContribution.adoc
> > @@ -1453,6 +1453,11 @@ effect which had not occurred to you. It is always okay to ask for clarification
> > if you aren't sure why a change was suggested, or what the reviewer is asking
> > you to do.
> >
> > +When replying to review comments, quote only the parts of the message that are
> > +relevant to your response. It is usually helpful to trim away unrelated context,
> > +such as large portions of the patch that are not being discussed, while keeping
> > +enough quoted text for readers to understand what you are responding to.
> > +
> > Make sure your email client has a plaintext email mode and it is turned on; the
> > Git list rejects HTML email. Please also follow the mailing list etiquette
> > outlined in the
>
> The insertion point is well chosen, immediately following the
> discussion on how to handle review comments and before the technical
> details of email client configuration. The text itself is clear and
> gives sound advice.
Thank you for your reply.
I first considered folding this into one of the existing paragraphs
above, but ended up making it a separate paragraph for better clarity.
Let's see whether others have better wording suggestions.
Now the expectations for contributors and reviewers are more aligned
when participating in review discussions :-)
Hopefully this addition will make review discussions a little easier to
focus and reduce the burden on reviewers.
Thanks!
prev parent reply other threads:[~2026-06-12 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 14:14 [RFC PATCH] MyFirstContribution: mention trimming quoted text in replies Weijie Yuan
2026-06-11 23:48 ` Junio C Hamano
2026-06-12 8:39 ` Weijie Yuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aivFyBanzoHnYRsy@wyuan.org \
--to=wy@wyuan.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.