From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Anthony Yznaga <anthony.yznaga@oracle.com>,
Mark Brown <broonie@kernel.org>,
Sarthak Sharma <sarthak.sharma@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aishwarya TCV <Aishwarya.TCV@arm.com>
Subject: Re: [PATCH] selftests: mm: fix and speedup "droppable" test
Date: Fri, 12 Jun 2026 19:04:15 +0200 [thread overview]
Message-ID: <aiw8D_tdKYYNGyN_@zx2c4.com> (raw)
In-Reply-To: <20260611-droppable_test-v1-1-b6a73d99f658@kernel.org>
On Thu, Jun 11, 2026 at 12:01:55PM +0200, David Hildenbrand (Arm) wrote:
> The droppable test currently relies on creating memory pressure in a
> child process to trigger dropping the droppable pages.
>
> That not only takes a long time on some machines (allocating and filling
> all that memory), on large machines this will not work as we hardcode the
> area size to 134217728 bytes.
>
> ... further, we rely on timeouts to detect that memory was not dropped,
> which is really suboptimal.
>
> Instead, let's just use MADV_PAGEOUT on a 2 MiB region. MADV_PAGEOUT works
> with droppable memory even without swap.
>
> There is the low chance of MADV_PAGEOUT failing to drop a page because
> of speculative references. We'll wait 1s and retry 10 times to
> rule that unlikely case out as best as we can.
Wow, thanks! I wish I had realized the MADV_PAGEOUT behavior while developing
VM_DROPPABLE in the first place. That would have made development a lot easier.
I wound up just running this in a memory limited VM to test out the different
behaviors, which worked decent enough for verifying things. It would be
interesting to me to now experiment with vgetrandom behavior over intentionally
MADV_PAGEOUT'd droppable mappings, to fuzz that the careful bookchecking of
that works as intended against droppable mappings. Anyway, thanks and:
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
prev parent reply other threads:[~2026-06-12 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:01 [PATCH] selftests: mm: fix and speedup "droppable" test David Hildenbrand (Arm)
2026-06-11 11:07 ` Sarthak Sharma
2026-06-11 11:26 ` David Hildenbrand (Arm)
2026-06-11 11:32 ` Lance Yang
2026-06-11 12:13 ` Sarthak Sharma
2026-06-11 11:15 ` Lance Yang
2026-06-11 11:19 ` Dev Jain
2026-06-11 11:26 ` David Hildenbrand (Arm)
2026-06-11 11:28 ` Dev Jain
2026-06-12 1:29 ` SeongJae Park
2026-06-12 7:35 ` David Hildenbrand (Arm)
2026-06-12 7:58 ` Lorenzo Stoakes
2026-06-12 8:00 ` David Hildenbrand (Arm)
2026-06-12 8:26 ` Lorenzo Stoakes
2026-06-12 17:04 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiw8D_tdKYYNGyN_@zx2c4.com \
--to=jason@zx2c4.com \
--cc=Aishwarya.TCV@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=broonie@kernel.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.